Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix savewhen issues #648

Merged
merged 18 commits into from
Feb 14, 2022
Merged

Fix savewhen issues #648

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ae5fc4b
fix issues with savewhen
JoranAngevaare Feb 12, 2022
919bdb6
fixes
JoranAngevaare Feb 12, 2022
13a1273
import'
JoranAngevaare Feb 12, 2022
35f8ee0
another fix
JoranAngevaare Feb 12, 2022
c160418
sometimes I wonder why I work on saturdays, other times I wonder why …
JoranAngevaare Feb 12, 2022
f994484
one more fix
JoranAngevaare Feb 12, 2022
91940ab
Update pytest.yml
JoranAngevaare Feb 12, 2022
2f2fdac
Update testutils.py
JoranAngevaare Feb 13, 2022
055d605
Update testutils.py
JoranAngevaare Feb 13, 2022
0fc4e0a
Merge branch 'master' into fix_savewhen_issues
JoranAngevaare Feb 13, 2022
330478b
Update context.py
JoranAngevaare Feb 13, 2022
6de42be
Update test_context.py
JoranAngevaare Feb 13, 2022
1540ba1
Update context.py
JoranAngevaare Feb 13, 2022
3e3bfbe
Update context.py
JoranAngevaare Feb 13, 2022
4f26f2e
one more issue found
JoranAngevaare Feb 13, 2022
5ebf207
typos
JoranAngevaare Feb 13, 2022
1cc7f43
expand a bit
JoranAngevaare Feb 13, 2022
a41c2b2
add test for issue
JoranAngevaare Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion strax/run_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@ def available_for_run(self: strax.Context,
is_stored = defaultdict(list)
for target in self._plugin_class_registry.keys():
# Skip targets that are not stored
if not self._plugin_class_registry[target].save_when > strax.SaveWhen.NEVER:
save_when = self.get_save_when(target)
if save_when == strax.SaveWhen.NEVER:
Comment on lines -426 to +428
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue 3

continue

# Should we include this target or exclude it?
Expand Down