Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urllib3 version to 1.26.15 #723

Merged
merged 1 commit into from May 9, 2023
Merged

Fix urllib3 version to 1.26.15 #723

merged 1 commit into from May 9, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented May 9, 2023

Similar to XENONnT/straxen#1177

What is the problem / what does the code in this PR do

Because from 2.0.0 urllib3 does not support OpenSSL versions older than 1.1.1. So triggered this failure: https://readthedocs.org/projects/straxen/builds/20440356/. Reference: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#what-are-the-important-changes.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

Coverage: 92.215%. Remained the same when pulling addeffd on fix_urllib3 into 73402a3 on master.

@dachengx dachengx merged commit 6820cf4 into master May 9, 2023
10 checks passed
@dachengx dachengx deleted the fix_urllib3 branch May 9, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants