Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urllib3 version to 1.26.15 #1177

Merged
merged 2 commits into from May 5, 2023
Merged

Fix urllib3 version to 1.26.15 #1177

merged 2 commits into from May 5, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented May 5, 2023

What does the code in this PR do / what does it improve?

Because from 2.0.0 urllib3 does not support OpenSSL versions older than 1.1.1. So triggered this failure: https://readthedocs.org/projects/straxen/builds/20440356/. Reference: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#what-are-the-important-changes.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@coveralls
Copy link

coveralls commented May 5, 2023

Coverage Status

Coverage: 93.437% (-0.01%) from 93.447% when pulling 2caed52 on fix_urllib3 into 306d98e on master.

@dachengx dachengx merged commit 78bd324 into master May 5, 2023
7 checks passed
@dachengx dachengx deleted the fix_urllib3 branch May 5, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants