Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parentheses to separate the class name and attributes in the representation of StorageFrontend #809

Merged
merged 2 commits into from Mar 7, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Mar 3, 2024

What is the problem / what does the code in this PR do

Previously the representation of StorageFrontend was somehow confusing:

[straxen.storage.rundb.RunDB, readonly: True, strax.storage.files.DataDirectory, readonly: True, path: /dali/lgrandi/xenonnt/raw, take_only: ('raw_records', 'raw_records_he', 'raw_records_aqmon', 'raw_records_nv', 'raw_records_aqmon_nv', 'raw_records_aux_mv', 'raw_records_mv'), strax.storage.files.DataDirectory, readonly: True, path: /dali/lgrandi/xenonnt/processed, strax.storage.files.DataDirectory, readonly: True, path: /project2/lgrandi/xenonnt/processed]

This PR use the parentheses to separate the class name and its attributes:

[straxen.storage.rundb.RunDB (readonly: True), strax.storage.files.DataDirectory (readonly: True, path: /dali/lgrandi/xenonnt/raw, take_only: ('raw_records', 'raw_records_he', 'raw_records_aqmon', 'raw_records_nv', 'raw_records_aqmon_nv', 'raw_records_aux_mv', 'raw_records_mv')), strax.storage.files.DataDirectory (readonly: True, path: /dali/lgrandi/xenonnt/processed)]

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

@dachengx dachengx marked this pull request as ready for review March 3, 2024 13:27
Copy link

github-actions bot commented Mar 3, 2024

Coverage Status

coverage: 91.506% (+0.09%) from 91.42%
when pulling 56a0e81 on sf_repr
into 55d82b0 on master.

@coveralls
Copy link

Coverage Status

coverage: 91.47% (+0.05%) from 91.42%
when pulling 56a0e81 on sf_repr
into 55d82b0 on master.

@dachengx dachengx requested review from WenzDaniel and removed request for WenzDaniel March 6, 2024 12:25
@yuema137
Copy link
Collaborator

yuema137 commented Mar 6, 2024

@dachengx I checked that the representation of StorageFrontend is not used directly and is just a property to provide information. So the format change looks good to me.

@dachengx dachengx merged commit 95386ed into master Mar 7, 2024
9 checks passed
@dachengx dachengx deleted the sf_repr branch March 7, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants