Skip to content

Commit

Permalink
feat: onClick is no longer required on navbar and steplink (#441)
Browse files Browse the repository at this point in the history
Co-authored-by: Johnathan MEUNIER <jonathan.meunier@axa.fr>
  • Loading branch information
johnmeunier and johnmeunier committed Jul 22, 2020
1 parent c6d0ac6 commit 723d48e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/Form/steps/src/StepLink.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const propTypes = {
...Constants.propTypes,
id: PropTypes.string.isRequired,
href: PropTypes.string,
onClick: PropTypes.func.isRequired,
onClick: PropTypes.func,
number: PropTypes.oneOfType([PropTypes.element, PropTypes.string]).isRequired,
title: PropTypes.string.isRequired,
icon: PropTypes.string,
Expand Down
2 changes: 1 addition & 1 deletion packages/Layout/header/src/NavBar/NavBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { setPosition } from './NavBar.helpers';
const propTypes = {
...Constants.propTypes,
isVisible: PropTypes.bool.isRequired,
onClick: PropTypes.func.isRequired,
onClick: PropTypes.func,
id: PropTypes.string,
toggleMenuId: PropTypes.string,
children: PropTypes.node,
Expand Down
2 changes: 1 addition & 1 deletion packages/Layout/header/src/NavBar/NavBarBase.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import ToggleButton from '../ToggleButton';
const propTypes = {
...Constants.propTypes,
isVisible: PropTypes.bool.isRequired,
onClick: PropTypes.func.isRequired,
onClick: PropTypes.func,
handleKeys: PropTypes.func.isRequired,
onFocus: PropTypes.func.isRequired,
onBlur: PropTypes.func.isRequired,
Expand Down

0 comments on commit 723d48e

Please sign in to comment.