feat: onClick is no longer required on navbar and steplink

[johnmeunier]

Related issue

Description of the issue

onClick prop was required on some component. If you know other useless required prop, add them on this PR.

Person(s) for reviewing proposed changes

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

[guillaumechervetaxa]

May be you should check if(onClick != null)

onClick(e) {
e.preventDefault();
const { id, href, number, title, onClick } = this.props;
onClick({
href,
number,
id,
title,
});
}

[johnmeunier]

Where do you find this code code ?

[guillaumechervetaxa]

onto this file => packages/Form/steps/src/StepLink.js
the idea is to secure the remove of is required for all the use case.

[johnmeunier]

I'm not sure that correspond to my problem. Indeed, each time I use a Step component without an onClick props, I have an error in the console. If I add a onClick condition without removing the isRequired from the PropTypes declaration, the error will still be in the console.

[johnmeunier]

@samuel-gomez-axa , what do you think about this ?

[samuel-gomez-axa]

No problem, you can set this props optional to remove the warning.

But if you just set this props not required, the StepLink will try to call the onClick and throw an error like this :

So you have to verify if this onClick props is not null and not call if its null

[samuel-gomez-axa]

can you add an example in the story , please ?
with no onClick props : https://github.com/AxaGuilDEv/react-toolkit/tree/master/storybook/storybook/src/packages/Form/steps/src

[samuel-gomez-axa]

no problem here for just set props not required :)

[samuel-gomez-axa]

can you add an example in the story , please ?
with no onClick props : https://github.com/AxaGuilDEv/react-toolkit/tree/master/storybook/storybook/src/packages/Layout/header/src/NavBar

[xballoy]

LGTM