Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate popover @0.x to @1.x #122

Merged
merged 10 commits into from
Apr 4, 2019
Merged

Conversation

barry-thierno
Copy link
Contributor

Related issue

#17

Reference to the issue

#17
Here you can add link to related issue

Description of the issue

This issue is due to the upgrade of react-popper which is in 1.3.3. Toolkit popover is in 0.8.3 but pull the ^1.12.9 of react-popper and use Arrow and Target component which are not available in react-popper up to 1.x.x
image

Your description

Person(s) for reviewing proposed changes

You can add @mention here

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@mergify mergify bot merged commit 4cd87d0 into master Apr 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/Issue_17_migrate_popover branch April 4, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants