Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all) remove recompose #421

Merged
merged 16 commits into from
Nov 22, 2019
Merged

Conversation

guillaumechervetaxa
Copy link
Contributor

Related issue

Copy link
Contributor

@samuel-gomez-axa samuel-gomez-axa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

énorme PR, j'ai rien vu de particulier. Beau boulot :)
Ce serait pas mal de prévoir des phases de recette après autant de changements

@guillaumechervetaxa guillaumechervetaxa marked this pull request as ready for review November 20, 2019 10:14
@guillaumechervetaxa
Copy link
Contributor Author

Je réalise les corrections et je te propose de pousser une alpha ?

sur le storybook je ne vois pas de bug, mais j'aimerais bien tester sur quelques projet avant d'enlever le alpha.

# Conflicts:
#	packages/Form/Input/card/package.json
#	packages/Form/Input/checkbox/package.json
#	packages/Form/Input/choice/package.json
#	packages/Form/Input/number/package.json
#	packages/Form/Input/select/package.json
#	packages/Form/Input/switch/package.json
#	packages/Form/Input/text/package.json
#	packages/Form/filter-inline/package.json
#	packages/Form/filter/package.json
#	packages/Form/steps/package.json
#	packages/Form/summary/package.json
#	packages/Layout/footer-client/package.json
#	packages/Layout/footer/package.json
#	packages/Layout/header/package.json
#	packages/Modal/boolean/package.json
#	packages/action/package.json
#	packages/alert/package.json
#	packages/badge/package.json
#	packages/button/package.json
#	packages/collapse/package.json
#	packages/help/package.json
#	packages/highlight/package.json
#	packages/icon/package.json
#	packages/link/package.json
#	packages/list/package.json
#	packages/loader/package.json
#	packages/panel/package.json
#	packages/status/package.json
#	packages/table/package.json
#	packages/title/package.json
@guillaumechervetaxa
Copy link
Contributor Author

guillaumechervetaxa commented Nov 20, 2019

Manque plus que ta validation @samuel-gomez-axa

Copy link
Contributor

@samuel-gomez-axa samuel-gomez-axa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo !

@guillaumechervetaxa guillaumechervetaxa merged commit 53bda17 into master Nov 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/remove-recompose branch November 22, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants