refactor(react-toolkit-form): rollback remove use of componentWillUpdate #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use UNSAFE version of componentWillReceiveProps because in some edge cases it didn't work anymore
xballoy
changed the title
guillaumechervetaxa
approved these changes
Jun 4, 2020
youf-olivier
approved these changes
Jun 4, 2020
samuel-gomez-axa
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback #613 because
forceDisplayMessagedidn't work anymoreI used the UNSAFE version of componentWillReceiveProps instead of removing it.
We need to be able to create a unit test but I don't know how...