-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump react-popper to version 2 #625
build: bump react-popper to version 2 #625
Conversation
@@ -40,7 +40,7 @@ | |||
"@types/jest": "^23.3.11", | |||
"@types/prop-types": "^15.5.8", | |||
"@types/react": "^16.7.18", | |||
"@types/react-modal": "^3.6.0", | |||
"@types/react-modal": "3.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to force the version because I don't know why but it always downloaded a newer version which breaks the modal package.
package.json
Outdated
@@ -137,7 +137,7 @@ | |||
"react-router-dom": "4.1.0", | |||
"react-scripts": "^1.1.5", | |||
"react-syntax-highlighter": "^7.0.4", | |||
"react-test-renderer": "^16.7.0", | |||
"react-test-renderer": "^16.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The react-test-renderer
version wasn't aligned with react
and react-dom
position: absolute; | ||
z-index: -1; | ||
|
||
&::before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrow is now in a ::before
pseudo-element so I rewrote it so it's now easier to override
I Merged an older PR before this one, and so you have some conflicts |
7af7a52
I updated the PR to solve the conflicts: rebase on master and remove the reference to AXA Nexus |
Holly s... seriously ? |
BREAKING CHANGE: - The style of the arrow is now in a `::before` pseudo-element. - `data-placement` of the Popover is now `data-popper-placement`. See the migration guide for more information: https://popper.js.org/docs/v2/migration-guide/
eaa245d
Bump react-potter to latest version. I had to add @popperjs/core as dependency. See react-popper migration guide.
I refactored the unit tests of Popover to have functional tests so they do not depend on the implementation.
Changes :
data-placement
becomesdata-popper-placement
so it might break CSS if people are overriding the default behavior::before
pseudo-element because Popper uses transform to position the arrow inside the popperTo override the design of the arrow you need to write the following CSS:
@guillaume-chervet @samuel-gomez @youf-olivier