New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popover): fix a11y for popover #636

Merged

youf-olivier merged 1 commit into master from feature/popover_a11y

Jun 19, 2020

Contributor

xballoy commented Jun 18, 2020

Fix a11y issue on the popover when "click" mode:

Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events
Static HTML elements with event handlers require a role jsx-a11y/no-static-element-interactions


          feat(popover): fix a11y for popover

d4312ce

xballoy requested review from samuel-gomez-axa and youf-olivier

June 18, 2020 15:44

Contributor Author

xballoy commented Jun 19, 2020 •

edited

Loading

Fix a a11y issued introduced by #625

youf-olivier approved these changes

View reviewed changes

guillaumechervetaxa approved these changes

View reviewed changes

youf-olivier merged commit a9223af into master

delete-merged-branch bot deleted the feature/popover_a11y branch

June 19, 2020 09:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment