Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory-one error in compute FSM memory. #1242

Closed
wants to merge 46 commits into from
Closed

Fix memory-one error in compute FSM memory. #1242

wants to merge 46 commits into from

Conversation

gaffney2010
Copy link
Member

In using, I uncovered a bug. Basically memory-zero and memory-one cases need to be handled specially. I was checking this case with a condition on the number of memit-pairs, but in fact a memory-one strategy could have a long chain memit-pairs that all suggest the same set of reactions.

So I fixed this, and added a test that would have caught this error.

gaffney2010 and others added 30 commits December 30, 2018 20:41
Clean up docstrings, to match parameter-listing to actual parameters.
94ebbee
Response to meatballs' feedback.
193e8ab
Merge https://github.com/Axelrod-Python/Axelrod
b1be726
Added a get_memory_from_transitions function for FSM.
0822b5c
Change default verbosity of get_memory_from_transitions.
395a040
Fixed build error, and made less verbose.
2caf106
Change the format of transitions in get_memory_from_transitions to dict.
7294426
Added types to get_memory_from_transitions.
080bf8c
Make ActionChains faster.
d0769e8
Replaced get_accessible_transitions with a much faster version.
0e6803e
Updated tests for new memory classifiers.
ffc319a
Fixed mypy and doctest errors.
b8e2b44
Updated metastrategies for new finite set.
b603e7e
Moved blocks/added comments for readability.
95a1d13
More specific typing.
ebbcf73
Responded to Marc's comments.
8d22d95
Import List from typing.
f2340ad
Change DefaultDict type and added tit_for_five_tat test.
2e3c7e4
Remove type on all_memits
d5e2b43
Remove more typing.
0a62b74
Fixed type on longest_path argument.
9df30e3
Responding to Marc's comments.
87792a2
Fixed Tuple annotation.
b4e6c41
@drvinceknight
Add a memory test to default FSM test.
6763610
Responded to some of drvinceknight comments on memory depth.
f5d6129
@gaffney2010
Merge pull request #1 from Axelrod-Python/add-test-of-memory-to-all-fsms
28f90ae 
Add a memory test to default FSM test.
Fixed some errors.
222759e
Merge branch 'master' of https://github.com/gaffney2010/Axelrod
50e8284
Moved FSM memory functions to separate top-level file compute_finite_…
9cae641 
…state_machine_memory
Added additional topic documentation for FSM/memory.
676b722
gaffney2010 and others added 15 commits January 23, 2019 23:57
drvinceknight
drvinceknight requested changes Feb 26, 2019
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Any chance you could rebase on to master?

drvinceknight
drvinceknight approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticked the wrong box: didn't mean to request changes. 👍

@gaffney2010
Copy link
Member Author

Any chance you could rebase on to master?

I'm trying. Afraid I'm only making it worse.

@gaffney2010 gaffney2010 mentioned this pull request Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drvinceknight drvinceknight drvinceknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaffney2010 @drvinceknight