Fix memory-one error in compute FSM memory #1243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using, I uncovered a bug. Basically memory-zero and memory-one cases need to be handled specially. I was checking this case with a condition on the number of memit-pairs, but in fact a memory-one strategy could have a long chain memit-pairs that all suggest the same set of reactions.
So I fixed this, and added a test that would have caught this error.
I created a copy of #1242, because I'm bad at git.