Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tracing in DisruptorCommandBus with SpanFactory #2402

Open
smcvb opened this issue Sep 27, 2022 · 3 comments
Open

Enable tracing in DisruptorCommandBus with SpanFactory #2402

smcvb opened this issue Sep 27, 2022 · 3 comments
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Type: Feature Use to signal an issue is completely new to the project.

Comments

@smcvb
Copy link
Member

smcvb commented Sep 27, 2022

Feature Description

Axon Framework 4.6.0 has seen the introduction of integrated tracing through issue #2294.
This issue did not cover the DisruptorCommandBus, though.

Current Behaviour

The integrated tracing support is not in place for the DisruptorCommandBus.

Wanted Behaviour

Introduce the SpanFactory in the DisruptorCommandBus to trace it's processes.
@smcvb smcvb added Type: Feature Use to signal an issue is completely new to the project. Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels Sep 27, 2022
@smcvb smcvb added this to the Release 4.7.0 milestone Sep 27, 2022
@smcvb smcvb changed the title Use SpanFactory in DisruptorCommandBus Enable tracing in DisruptorCommandBus with SpanFactory Sep 27, 2022
@CodeDrivenMitch
Copy link
Member

Has been implemented through #2487

@CodeDrivenMitch CodeDrivenMitch added the Status: Resolved Use to signal that work on this issue is done. label Jan 6, 2023
@smcvb
Copy link
Member Author

smcvb commented Jan 6, 2023

This issue was closed accidentally. I will move it to milestone 4.8.0, however, as we do not have sufficient time to resolve this for the upcoming 4.7.0 release.

@smcvb smcvb reopened this Jan 6, 2023
@smcvb smcvb removed the Status: Resolved Use to signal that work on this issue is done. label Jan 6, 2023
@smcvb smcvb modified the milestones: Release 4.7.0, Release 4.8.0 Jan 6, 2023
@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. and removed Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels May 25, 2023
@smcvb
Copy link
Member Author

smcvb commented Jun 12, 2023

We do not envision having sufficient time to work on this before our intended release of 4.8.0.
Added, we aim to direct our attention to the following major release.
Due to this, it is unclear at this stage when the issue will be resolved.

Be sure to reach out if you are facing issues with the above, though!

@smcvb smcvb removed this from the Release 4.8.0 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CodeDrivenMitch @smcvb @YvonneCeelie