Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages published out of order with command handlers sending commands and events #258

Closed
abuijze opened this issue Jan 25, 2017 · 0 comments
Closed

Messages published out of order with command handlers sending commands and events #258

abuijze opened this issue Jan 25, 2017 · 0 comments
Assignees
@abuijze
Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Milestone
Release 3.0.2

Comments

@abuijze
Copy link
Member

abuijze commented Jan 25, 2017

In a scenario where Command Handlers publish events and commands, it is possible that the events published by the inner command are published before the ones of the outer command, even though the sequence numbers on these events does show the correct order.

This only occurs when using a Command Bus that processes commands in the publishing thread (such as SimpleCommandBus) and when Command Handlers publish other Commands directly (so not via Events and Event Handlers or Sagas).
@abuijze abuijze added the Type: Bug Use to signal issues that describe a bug within the system. label Jan 25, 2017
@abuijze abuijze added this to the Release 3.0.2 milestone Jan 25, 2017
abuijze added a commit that referenced this issue Jan 26, 2017
@abuijze
Changed how events are staged for publication in Unit of Work
fed8865 
This new implementation will ensure the correct order of publication even when command handlers send commands and events as part of the same unit of work.

Fixes issue #258
@abuijze abuijze closed this as completed Jan 26, 2017
@smcvb smcvb added Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. labels Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuijze abuijze

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 3.0.2
Development

No branches or pull requests
2 participants
@abuijze @smcvb