Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow easy configuration of CBOR #2776

Closed
CodeDrivenMitch opened this issue Jul 4, 2023 · 0 comments · Fixed by #2777
Closed

Allow easy configuration of CBOR #2776

CodeDrivenMitch opened this issue Jul 4, 2023 · 0 comments · Fixed by #2777
Assignees
@CodeDrivenMitch
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Milestone
Release 4.9.0

Comments

@CodeDrivenMitch
Copy link
Member

Feature Description

CBOR is the Concise Binary Object Representation. It's similar to JSON in structure, but not human readable. Jackson supports this throug the CborMapper. The format reduces message sizes significantly because of the way the data is structured.
This makes it ideal for commands, queries and subscription updates. For events, it will make sense for customers seeking a high-performance throughput because it reduces IO on disk and network.

Current Behaviour

No CBOR is supported out of the box.

Wanted Behaviour

CBOR is supported out of the box. Preferably with its own Spring Boot property.

Possible Workarounds

Configure this yourself.
@CodeDrivenMitch CodeDrivenMitch added the Type: Feature Use to signal an issue is completely new to the project. label Jul 4, 2023
@CodeDrivenMitch CodeDrivenMitch self-assigned this Jul 4, 2023
CodeDrivenMitch added a commit that referenced this issue Jul 4, 2023
@CodeDrivenMitch
Add CBOR format and Spring Boot properties for support
522a04d 
CBOR can now be easily configured from Spring Boot properties. Prerequisite is the existence of the CBORMapper on the classpath.

The messaging tests' TestSerializer has been extended with a CBOR serializer. This means all ParameterizedTest methods for serialization now test CBOR as well.
 I have extended the EventStore integration tests with a CBOR version to make sure it works as well.

 Fixes #2776
@CodeDrivenMitch CodeDrivenMitch mentioned this issue Jul 5, 2023
Merged
@CodeDrivenMitch CodeDrivenMitch changed the title Allow easy configution of CBOR Allow easy configuration of CBOR Jul 5, 2023
@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. labels Jul 6, 2023
@smcvb smcvb added this to the Release 4.9.0 milestone Jul 6, 2023
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.9.0
Development

Successfully merging a pull request may close this issue.

Add CBOR format and Spring Boot properties for support AxonFramework/AxonFramework
2 participants
@CodeDrivenMitch @smcvb