Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lifecycle phase timeout configuration #2037

Merged
merged 1 commit into from Dec 13, 2021
Merged

Allow lifecycle phase timeout configuration #2037

merged 1 commit into from Dec 13, 2021
+92 −12

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Dec 9, 2021

This pull request introduces a means to adjust the lifecycle phase timeout.
This is useful for users that know their start-up and/or shutdown process takes longer than the default of 5 seconds.

Resolves #1981

@smcvb
Allow lifecycle phase timeout configuration
66f7687 
Introduce a means to adjust the lifecycle phase timeout. This is useful
for users that know their start-up and/or shutdown process takes longer
 than the default of 5 seconds.

#1981
@smcvb smcvb added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. labels Dec 9, 2021
@smcvb smcvb added this to the Release 4.6.0 milestone Dec 9, 2021
@smcvb smcvb self-assigned this Dec 9, 2021
@smcvb smcvb mentioned this pull request Dec 9, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

lfgcampos
lfgcampos approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an open question

config/src/main/java/org/axonframework/config/DefaultConfigurer.java Show resolved Hide resolved
@smcvb smcvb merged commit cb1a12b into master Dec 13, 2021
@smcvb smcvb deleted the feature/1981 branch December 13, 2021 12:59
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Dec 13, 2021
@smcvb smcvb modified the milestones: Release 4.6.0, Release 4.5.13 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfgcampos lfgcampos lfgcampos approved these changes

@abuijze abuijze Awaiting requested review from abuijze

@m1l4n54v1c m1l4n54v1c Awaiting requested review from m1l4n54v1c

Assignees

@smcvb smcvb

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Milestone
Release 4.5.13
Development

Successfully merging this pull request may close these issues.

Make the shutdown timeout configurable
2 participants
@smcvb @lfgcampos