Introduce mechanism to interrupt TrackingEventProcessor worker threads
#2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing coverage profile
Add missing coverage profile
Introduce a mechanism to interrupt the worker threads in the TEP on a shutdown . Thus, both the WorkerLauncher and TrackingSegmentWorker. This ensures a TEP with a eventAvailabilityTimeout exceeding the shutdown timeout doesn't unnecessarily block the shutdown process #enhancement/tep-worker-interruption
smcvb
added
Type: Enhancement
Trigger an interrupt() when a thread fails to complete within the configured timeout.
|
SonarCloud Quality Gate failed. |
|
Discussed the implementation locally, ironing out some misses in commit 696d8f5. With that, the review is done. As such, I will merge the pull request. |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjusts the
TrackingEventProcessorto introduce a solution to interrupt worker threads.It does so by adjusting the
WorkerLauncherandTrackingSegmentWorkerRunnableimplementations intoWorkerimplementations.The
Workerinterface, in turn, extendsRunnable, and provides some flexibility to store and identify threads.This change stores every
Threadconstructed by theThreadFactoryin aMap.This map is traversed on the private
awaitTerminationmethod, upon which it invokesjoinfor every thread present.Axon invokes the
joinmethod with a so-calledworkerTerminationTimeout, configurable through theTrackingEventProcessorConfigurationif necessary.Introducing this functionality has the effect that the
TrackingEventProcessorno longer blocks an application shut down when theeventAvailabilityTimeoutexceeds the configured application shut down timeout.That makes this pull request is a follow-up from the discussions in issue #1981.