Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SpanFactory autoconfiguration mechanism. #2354

Merged
merged 5 commits into from Sep 9, 2022
Merged

Improve SpanFactory autoconfiguration mechanism. #2354

merged 5 commits into from Sep 9, 2022

Conversation

CodeDrivenMitch
Copy link
Member

The TracingAutoConfiguration now registers the SpanAttributeProviders, regardless of the implementation.

@CodeDrivenMitch
Improve SpanFactory autoconfiguration mechanism.
18a535d 
The TracingAutoConfiguration now registers the SpanAttributeProviders, regardless of the implementation.
@CodeDrivenMitch CodeDrivenMitch added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: In Progress Use to signal this issue is actively worked on. labels Sep 8, 2022
@CodeDrivenMitch CodeDrivenMitch added this to the Release 4.6.0 milestone Sep 8, 2022
@CodeDrivenMitch CodeDrivenMitch requested a review from a team September 8, 2022 13:35
@CodeDrivenMitch CodeDrivenMitch self-assigned this Sep 8, 2022
@CodeDrivenMitch CodeDrivenMitch requested review from gklijs, smcvb and YvonneCeelie and removed request for a team September 8, 2022 13:35
YvonneCeelie
YvonneCeelie approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@YvonneCeelie YvonneCeelie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

gklijs
gklijs approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

smcvb
smcvb reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why you've added another auto-config class before I approve/request changes.

...g/axonframework/springboot/autoconfig/AxonTracingSpanAttributeProviderAutoConfiguration.java Outdated Show resolved Hide resolved
smcvb
smcvb approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit a382eb9 into master Sep 9, 2022
@smcvb smcvb deleted the feature/tracing-autoconfiguration-change branch September 9, 2022 09:40
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gklijs gklijs gklijs approved these changes

@smcvb smcvb smcvb approved these changes

@YvonneCeelie YvonneCeelie YvonneCeelie approved these changes

Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CodeDrivenMitch @gklijs @smcvb @YvonneCeelie