Fixes the saga list injection bug, issue 2462. #2463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
added
Type: Bug
smcvb
added
the
Status: In Progress
|
Closing this as it was already fixed by 3d89a86 |
gklijs
added
Status: Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2462. This is still a draft, I would like to know if a solution like this would be good before making sure all the tests and documentation are in order. It does fix the problem.
One thing I'm not sure about is that it's partly generic for any kind of collection. We might want to solve it just for
List, although the current implementation would give a clearer error if some other collection is used.