[#2129] Fine tune Repository registration in the AggregateTestFixture
#2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure the registered Repository is part of the fixture's resources In doing so, users can wire the Repository within the classes being tested like they would in a regular system. - Throw a FixtureExecutionException whenever certain registration methods are invoked that would impact the constructed outcome of a Repository. Do this both when a Repository is consciously registered and when it is retrieved. The former should force the users to register those components earlier *and* on the Repository directly. The latter is to guard the user against assuming a wrong format of the Repository. #2129
- Replace AxonConfigurationException for FixtureExecutionException - Adjust indentation #2129
smcvb
added
Priority 4: Would
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
abuijze
approved these changes
Jan 16, 2023
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjusts two pointers around the
AggregateTestFixture'sRepositoryusage:Repositoryis added to theresourcescollection of the fixture. By adding it to the resources, users are able to wire theRepositoryinside the aggregate or registered annotated command handling components. Since the framework already does this in a production environment, this adjustment allows the fixture to more closely align with the a production setup,FixtureExecutionExceptionis thrown when aRepositoryProvider,ParameterResolverFactory,HandlerDefinitionorHandlerEnhancerDefinitionis registered while theRepositoryis already defined for the fixture. Since all four of these components impact theRepositorywithin the fixture, none of these operation should be allowed once theRepositoryis already retrieved (throughAggregateTestFixture#getRepository, as this builds the defaultRepository) or when a custom version is registered (throughAggregateTestFixture#registerRepository).By doing the above, the pull request resolves #2129.