Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2581 Allow to override EventSchema without modifying default JdbcEve… #2582

Merged
merged 3 commits into from Feb 8, 2023
Merged

#2581 Allow to override EventSchema without modifying default JdbcEve… #2582

merged 3 commits into from Feb 8, 2023

Conversation

Blackdread
Copy link
Contributor

Fixes #2581

@smcvb

@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. Type: Feature Use to signal an issue is completely new to the project. labels Feb 2, 2023
@smcvb smcvb requested review from a team, gklijs, CodeDrivenMitch and smcvb and removed request for a team February 2, 2023 10:49
@smcvb smcvb added this to the Release 4.8.0 milestone Feb 2, 2023
@Blackdread
Copy link
Contributor Author

@smcvb I think this is good for merge

smcvb
smcvb approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence I'm approving this pull request.

@smcvb smcvb merged commit 4f7a20c into AxonFramework:master Feb 8, 2023
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs gklijs was automatically assigned from AxonFramework/framework-developers

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch CodeDrivenMitch was automatically assigned from AxonFramework/framework-developers

Assignees

@Blackdread Blackdread

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.8.0
Development

Successfully merging this pull request may close these issues.

Allow to override EventSchema without modifying default JdbcEventStorageEngine in Spring context
2 participants
@Blackdread @smcvb