[#2639] Handler Interceptor support for Dead Letter Processing #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
added
Type: Feature
gklijs
force-pushed
the
invoke_interceptoers_when_processing_dlq
branch
from
072f255
to
7f08372
Compare
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
changed the title
smcvb
requested changes
Apr 13, 2023
There was a problem hiding this comment.
I think we need to move the interceptor invocation from the DeadLetteringEventHandlerInvoker to the DeadLetteredEventProcessingTask.
In the invoker, we deal with regular event handling, while the processing task is when we handle a dead letter.
Thus, the former is already covered by MessageHandlerInterceptors, through the Event Processor the invoker's a part of.
gklijs
force-pushed
the
invoke_interceptoers_when_processing_dlq
branch
2 times, most recently
from
3cbeeac
to
5a506bc
Compare
gklijs
force-pushed
the
invoke_interceptoers_when_processing_dlq
branch
from
5a506bc
to
4416c44
Compare
|
The pr was adjusted and can be reviewed again. |
smcvb
approved these changes
Apr 24, 2023
...rc/main/java/org/axonframework/eventhandling/deadletter/DeadLetteredEventProcessingTask.java
Outdated
Show resolved
Hide resolved
.../test/java/org/axonframework/eventhandling/deadletter/DeadLetteringEventIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/axonframework/eventhandling/deadletter/DeadLetteredEventProcessingTaskTest.java
Show resolved
Hide resolved
.../test/java/org/axonframework/eventhandling/deadletter/DeadLetteringEventIntegrationTest.java
Show resolved
Hide resolved
…tter/DeadLetteringEventIntegrationTest.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…o the unit of work.
…ptor was called at all.
|
Kudos, SonarCloud Quality Gate passed! |
gklijs
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handler Interceptor support for Dead Letter Processing, using the same interceptors as the processing group.
Fixes #2639