Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Configuration accessible #2700

Merged
merged 1 commit into from May 8, 2023
Merged

Make Configuration accessible #2700

merged 1 commit into from May 8, 2023

Conversation

schananas
Copy link
Contributor

Make Configuration protected, so it's accessible by other components that extend EventProcessingModule.
Change needed for multi tenancy extension

@schananas schananas added this to the Release 4.6.8 milestone May 4, 2023
@schananas schananas requested review from gklijs and smcvb May 4, 2023 10:16
@schananas schananas self-assigned this May 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CodeDrivenMitch CodeDrivenMitch self-requested a review May 4, 2023 13:45
CodeDrivenMitch
CodeDrivenMitch approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks valid to me. I think we should open up most of the EPM as protected, so it can be modified and extended by people.

@smcvb smcvb added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. labels May 8, 2023
@smcvb smcvb modified the milestones: Release 4.6.8, Release 4.8.0 May 8, 2023
smcvb
smcvb approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@schananas schananas merged commit 04797b2 into master May 8, 2023
8 of 11 checks passed
@schananas schananas deleted the feature/custom-tenant-source branch May 8, 2023 10:40
@schananas schananas added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeDrivenMitch CodeDrivenMitch CodeDrivenMitch approved these changes

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs

Assignees

@schananas schananas

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Milestone
Release 4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schananas @CodeDrivenMitch @smcvb