Enable tracing in DistributedCommandBus with SpanFactory #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
added
Type: Feature
CodeDrivenMitch
requested changes
May 26, 2023
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Outdated
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Outdated
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Outdated
Show resolved
Hide resolved
smcvb
requested changes
May 26, 2023
There was a problem hiding this comment.
Couple of comments do resolve before we proceed.
Furthermore, it is good to point out this resolves the sending side for tracing, but not the handling end. For setting the handle span, we need to adjust the CommandBusConnector for the Spring Cloud and JGroups extension. Not necessarily a task you should do ASAP, but we shouldn't forget, of course!
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Show resolved
Hide resolved
...g/src/test/java/org/axonframework/commandhandling/distributed/DistributedCommandBusTest.java
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Show resolved
Hide resolved
...aging/src/main/java/org/axonframework/commandhandling/distributed/DistributedCommandBus.java
Outdated
Show resolved
Hide resolved
…sing the spanfactory to propagate the context.
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
approved these changes
May 31, 2023
gklijs
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2403
I think all the needed tracing is there, but I'm unsure.