Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-summary step #2745

Merged
merged 10 commits into from Jun 14, 2023
Merged

Add test-summary step #2745

merged 10 commits into from Jun 14, 2023

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Jun 12, 2023

This PR adds the test-summary step for pull requests.

In doing so, this PR resolves #2228.

Add anchore container scan step. Keep this step for a little while to
investigate whether it provides worthy information for Axon Framework

#1828
Add test-summary step. Keep this step for a little while to
investigate whether it provides worthy information for Axon Framework

#2228
@smcvb smcvb added Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Type: Feature Use to signal an issue is completely new to the project. Status: In Progress Use to signal this issue is actively worked on. labels Jun 12, 2023
@smcvb smcvb added this to the Release 4.8.0 milestone Jun 12, 2023
@smcvb smcvb requested a review from a team June 12, 2023 14:45
@smcvb smcvb self-assigned this Jun 12, 2023
@smcvb smcvb requested review from gklijs and CodeDrivenMitch and removed request for a team June 12, 2023 14:45
Set output to "-" to print it

#2228
Add blunt job summary writing step for potential use with test-summary

#2228
Remove output:"-" to drop output logging

#2228
Showing all results is apparently a little to much...

#2228
@smcvb smcvb changed the base branch from feature/1828-anchore-container-scanner to master June 13, 2023 13:04
Remove anchore container scan step

#2228
Remove test writing to github summary

#2228
Remove unused comment

#2228
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
3.0% 3.0% Duplication

Rename step, as test summary seems like a fine addition

#2228
Copy link
Member

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me

@smcvb smcvb merged commit 2150ec9 into master Jun 14, 2023
5 of 6 checks passed
@smcvb smcvb deleted the feature/2228-test-summary branch June 14, 2023 11:47
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate test-summary GitHub Action
2 participants