Synchronize during Event Processor initialization #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove processor initialization from eventProcessors(), as it's fine for the processors to be initialized as part of the lifecycle handlers. Furthermore, we should clarify that a buildConfiguration() does not mean everything is present due to said lifecycle handlers. Furthermore, wherever tests expect a buildConfiguration() to lead to existing EventProcessor should change their behavior to start the Configurer instead. #2751
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
smcvb
changed the title
EventProcessingConfigurion#eventProcessors()Use AtomicBoolean instead of an Object #2751
abuijze
approved these changes
Jun 16, 2023
config/src/main/java/org/axonframework/config/EventProcessingModule.java
Outdated
Show resolved
Hide resolved
Move initialized boolean and make private #2751
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure no two (or more) threads can simultaneously initiate Event Processors in the
EventProcessingModule, add asynchronizearound the initialization.To make the call slightly more efficient, first check if there are not event processor, then enter the synchronize-block, and then check for an empty event processors collection again.
In doing the above, this pull request resolves #2751.