Fix property-based Load Balancing Strategy configuration bug #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Spring resolved the name for the properties based on the ConfigurationProperties annotation on the getter, it is unable to set the properties in this format. To keep the property path name that's already propagated throughout our user base, I've opted to rename the EventProcessorConfiguration to Eventhandling, to align with the path "axon.axonserver.eventhandling". Although we should strictly regard this as a breaking change, I think the chances are minimal somebody is directly interacting with the object i.o. through property files. #bug/load-balancing-strategy-in-property-file
Rename shouldAutomaticallyBalance to isAutomaticBalancing to align with the field name. Without doing so, the property can be auto-completed in an IDE, but is regarded as unresolved for documentation. #bug/load-balancing-strategy-in-property-file
Add load balancing property test case #bug/load-balancing-strategy-in-property-file
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Spring resolved the name for the load balancing properties based on the
@ConfigurationPropertiesannotation on the getter of theAxonServerConfiguration.EventHandlingConfiguration, it was unable to set the properties in this format.I assume this has to do with the discrepancy between the defined property and the field and its getter/setter.
To keep the property path name that's already propagated throughout our user base, I've opted to rename the
AxonServerConfigurationEventProcessorConfigurationtoAxonServerConfigurationEventhandling. By doing so, we align with the path"axon.axonserver.eventhandling"`.Although we should strictly regard this as a breaking change, I think the chances are minimal somebody interacts with the object, i.o. through a property file.
Next to this, I have renamed the method returning the field
automaticBalancingfromshouldAutomaticallyBalancetoisAutomaticBalancing.Although this time, the IDE did resolve the
axon.axonserver.eventhandling.processors.[processor-name].automatic-balancingproperty, it did complain that it could not resolve it.After adjusting the getter to align with the property name, the IDE no longer complained.
Similarly, as with the class rename, we should regard this as a breaking change.
But, again, similarly, I do not anticipate users to interact directly with this operation and instead use the property files.