Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Axon Server connector configuration to the AxonServerConfiguration #2815

Merged
merged 4 commits into from Aug 25, 2023

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Aug 25, 2023

This pull request adds three configurable options of the axonserver-connector-java that weren't exposed to the AxonServerConfiguration yet.
Namely:

  1. Reconnect interval - the interval in ms when to attempt a reconnect to the configured servers. Defaults to 2000ms.
  2. Force reconnect through servers - boolean whether to enforce a reconnect through the configured servers, yes/no. When false, a reconnect is first attempted over the connection that just failed. Defaults to true
  3. Connection management thread pool size - the number of threads used by the AxonServerConnectionFactory (connector-specific component) for connection management, instruction stream construction, and heartbeats. Defaults to 2.

Add and use reconnectInterval property. This defines the interval in
milliseconds between reconnect attempts to the configured servers. This
property is provided by the axonserver-connector-java project for some
time, but went unprovided from within AF since it's introduction.

#feature/add-additional-connector-configuration
Add and use forceReconnectThroughServers property. This
setting defines whether a reconnect will (when false) first try to
reconnect with the connection it lost or (when true) request the known
servers what the next best connection should be.

#feature/add-additional-connector-configuration
Add and use connectionManagementThreadPoolSize property. This
setting defines the amount of threads used by the connection factory for
 managing connection, setting up streams, and heartbeats.

#feature/add-additional-connector-configuration
Add test for reconnect properties

#feature/add-additional-connector-configuration
@smcvb smcvb added Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Type: Feature Use to signal an issue is completely new to the project. Status: In Progress Use to signal this issue is actively worked on. labels Aug 25, 2023
@smcvb smcvb added this to the Release 4.9.0 milestone Aug 25, 2023
@smcvb smcvb requested a review from a team August 25, 2023 12:06
@smcvb smcvb self-assigned this Aug 25, 2023
@smcvb smcvb requested review from gklijs and CodeDrivenMitch and removed request for a team August 25, 2023 12:06
Copy link
Contributor

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, and I learned a thing or two from the Javadoc.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@smcvb smcvb merged commit 29cb4be into master Aug 25, 2023
8 of 11 checks passed
@smcvb smcvb deleted the feature/add-additional-connector-configuration branch August 25, 2023 12:29
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants