Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve classloading issue with ConnectionDetails #2833

Merged
merged 1 commit into from Sep 12, 2023
Merged

Resolve classloading issue with ConnectionDetails #2833

merged 1 commit into from Sep 12, 2023

Conversation

abuijze
Copy link
Member

@abuijze abuijze commented Sep 12, 2023

The configuration file would complain about not being able to inspect the AxonServerConnectionDetails class, as it implements the ConnectionDetails interface. This commit separates the beans into nested configuration files with proper Classpath conditions to ensure only compatible beans are considered.

@abuijze
Resolve classloading issue with ConnectionDetails
8a4b76e 
The configuration file would complain about not being able to inspect the AxonServerConnectionDetails class, as it implements the ConnectionDetails interface. This commit separates the beans into nested configuration files with proper Classpath conditions to ensure only compatible beans are considered.
@abuijze abuijze added the Type: Bug Use to signal issues that describe a bug within the system. label Sep 12, 2023
@abuijze abuijze requested a review from smcvb September 12, 2023 10:33
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@smcvb smcvb added Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: In Progress Use to signal this issue is actively worked on. labels Sep 12, 2023
@smcvb smcvb added this to the Release 4.9.0 milestone Sep 12, 2023
smcvb
smcvb approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit 380a25c into master Sep 12, 2023
6 of 11 checks passed
@smcvb smcvb deleted the feature/spring-docker-compose branch September 12, 2023 11:49
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

Assignees

@abuijze abuijze

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abuijze @smcvb