[#2843] Make it possible to have multiple instances of the DbScheduler components. #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
added
Type: Enhancement
…`DbSchedulerDeadlineManager` to take a supplier, in favour of using a static atomic reference. This makes it possible to use multiple of the same kind of component with scheduler.
gklijs
changed the title
smcvb
changed the title
smcvb
reviewed
Sep 29, 2023
messaging/src/main/java/org/axonframework/deadline/dbscheduler/DbSchedulerDeadlineManager.java
Outdated
Show resolved
Hide resolved
messaging/src/main/java/org/axonframework/deadline/dbscheduler/DbSchedulerDeadlineManager.java
Outdated
Show resolved
Hide resolved
messaging/src/main/java/org/axonframework/deadline/dbscheduler/DbSchedulerDeadlineManager.java
Show resolved
Hide resolved
...in/java/org/axonframework/deadline/dbscheduler/SimpleDbSchedulerDeadlineManagerSupplier.java
Outdated
Show resolved
Hide resolved
...n/java/org/axonframework/eventhandling/scheduling/dbscheduler/DbSchedulerEventScheduler.java
Outdated
Show resolved
Hide resolved
...n/java/org/axonframework/eventhandling/scheduling/dbscheduler/DbSchedulerEventScheduler.java
Outdated
Show resolved
Hide resolved
...n/java/org/axonframework/eventhandling/scheduling/dbscheduler/DbSchedulerEventScheduler.java
Show resolved
Hide resolved
...nframework/eventhandling/scheduling/dbscheduler/SimpleDbSchedulerEventSchedulerSupplier.java
Outdated
Show resolved
Hide resolved
...nframework/eventhandling/scheduling/dbscheduler/SimpleDbSchedulerEventSchedulerSupplier.java
Outdated
Show resolved
Hide resolved
…/DbSchedulerDeadlineManager.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…/DbSchedulerDeadlineManager.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…ling/dbscheduler/DbSchedulerEventScheduler.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…ling/dbscheduler/DbSchedulerEventScheduler.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
It serves two purposes. It makes it easier to test them without Spring (although we could have used a similar class only in test). It also makes it easier to use them in non-Spring contexts. |
|
SonarCloud Quality Gate failed.
|
smcvb
approved these changes
Oct 2, 2023
gklijs
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the static methods on the
DbSchedulerEventSchedulerand theDbSchedulerDeadlineManagerto take a supplier, in favour of using a static atomic reference. This makes it possible to use multiple of the same kind of component with scheduler.Note this will be a breaking change, but only when either used without spring boot, or with customizations. As the break is clear (the methods now need an argument), the components were introduced just in 4.8.0, and the benefits are plenty, I think this should be fine.
Fixes #2843