Use TransactionManager in the EventProcessorControlService to invoke TokenStore#retrieveStorageIdentifier
#2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use TransactionManager to fetch storage identifier. Without wrapping the TokenStore#retrieveStorageIdentifier task in a transaction, some databases will complain and not allow load balancing to occur at all through the properties. #bug/add-transaction-manager
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
gklijs
approved these changes
Feb 22, 2024
|
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds usage of the
TransactionManagerto theTokenStore#retrieveStorageIdentifieroperation in theEventProcessorControlService.Without wrapping this task in a transaction, some databases will throw exceptions.
Thus, for users of databases with this requirement, load balancing simply doesn't occur at all through the load balancing strategy properties.