-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/axon kotlin test #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name should be changed to indicate that these are test utilities and differentiate from the regular extension methods. Appending .test
to the package should be enough, as there's no need to split aggregate and saga utilities for now.
We can always segregate it in the future if there's the need for it.
Otherwise, looks good to me 👍
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
After trying this code locally for my project, I had trouble using the defined functions. I am still very new to Kotlin, therefore I might be missing something.
Nonetheless, here are some comments on how I would refactor this code. Please tell me if I am on the wrong path.
Will fix #67