Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture factories can be used as factory methods #93

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Fixture factories can be used as factory methods #93

merged 3 commits into from
Dec 17, 2020

Conversation

Arnaud-J
Copy link

@Arnaud-J Arnaud-J commented Dec 15, 2020 •
edited by smcvb

This PR resolves #92

🐛 Fixture factories can be used as factory methods
1945e52 
✅ Add tests to show their usage
This was referenced Dec 15, 2020
Closed
Merged
🐛 Use whenever() extension after given()
59d02aa 
✅ Add tests to show usage
@sandjelkovic sandjelkovic added this to the Release 0.2.0 milestone Dec 15, 2020
@Arnaud-J
Copy link
Author

@sandjelkovic following up on your comment (#73 (comment)), I changed the whenever() extension to be on the TestExecutor class, with usage tests to show it would work both on TestExecutor and AggregateTestFixture.

I don't see any when method for working with SagaTestFixture, hence no whenever() extension is needed.

smcvb
smcvb requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of nits which I'd like to cover prior to approving this PR. And importantly, thanks for the effort here @Arnaud-J!

kotlin-test/src/test/kotlin/org/axonframework/extension/kotlin/test/FixtureExtensionsTest.kt Outdated Show resolved Hide resolved
kotlin-test/src/test/kotlin/org/axonframework/extension/kotlin/test/FixtureExtensionsTest.kt Outdated Show resolved Hide resolved
kotlin-test/src/test/kotlin/org/axonframework/extension/kotlin/test/FixtureExtensionsTest.kt Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit 9d1bb59 into AxonFramework:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@sandjelkovic sandjelkovic Awaiting requested review from sandjelkovic

Assignees

@Arnaud-J Arnaud-J

Labels
Priority 1: Must Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.

Fixture factories can not be used as factory methods
3 participants
@Arnaud-J @smcvb @sandjelkovic