GitHub Action introduction for Build and Test #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an github action to test and build this project. This should replace the TravisCI solution completely
Wrap parameters in quotes to check whether that resolves the build issue
The sonar token cannot be part of a matrix with using GHA. Hence add another step with checks whether the matrix.sonar value is true/false and decide whether to run with/without sonar based on that
The "C" of a channel id should be included, eventhough it's a prefix for Slack's channel id's
The if-statments for building with/without sonar were reverted. Switch that around
If-statements should cope with true/false, so don't equals the strings. Added, rename field to sonar-enabled, for clarity
Replace true/false values for 1/0, as apparently GHA cant cope with !true
|
Kudos, SonarCloud Quality Gate passed!
|
Run script for pushes to master and pull requests. Additionally, fix the name of the job to include the java version again
Let's hope this syntax is what GHA is looking for
Use latest version of slack-notify, which is v1.1.2
abuijze
approved these changes
Dec 18, 2020
Shorten name to better visualize it on a GitHub page
- Put the sonar parameters on new lines to increase readability - Add badges to the readme to clarify the status of the project
Add missing backslashes to allow mcv to be pasted over several lines
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a GitHub Action (GHA) to test and build this project, as based on GitHub's Building and Testing with Maven page.
It will perform a run based on JDK 8 and JDK 11.
Only the JDK11 build (should) runs Sonar as well.
Lastly, the results (should be / are) published to AxonIQ's Slack channel, for clarity.
To notify to Slack, the Slack Notify Build action was added.
The tokens used in this script originate from the organization level of this project.
Furthermore, no dedicated Sonar Action was introduced because of the following statement on the Sonar Action's README:
This solution will replace the current TravisCI approach entirely. As such, this pull request drops the old
.travis.ymlfile.