Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBbports patches #26

Merged
merged 10 commits into from
Aug 12, 2021
Merged

Conversation

tari01
Copy link
Member

@tari01 tari01 commented Aug 12, 2021

No description provided.

@tari01 tari01 requested a review from sunweaver August 12, 2021 00:09
Dan Chapman and others added 9 commits August 12, 2021 02:25
the icon in notifications is now a bluetooth specific one if audio is over a bt device
icons used were from another theme, this switches out to available suru icons
A couple of things in the integration-test rely on having a HOME
directory. Provide a temporary HOME for the test and its child, which
both prevents polluting the building user's HOME and allow the test to
run where HOME=/nonexistent (i.e. autobuilder).

Also remove the exception not to run the integration test inside the
(Canonical's) Jenkins, as it's not relevant anymore.
This attempt to fix the microphone icon in the sound indicator doesn't
fix the problem and breaks the test. I decided to revert it so that
when the correct fix is in place (which is outside the indicator), it'll
work as intended.

This reverts commit d73cef63a75cb313842436266f5158de6ac3fe07, reversing
changes made to 9dd32c3ac9392a5412d8274cb198e0d6687e982c.
Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That looks easier than the other UBPorts patches PRs.

As one of the commits seems to fix a unit test, can we re-enable some of the tests now? Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants