-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBbports patches #26
Merged
sunweaver
merged 10 commits into
AyatanaIndicators:master
from
tari01:pr/ubports-patches
Aug 12, 2021
Merged
UBbports patches #26
sunweaver
merged 10 commits into
AyatanaIndicators:master
from
tari01:pr/ubports-patches
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the icon in notifications is now a bluetooth specific one if audio is over a bt device
icons used were from another theme, this switches out to available suru icons
A couple of things in the integration-test rely on having a HOME directory. Provide a temporary HOME for the test and its child, which both prevents polluting the building user's HOME and allow the test to run where HOME=/nonexistent (i.e. autobuilder). Also remove the exception not to run the integration test inside the (Canonical's) Jenkins, as it's not relevant anymore.
This attempt to fix the microphone icon in the sound indicator doesn't fix the problem and breaks the test. I decided to revert it so that when the correct fix is in place (which is outside the indicator), it'll work as intended. This reverts commit d73cef63a75cb313842436266f5158de6ac3fe07, reversing changes made to 9dd32c3ac9392a5412d8274cb198e0d6687e982c.
9ad38f9
to
81e181c
Compare
sunweaver
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That looks easier than the other UBPorts patches PRs.
As one of the commits seems to fix a unit test, can we re-enable some of the tests now? Please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.