Collapsible directories #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyushG3112
reviewed
Sep 10, 2022
| directorySection.classList.toggle("collapsed"); | ||
| } | ||
| } | ||
| </script> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
Needs a newline at the end of the file
| @@ -6,25 +6,80 @@ | |||
|
|
|||
| <body> | |||
| <style> | |||
| .hide-element { | |||
There was a problem hiding this comment.
This class isn't being used anywhere from what I can see, can we remove this?
| <script> | ||
| const directories = document.getElementsByClassName("directory-header"); | ||
| for (let i = 0; i < directories.length; i++) { | ||
| directories[i].onclick = (e) => { |
There was a problem hiding this comment.
use addEventListener instead of onclick = directly.
| <script> | ||
| const directories = document.getElementsByClassName("directory-header"); | ||
| for (let i = 0; i < directories.length; i++) { | ||
| directories[i].onclick = (e) => { |
There was a problem hiding this comment.
Since the function is stateless, can we define this only one instead of defining it once for every directory?
| margin-top: 0.5em; | ||
| margin-left: 3px; | ||
| display: flex; | ||
| align-items: center; | ||
|
|
| <div style="margin-left: 1%;"> | ||
| {{ template "singlepagesection" .Children }} | ||
| </div> | ||
| <div class="directory-tree collapsed"> |
There was a problem hiding this comment.
@charan1973 can you also fix the indentation in this section please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.