Heightmap from image conversion will not display a political map

[RMBLRX]

Description

I cannot see a political map overlay when starting with a heightmap obtained by image conversion.

Generator version

0.56b

Browser version

Google Chrome Version 66.0.3359.181 (Official Build) (64-bit)

Steps to reproduce

1. Start with a freshly randomized map and all defaults unaltered from here: https://azgaar.github.io/Fantasy-Map-Generator/
2. Go to customize tab.
3. Click Heightmap.
4. Click Edit.
5. Click Clean up in the pop-up dialog.
6. Click image converter.
7. Upload heightmap.
8. Auto-assign colors.
9. Complete conversion.
10. Ensure Political Map preset is selected (it should be selected by default).
11. Go back to the customize tab and select Countries.
12. Click the trashcan to Remove all countries (everything is unresponsive here unless you do this; notice neutrals fills in by default but contains 0 cells and 0 area for some reason).
13. Click proclaim a new country and select a capital (notice that the capital column on that row does not fill in after selecting a capital's location and remains as a select button instead).
14. Click the paintbrush to manually re-assign countries and select your newly created country.
15. Drag the paintbrush along some land area and click the checkbox to apply assignment (notice the cells and area columns fill in with their associated quantities, and the country's name label appears on the map, but no actual country overlay appears with only the heightmap visible, even in the political preset; notice also that the capital only appears in the capital column after this step).

.map file

https://ipfs.io/ipfs/QmYMat9Qp377z5xiMTWoLStoVyEZQDWZgnNQNx1Rjgj8of

Expected behaviour

Neutral areas should cover the whole landmass by default, and proclaimed countries should appear after being assigned, and all of this should appear under the default political map preset without the heightmap being visible.

Actual behaviour

The heightmap remains visible in any preset with default settings, and the political map remains invisible apart from labels.

[Azgaar]

Hi @RMBLRX,

Thanks for the report, I will take a look.

Regards,
Azgaar

[Azgaar]

Hi @RMBLRX,

Sorry for this, but it's not a but, more like the misunderstanding.

When you convert an image into a heightmap, the Heightmap Editor mode is still activated. It allows you to manually fine-tune the uploaded heightmap. Then you must click on "Complete" prior to any actions with countries. This will close the Heightmap Editor mode and will generate default random countries and other data. Now you will be able to edit the Countries, remove all of them and so on.

I know it's not obvious, I'm going to add a hint line explaining the required actions.

Regards,
Azgaar

[Azgaar]

I've changed the UI a bit, no the required actions should be more obvious. Please check

[RMBLRX]

I'm not really seeing any difference. I clicked complete as stated in step 9 for reproducing the issue (the checkbox with the complete conversion tooltip). Is there some other complete button that I'm not seeing? Are you able to load the map that I linked and make the political overlay visible?

[RMBLRX]

Ah, it's not in the image conversion pop-up but near the edit button under the customize heightmap options. I see it now.

[Azgaar]

Great. I will continue working on UI to make things more obvious

[RMBLRX]

Yeah, it actually works pretty slick once I figured out what to do. I have to wonder whether a little window with the complete button in it, kind of like the tool-tray windows, might suffice.

[Azgaar]

Not sure I understand. A window with complete button like the one in "Customize" tab?

[RMBLRX]

Yeah, like the window for the terrain painting tools or the image conversion tools. Maybe have one for the heightmap customization options that sticks around until you hit complete. I just think that would be harder to miss.

[Azgaar]

Hm, let me start from the visible tooltip