Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.map can't get loaded from gist #840

Closed
TazztheMonster opened this issue Jun 22, 2022 · 2 comments
Closed

.map can't get loaded from gist #840

TazztheMonster opened this issue Jun 22, 2022 · 2 comments
Assignees

Comments

@TazztheMonster
Copy link

Describe the bug
If I try to load a map from an URL, exactly from an gist, I just get an "Ivalid file" error.

Steps to reproduce

  1. Click on "Save"
  2. Click on "machine"
  3. Go to "https://gist.github.com/"
  4. Upload saved file from step 2
  5. Copy raw link from uploaded file
  6. Open azgaar again
  7. Click on "Load"
  8. Click on "URL"
  9. Paste link to gist file
  10. Click on "Load"

Expected behavior
The map should get loadet.

.map file
https://gist.githubusercontent.com/TazztheMonster/3a8af87f933f21c290f8633872f50f09/raw/bac7435627faee3b35ca94669ecac1a48b080374/Ailealand%25202022-06-22-16-54.map
Ailealand 2022-06-22-16-54.zip

Screenshots
image

System

  • Version: 1.86.10
  • Browser: Google Chrome (Version 102.0.5005.115 64-Bit)
  • OS: Windows 11
@Azgaar
Copy link
Owner

Azgaar commented Jun 22, 2022

Gist removes new line chars we use as delimiter. const mapData = decoded.split("\r\n");, so map data is detected incorrectly. In the future (but probably not now) I would like to change delimiters to something more robust

@Azgaar
Copy link
Owner

Azgaar commented Jun 29, 2022

Closing, tracked in Trello as a major refactoring item

@Azgaar Azgaar closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants