chore: Enforce bracing around blocks. Generally considered easier to read and less error prone.

[charlielye]

As title.

yarn formatting:fix now runs eslint with fix enabled first, allowing auto fixing of these kinds of issues.

Calling out to ChatGPT as my curly supporting hype-man:

1. Readability: Curly braces make the structure of the code clearer, especially in complex codebases. It's easier to identify the start and end of control blocks.
2. Maintainability: When modifying code, clear block delimiters reduce the chance of introducing errors. For example, if you need to add a new statement to an if block that was initially written without braces, the absence of braces might lead to logical errors.
3. Error Reduction: One of the famous bugs related to the absence of curly braces is Apple's "goto fail;" bug. Such bugs occur when the intended block scope is not properly defined, leading to unexpected behavior.
4. Consistency: Enforcing a consistent style, like always using braces, can make the code more uniform and easier to understand for all team members.

[ludamad]

Not controversial to me

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (10): 235 (+62%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6307e129 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,948	868,208	3,449,720
l1_rollup_execution_gas	842,035	3,595,316	22,205,089
l2_block_processing_time_in_ms	2,010 (-8%)	7,709	30,803 (+2%)
note_successful_decrypting_time_in_ms	292	867 (-3%)	3,243 (+2%)
note_trial_decrypting_time_in_ms	100 (+6%)	74.0 (-26%)	134
l2_block_building_time_in_ms	20,579	81,728	325,854 (-1%)
l2_block_rollup_simulation_time_in_ms	11,950	47,485 (-1%)	188,865 (-1%)
l2_block_public_tx_process_time_in_ms	8,588	34,114	136,508 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	22,039	43,030
note_history_successful_decrypting_time_in_ms	2,073 (-2%)	4,085 (-1%)
note_history_trial_decrypting_time_in_ms	121	⚠️ 235 (+62%)
node_database_size_in_bytes	1,630,833	1,098,462
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	762	61,697	18,905
private-kernel-ordering	126	24,297	8,153
base-rollup	1,771	656,428	873
root-rollup	169	4,072	1,097
private-kernel-inner	785	81,568	18,905
public-kernel-private-input	566	41,519	18,905
public-kernel-non-first-iteration	405	41,561	18,905
merge-rollup	15.2	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547