chore: Fix circulars in foundation. Also cleanup fields and optimise to be buffer underlying.

[charlielye]

• Fixes circulars imports in foundation so formatting no longer warns.
• Address some circular imports in acir-simulator.
• Reworks field classes Fr, Fq and GrumpkinScalar.
• There is a BaseField class capturing common instance code.
• There are free functions capturing common static construction code.
• Fr and Fq are implemented in terms of BaseField and free functions.
• Fq supports construction and output of hi/lo Fr's.
• GrumpkinScalar is aliased to just be an Fq.
• AztecAddress is now just an extension of Fr that enforces 32 byte buffer input.
• I meddled with ZERO and zero() a bit so there are some changes around this that are noops.
• Disables guides-up-quick-start as failing since CI fix.
• JSON-RPC class converter now checks full prototype chain for methods.

[ludamad]

Lgtm

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (10): 242 (+67%)
• note_trial_decrypting_time_in_ms (8): 4.05 (-96%)
• note_trial_decrypting_time_in_ms (32): 18.5 (-81%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6307e129 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,924	868,268	3,449,528
l1_rollup_execution_gas	842,011	3,595,376	22,204,897
l2_block_processing_time_in_ms	2,072 (-5%)	7,826 (+1%)	30,355 (+1%)
note_successful_decrypting_time_in_ms	298 (+2%)	907 (+2%)	3,211 (+1%)
note_trial_decrypting_time_in_ms	⚠️ 4.05 (-96%)	⚠️ 18.5 (-81%)	141 (+5%)
l2_block_building_time_in_ms	20,724 (+1%)	82,547 (+1%)	329,440 (+1%)
l2_block_rollup_simulation_time_in_ms	12,048 (+1%)	47,904	190,642
l2_block_public_tx_process_time_in_ms	8,632 (+1%)	34,496 (+1%)	138,270 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,996	42,446 (-2%)
note_history_successful_decrypting_time_in_ms	2,042 (-3%)	3,974 (-4%)
note_history_trial_decrypting_time_in_ms	127 (+5%)	⚠️ 242 (+67%)
node_database_size_in_bytes	1,632,041	1,101,551
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	769 (+1%)	61,697	18,905
private-kernel-ordering	127 (+1%)	24,297	8,153
base-rollup	1,759	656,428	873
root-rollup	169	4,072	1,097
private-kernel-inner	793 (+1%)	81,568	18,905
public-kernel-private-input	571 (+1%)	41,519	18,905
public-kernel-non-first-iteration	410 (+1%)	41,561	18,905
merge-rollup	15.5 (+2%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547