feat: Slow updates experimentation #2732

LHerskind · 2023-10-06T17:18:23Z

Fixes #2801. (Also fixes #3214)

Experimentation with slow updates in Noir.

Adds a slow update structure
- Sparse tree to support membership and non-memberships
Wraps this structure in a contract to make interaction easier
Adds an oracle to make it practical to pass the >200 params.
Implement token contract with blacklist and access control in the slow tree.

From #2878:
For the experimentation here needed a name for my "data-stack" as it could practically hold whatever you want to throw at it. Was listening to https://www.youtube.com/watch?v=DTrNwbemNK0 while building so its the pez dispenser. The PEZ dispenser is essentially a stack managed by the PXE that hold mints (PEZ Dispenser = "PfeffErminZ"/peppermint dispenser). A mint is Fr[] which can hold whatever data really, here just used to feed membership proofs and update proofs into the slow updates map.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2023-10-13T16:08:33Z

Benchmark results

Metrics with a significant change:

note_history_trial_decrypting_time_in_ms (10): 201 (+29%)
note_trial_decrypting_time_in_ms (8): 8.59 (-91%)
note_trial_decrypting_time_in_ms (32): 13.4 (-85%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 0dc2d586 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,948	867,764	3,448,040
l1_rollup_execution_gas	842,035	3,594,872	22,203,409
l2_block_processing_time_in_ms	2,038 (+2%)	7,743 (+2%)	30,349 (+2%)
note_successful_decrypting_time_in_ms	304 (+2%)	901 (+3%)	3,277 (+3%)
note_trial_decrypting_time_in_ms	⚠️ 8.59 (-91%)	⚠️ 13.4 (-85%)	141 (-1%)
l2_block_building_time_in_ms	20,857	82,595 (+1%)	329,335 (+1%)
l2_block_rollup_simulation_time_in_ms	12,142	47,905 (+1%)	190,424 (+1%)
l2_block_public_tx_process_time_in_ms	8,671	34,546	138,375 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,978	42,976 (+1%)
note_history_successful_decrypting_time_in_ms	2,086 (+3%)	4,125 (+4%)
note_history_trial_decrypting_time_in_ms	126	⚠️ 201 (+29%)
node_database_size_in_bytes	1,633,663	1,100,618
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	769	61,697	18,905
private-kernel-ordering	128 (+1%)	24,297	8,153
base-rollup	1,758	656,428	873
root-rollup	170 (-1%)	4,072	1,097
private-kernel-inner	793	81,568	18,905
public-kernel-private-input	571	41,519	18,905
public-kernel-non-first-iteration	409	41,561	18,905
merge-rollup	15.7 (+2%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

benesjan

Looks good, but would not merge until the slow updates tree e2e is reliably passing and enabled in CI.

yarn-project/aztec-nr/slow-updates-tree/src/slow_map.nr

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

yarn-project/aztec-nr/slow-updates-tree/src/slow_map.nr

yarn-project/noir-contracts/src/contracts/slow_tree_contract/src/main.nr

yarn-project/aztec-nr/slow-updates-tree/src/slow_map.nr

rahul-kothari · 2023-10-17T16:07:08Z

yarn-project/noir-contracts/src/contracts/slow_tree_contract/src/main.nr

+        );
+    }
+
+    unconstrained fn un_read_leaf_at(address: Field, key: Field) -> Leaf {


why "un"? because currently anyone can read any key?

I also don't understand. @LHerskind ser, please enlighten us

Because unconstrained 🤷

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

rahul-kothari · 2023-10-17T16:15:21Z

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

+
+    const db = levelup(createMemDown());
+    const depth = 254;
+    const tree = await newTree(SparseTree, db, hasher, 'test', depth);


Suggested change

const tree = await newTree(SparseTree, db, hasher, 'test', depth);

// a simulator to help keep track of the state of the expected tree and generate sibling paths

const tree = await newTree(SparseTree, db, hasher, 'test', depth);

@LHerskind renaming it to treeSimulator or something would really improve readability.

Damn naming. Holding me back 😆

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

rahul-kothari · 2023-10-17T16:17:12Z

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

+      .wait();
+    await tree.updateLeaf(new Fr(4).toBuffer(), key);
+
+    await status(key);


should this require any expects?

yarn-project/noir-contracts/src/contracts/slow_tree_contract/src/main.nr

Experimental, very much in progress. Fixes #2852, building on top of #2732. For the experimentation here needed a name for my "data-stack" as it could practically hold whatever you want to throw at it. Was listening to https://www.youtube.com/watch?v=DTrNwbemNK0 while building so its the pez dispenser. The PEZ dispenser is essentially a stack managed by the PXE that hold `mint`s (PEZ Dispenser = "PfeffErminZ"/peppermint dispenser). A `mint` is `Fr[]` which can hold whatever data really, here just used to feed membership proofs and update proofs into the slow updates map.

benesjan

Great job getting this to work. My brain almost melted when reviewing this.

Will approve once the naming and maybe the slow tree test gets improved.

benesjan · 2023-11-06T10:57:20Z

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

+
+    const db = levelup(createMemDown());
+    const depth = 254;
+    const tree = await newTree(SparseTree, db, hasher, 'test', depth);


@LHerskind renaming it to treeSimulator or something would really improve readability.

yarn-project/aztec-nr/slow-updates-tree/src/slow_map.nr

benesjan · 2023-11-06T12:26:03Z

yarn-project/pxe/src/database/memory_db.ts

@@ -20,6 +20,7 @@ export class MemoryDB extends MemoryContractDatabase implements Database {
  private globalVariablesHash: Fr | undefined;
  private addresses: CompleteAddress[] = [];
  private authWitnesses: Record<string, Fr[]> = {};
+  private pezDispenser: Fr[][] = [];


I know it's a way more boring name but simply calling this a slow tree stack or just slow stack and explain what it does here would be quite helpful readability-wise 😆

Damn. You guys are killing me 😭.

benesjan · 2023-11-06T12:34:34Z

yarn-project/acir-simulator/src/acvm/oracle/oracle.ts

@@ -53,6 +53,12 @@ export class Oracle {
    return witness.map(toACVMField);
  }

+  async popMint(): Promise<ACVMField[]> {


Super boring but calling it popSlow and adding a comment here that it pops value of slow tree stack stored in PXE would be helpful.

benesjan · 2023-11-06T13:56:00Z

yarn-project/end-to-end/src/e2e_slow_tree.test.ts

+
+  afterAll(() => teardown());
+
+  it('Messing around with noir slow tree', async () => {


This currently contains only one assert/expect on error. Could we test more stuff here or do you think the blacklist token is enough?

The reads and writes will throw if invalid, but I can create some more.

Cannot perform any of the reads as unconstrained since the return values are dependent on the global variables which are not populated for unconstrained as I recall (might have been changed).

Can add some unconstrained and do the computations manually but it is not really showing as nicely that the value is as expected 🤷.

benesjan · 2023-11-06T13:57:00Z

yarn-project/noir-contracts/src/contracts/slow_tree_contract/src/main.nr

+// This contract allow us to "read" public storage in private through a delayed tree.
+// More documentation need to be outlined for this properly, but there is some in 
+// https://github.com/AztecProtocol/aztec-packages/pull/2732/files
+// This is made as a separate contract for one thing mainly. Making it a simpler to use.


Suggested change

// This is made as a separate contract for one thing mainly. Making it a simpler to use.

// This is made as a separate contract for one thing mainly. Making it simpler to use.

benesjan · 2023-11-06T14:17:17Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/main.nr

+        amount: Field,
+        nonce: Field,
+    ) -> Field {
+        let slow = SlowMap::at(AztecAddress::new(storage.slow_update.get_note().value));


I think it would be clearer if the interface was called SlowTree given that it is calling the slow tree contract. It confused me for a bit when I instinctively navigated to read_at functionality in SlowMap struct and I was confused why public context was used there (given that bellow it's calling a private func).

Ah, got it. Ye it might be a little odd here since it is practically calling the slow tree contract to look up at a specific slow map, but doing a lot of the checks for you.
Will change it.

benesjan · 2023-11-06T14:19:50Z

yarn-project/pxe/src/database/memory_db.ts

    this.notesTable.push(note);
    return Promise.resolve();
  }

+  public addMint(mint: Fr[]): Promise<void> {


Maybe pushSlow?

I'd go for pushToSlowUpdatesTree() to make it easy for external devs

That only makes sense it was only used for the slow updates tree. But you can use it for other stuff, e.g., @benesjan considering using for historic access etc.

@rahul-kothari it is used for both reads and updates atm, so that would be more confusing I think.

benesjan · 2023-11-06T14:19:59Z

yarn-project/pxe/src/database/memory_db.ts

+    return Promise.resolve();
+  }
+
+  public popMint(): Promise<Fr[] | undefined> {


And popSlow?

Referring to above.

rahul-kothari · 2023-11-06T15:02:04Z

yarn-project/types/src/interfaces/pxe.ts

@@ -42,6 +42,12 @@ export interface PXE {
   */
  addAuthWitness(authWitness: AuthWitness): Promise<void>;

+  /**
+   * Adding a mint to the pez dispenser.


Consider using the full form of PEZ - external folks look at it as docs
Also as @benesjan highlighted, add/popMint() could be changed to addTo/popFromSlowUpdatesTree()?

Not sure if mint is the right term here as well

Will look at the name, but it will probably not include slow updates reference since it is to be used for other stuff as well. It is just a generic blob.

rahul-kothari · 2023-11-06T15:03:00Z

yarn-project/pxe/src/database/memory_db.ts

    this.notesTable.push(note);
    return Promise.resolve();
  }

+  public addMint(mint: Fr[]): Promise<void> {


I'd go for pushToSlowUpdatesTree() to make it easy for external devs

rahul-kothari · 2023-11-06T15:03:14Z

yarn-project/pxe/src/database/memory_db.ts

@@ -20,6 +20,7 @@ export class MemoryDB extends MemoryContractDatabase implements Database {
  private globalVariablesHash: Fr | undefined;
  private addresses: CompleteAddress[] = [];
  private authWitnesses: Record<string, Fr[]> = {};
+  private pezDispenser: Fr[][] = [];


rahul-kothari · 2023-11-06T15:04:06Z

yarn-project/pxe/src/database/database.ts

+   * Get the next mint from the pez dispenser.
+   * @returns A promise that resolves to an array of field elements representing the mint.
+   */
+  popMint(): Promise<Fr[] | undefined>;


do we want to throw or just return undefined?

Return undefined, similar to getCompleteAddress it will throw separately if undefined is actually returned because it don't match what you expect in the contract.

rahul-kothari · 2023-11-06T15:05:33Z

yarn-project/aztec-nr/slow-updates-tree/Nargo.toml

+[package]
+name = "slow_updates_tree"
+authors = ["aztec-labs"]
+compiler_version = "0.1"


compiler version is enforced now. Maybe do >=0.18.0

rahul-kothari · 2023-11-06T15:48:17Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/types/balance_set.nr

+use crate::types::token_note::{TokenNote, TOKEN_NOTE_LEN, TokenNoteMethods};
+
+// A set implementing standard manipulation of balances.
+// Does not require spending key, but only knowledge.


but only knowledge of what?

Of the notes that are in the set.

rahul-kothari · 2023-11-06T15:49:36Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/types/balance_set.nr

+                // This will call the the `compute_nullifer` function of the `token_note`
+                // which require knowledge of the secret key (currently the users encryption key).
+                // The contract logic must ensure that the spending key is used as well.
+                // docs:start:remove


we can remove docs references from this file since it is a copy passte

Easier would be if we could import contract dirs and not only libraries, then it could just be imported 👀 @kevaundray

rahul-kothari · 2023-11-06T15:54:46Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/main.nr

@@ -0,0 +1,501 @@
+// docs:start:token_all


probably can remove these doc references

rahul-kothari · 2023-11-06T15:55:07Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/main.nr

+mod types;
+mod interfaces;
+
+// Minimal token implementation that supports `AuthWit` accounts.


replace this with the slow updates tree stuff

rahul-kothari · 2023-11-06T15:55:28Z

yarn-project/noir-contracts/src/contracts/token_blacklist_contract/src/main.nr

+
+
+// TODO's: @LHerskind
+// We are currently unable to do constructor -> private calls


reference the issue you created

Experimental, very much in progress. Fixes #2852, building on top of #2732. For the experimentation here needed a name for my "data-stack" as it could practically hold whatever you want to throw at it. Was listening to https://www.youtube.com/watch?v=DTrNwbemNK0 while building so its the pez dispenser. The PEZ dispenser is essentially a stack managed by the PXE that hold `mint`s (PEZ Dispenser = "PfeffErminZ"/peppermint dispenser). A `mint` is `Fr[]` which can hold whatever data really, here just used to feed membership proofs and update proofs into the slow updates map.

benesjan

LGTM! Just a few tsdocs improvements

benesjan · 2023-11-15T07:55:45Z

yarn-project/acir-simulator/src/client/view_data_oracle.ts

+
+  /**
+   * Gets some notes for a contract address and storage slot.
+   * Returns a flattened array containing real-note-count and note preimages.


Suggested change

* Returns a flattened array containing real-note-count and note preimages.

* Returns a flattened array containing filtered notes.

Why the "real-note-count"? It just returns an array of notes.

Think that have come from a merge at some point 🤔 I don't recall every adding real-note-count

benesjan · 2023-11-15T12:17:07Z

yarn-project/pxe/src/database/database.ts

+  addCapsule(capsule: Fr[]): Promise<void>;
+
+  /**
+   * Get the next capsule from the capsule dispenser.


Suggested change

* Get the next capsule from the capsule dispenser.

* Get the next capsule from the capsule dispenser.

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

benesjan · 2023-11-15T12:17:38Z

yarn-project/pxe/src/database/database.ts

@@ -24,6 +24,18 @@ export interface Database extends ContractDatabase {
   */
  getAuthWitness(messageHash: Fr): Promise<Fr[]>;

+  /**
+   * Adding a capsule to the capsule dispenser.


Suggested change

* Adding a capsule to the capsule dispenser.

* Adding a capsule to the capsule dispenser.

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

Everybody would be searching what a capsule is.

benesjan · 2023-11-15T12:18:38Z

yarn-project/types/src/interfaces/pxe.ts

@@ -42,6 +42,12 @@ export interface PXE {
   */
  addAuthWitness(authWitness: AuthWitness): Promise<void>;

+  /**
+   * Adding a capsule to the capsule dispenser.
+   * @param capsule - An array of field elements representing the capsule.


Suggested change

* @param capsule - An array of field elements representing the capsule.

* @param capsule - An array of field elements representing the capsule.

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

benesjan · 2023-11-15T12:20:10Z

yarn-project/acir-simulator/src/client/db_oracle.ts

@@ -35,6 +35,12 @@ export interface DBOracle extends CommitmentsDB {
   */
  getAuthWitness(messageHash: Fr): Promise<Fr[]>;

+  /**
+   * Retrieve a capsule from the capsule dispenser.
+   * @returns A promise that resolves to an array of field elements representing the capsule.


Suggested change

* @returns A promise that resolves to an array of field elements representing the capsule.

* @returns A promise that resolves to an array of field elements representing the capsule.

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

benesjan · 2023-11-15T12:20:39Z

yarn-project/acir-simulator/src/client/view_data_oracle.ts

@@ -57,7 +57,16 @@ export class ViewDataOracle extends TypedOracle {
  }

  /**
-   * Gets some notes for a storage slot.
+   * Pops a capsule from the capsule dispenser
+   * @returns The capsule values


Suggested change

* @returns The capsule values

* @returns The capsule values

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

benesjan · 2023-11-15T12:21:00Z

yarn-project/types/src/interfaces/pxe.ts

@@ -42,6 +42,12 @@ export interface PXE {
   */
  addAuthWitness(authWitness: AuthWitness): Promise<void>;

+  /**
+   * Adding a capsule to the capsule dispenser.
+   * @param capsule - An array of field elements representing the capsule.


Suggested change

* @param capsule - An array of field elements representing the capsule.

* @param capsule - An array of field elements representing the capsule.

* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

benesjan · 2023-11-15T12:21:45Z

yarn-project/noir-contracts/src/contracts/slow_tree_contract/src/capsule.nr

+#[oracle(popCapsule)]
+fn pop_capsule_oracle<N>() -> [Field; N] {}
+
+unconstrained pub fn pop_capsule<N>() -> [Field; N] {


Suggested change

unconstrained pub fn pop_capsule<N>() -> [Field; N] {

// A capsule is a "blob" of data that is passed to the contract through an oracle.

unconstrained pub fn pop_capsule<N>() -> [Field; N] {

benesjan · 2023-11-15T12:36:26Z

yarn-project/acir-simulator/src/client/view_data_oracle.ts

+
+  /**
+   * Gets some notes for a contract address and storage slot.
+   * Returns a flattened array containing real-note-count and note preimages.


Suggested change

* Returns a flattened array containing real-note-count and note preimages.

* Returns a flattened array containing filtered notes.

Why the "real-note-count"? It just returns an array of notes.

Experimental, very much in progress. Fixes #2852, building on top of #2732. For the experimentation here needed a name for my "data-stack" as it could practically hold whatever you want to throw at it. Was listening to https://www.youtube.com/watch?v=DTrNwbemNK0 while building so its the pez dispenser. The PEZ dispenser is essentially a stack managed by the PXE that hold `mint`s (PEZ Dispenser = "PfeffErminZ"/peppermint dispenser). A `mint` is `Fr[]` which can hold whatever data really, here just used to feed membership proofs and update proofs into the slow updates map.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.15.1</summary> ## [0.15.1](aztec-packages-v0.15.0...aztec-packages-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](#3335)) ([c99862c](c99862c)) * DataBus PoC (UltraHonk as extension of Ultra) ([#3181](#3181)) ([dd9dd84](dd9dd84)) * Deploy docs from CCI w/ netlify-cli ([#3348](#3348)) ([624d733](624d733)) * Fold batching challenge (alpha) ([#3291](#3291)) ([bc99a4f](bc99a4f)) * Open transcript polys as univariates in ECCVM ([#3331](#3331)) ([436b22e](436b22e)) * Sandbox packages ([#3360](#3360)) ([0dc2d58](0dc2d58)) * Slow updates experimentation ([#2732](#2732)) ([193e6c8](193e6c8)) * ZM updates for Translator concatenated polys ([#3343](#3343)) ([0e425db](0e425db)) ### Bug Fixes * Bootstrap bbjs. ([#3337](#3337)) ([06aedcb](06aedcb)) * Noir-compiler breadth-first resolver ([#3307](#3307)) ([02348cf](02348cf)) * Update command looks at devDeps ([#3276](#3276)) ([54ee38d](54ee38d)), closes [#3275](#3275) * Updating pedersen benchmarks ([#3211](#3211)) ([7e89ff3](7e89ff3)) * Warn on circular imports. ([#3350](#3350)) ([5bfbddb](5bfbddb)) ### Miscellaneous * All hashes in ts ([#3333](#3333)) ([6307e12](6307e12)) * Compute function tree root in ts. ([#3326](#3326)) ([48d8c7f](48d8c7f)) * **docs:** Suggest CLI install per project ([#3267](#3267)) ([b4c967b](b4c967b)) * Enforce bracing around blocks. Generally considered easier to read and less error prone. ([#3349](#3349)) ([ee11dec](ee11dec)) * Fix circulars in foundation. Also cleanup fields and optimise to be buffer underlying. ([#3351](#3351)) ([c4bf8d3](c4bf8d3)) * Public kernel tests ([#3325](#3325)) ([bace972](bace972)) ### Documentation * Fixed errors in Gas and Fees yellow paper ([#3363](#3363)) ([d818206](d818206)) * Initial network section of yellow paper ([#3341](#3341)) ([5a18615](5a18615)) * Yellow paper section on Gas and Fees ([#3327](#3327)) ([caa7e10](caa7e10)) </details> <details><summary>barretenberg.js: 0.15.1</summary> ## [0.15.1](barretenberg.js-v0.15.0...barretenberg.js-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](#3335)) ([c99862c](c99862c)) ### Miscellaneous * All hashes in ts ([#3333](#3333)) ([6307e12](6307e12)) </details> <details><summary>barretenberg: 0.15.1</summary> ## [0.15.1](barretenberg-v0.15.0...barretenberg-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](#3335)) ([c99862c](c99862c)) * DataBus PoC (UltraHonk as extension of Ultra) ([#3181](#3181)) ([dd9dd84](dd9dd84)) * Fold batching challenge (alpha) ([#3291](#3291)) ([bc99a4f](bc99a4f)) * Open transcript polys as univariates in ECCVM ([#3331](#3331)) ([436b22e](436b22e)) * ZM updates for Translator concatenated polys ([#3343](#3343)) ([0e425db](0e425db)) ### Bug Fixes * Bootstrap bbjs. ([#3337](#3337)) ([06aedcb](06aedcb)) * Updating pedersen benchmarks ([#3211](#3211)) ([7e89ff3](7e89ff3)) ### Miscellaneous * All hashes in ts ([#3333](#3333)) ([6307e12](6307e12)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.15.1</summary> ## [0.15.1](AztecProtocol/aztec-packages@aztec-packages-v0.15.0...aztec-packages-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](AztecProtocol/aztec-packages#3335)) ([c99862c](AztecProtocol/aztec-packages@c99862c)) * DataBus PoC (UltraHonk as extension of Ultra) ([#3181](AztecProtocol/aztec-packages#3181)) ([dd9dd84](AztecProtocol/aztec-packages@dd9dd84)) * Deploy docs from CCI w/ netlify-cli ([#3348](AztecProtocol/aztec-packages#3348)) ([624d733](AztecProtocol/aztec-packages@624d733)) * Fold batching challenge (alpha) ([#3291](AztecProtocol/aztec-packages#3291)) ([bc99a4f](AztecProtocol/aztec-packages@bc99a4f)) * Open transcript polys as univariates in ECCVM ([#3331](AztecProtocol/aztec-packages#3331)) ([436b22e](AztecProtocol/aztec-packages@436b22e)) * Sandbox packages ([#3360](AztecProtocol/aztec-packages#3360)) ([0dc2d58](AztecProtocol/aztec-packages@0dc2d58)) * Slow updates experimentation ([#2732](AztecProtocol/aztec-packages#2732)) ([193e6c8](AztecProtocol/aztec-packages@193e6c8)) * ZM updates for Translator concatenated polys ([#3343](AztecProtocol/aztec-packages#3343)) ([0e425db](AztecProtocol/aztec-packages@0e425db)) ### Bug Fixes * Bootstrap bbjs. ([#3337](AztecProtocol/aztec-packages#3337)) ([06aedcb](AztecProtocol/aztec-packages@06aedcb)) * Noir-compiler breadth-first resolver ([#3307](AztecProtocol/aztec-packages#3307)) ([02348cf](AztecProtocol/aztec-packages@02348cf)) * Update command looks at devDeps ([#3276](AztecProtocol/aztec-packages#3276)) ([54ee38d](AztecProtocol/aztec-packages@54ee38d)), closes [#3275](AztecProtocol/aztec-packages#3275) * Updating pedersen benchmarks ([#3211](AztecProtocol/aztec-packages#3211)) ([7e89ff3](AztecProtocol/aztec-packages@7e89ff3)) * Warn on circular imports. ([#3350](AztecProtocol/aztec-packages#3350)) ([5bfbddb](AztecProtocol/aztec-packages@5bfbddb)) ### Miscellaneous * All hashes in ts ([#3333](AztecProtocol/aztec-packages#3333)) ([6307e12](AztecProtocol/aztec-packages@6307e12)) * Compute function tree root in ts. ([#3326](AztecProtocol/aztec-packages#3326)) ([48d8c7f](AztecProtocol/aztec-packages@48d8c7f)) * **docs:** Suggest CLI install per project ([#3267](AztecProtocol/aztec-packages#3267)) ([b4c967b](AztecProtocol/aztec-packages@b4c967b)) * Enforce bracing around blocks. Generally considered easier to read and less error prone. ([#3349](AztecProtocol/aztec-packages#3349)) ([ee11dec](AztecProtocol/aztec-packages@ee11dec)) * Fix circulars in foundation. Also cleanup fields and optimise to be buffer underlying. ([#3351](AztecProtocol/aztec-packages#3351)) ([c4bf8d3](AztecProtocol/aztec-packages@c4bf8d3)) * Public kernel tests ([#3325](AztecProtocol/aztec-packages#3325)) ([bace972](AztecProtocol/aztec-packages@bace972)) ### Documentation * Fixed errors in Gas and Fees yellow paper ([#3363](AztecProtocol/aztec-packages#3363)) ([d818206](AztecProtocol/aztec-packages@d818206)) * Initial network section of yellow paper ([#3341](AztecProtocol/aztec-packages#3341)) ([5a18615](AztecProtocol/aztec-packages@5a18615)) * Yellow paper section on Gas and Fees ([#3327](AztecProtocol/aztec-packages#3327)) ([caa7e10](AztecProtocol/aztec-packages@caa7e10)) </details> <details><summary>barretenberg.js: 0.15.1</summary> ## [0.15.1](AztecProtocol/aztec-packages@barretenberg.js-v0.15.0...barretenberg.js-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](AztecProtocol/aztec-packages#3335)) ([c99862c](AztecProtocol/aztec-packages@c99862c)) ### Miscellaneous * All hashes in ts ([#3333](AztecProtocol/aztec-packages#3333)) ([6307e12](AztecProtocol/aztec-packages@6307e12)) </details> <details><summary>barretenberg: 0.15.1</summary> ## [0.15.1](AztecProtocol/aztec-packages@barretenberg-v0.15.0...barretenberg-v0.15.1) (2023-11-21) ### Features * **bb:** Add ability to write pk to file or stdout ([#3335](AztecProtocol/aztec-packages#3335)) ([c99862c](AztecProtocol/aztec-packages@c99862c)) * DataBus PoC (UltraHonk as extension of Ultra) ([#3181](AztecProtocol/aztec-packages#3181)) ([dd9dd84](AztecProtocol/aztec-packages@dd9dd84)) * Fold batching challenge (alpha) ([#3291](AztecProtocol/aztec-packages#3291)) ([bc99a4f](AztecProtocol/aztec-packages@bc99a4f)) * Open transcript polys as univariates in ECCVM ([#3331](AztecProtocol/aztec-packages#3331)) ([436b22e](AztecProtocol/aztec-packages@436b22e)) * ZM updates for Translator concatenated polys ([#3343](AztecProtocol/aztec-packages#3343)) ([0e425db](AztecProtocol/aztec-packages@0e425db)) ### Bug Fixes * Bootstrap bbjs. ([#3337](AztecProtocol/aztec-packages#3337)) ([06aedcb](AztecProtocol/aztec-packages@06aedcb)) * Updating pedersen benchmarks ([#3211](AztecProtocol/aztec-packages#3211)) ([7e89ff3](AztecProtocol/aztec-packages@7e89ff3)) ### Miscellaneous * All hashes in ts ([#3333](AztecProtocol/aztec-packages#3333)) ([6307e12](AztecProtocol/aztec-packages@6307e12)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

LHerskind force-pushed the lh/slow_updates_experimentation branch from c040203 to 6335662 Compare October 10, 2023 14:53

LHerskind mentioned this pull request Oct 10, 2023

Slow updates tree #1291

Closed

LHerskind linked an issue Oct 10, 2023 that may be closed by this pull request

Slow updates tree #1291

Closed

LHerskind removed a link to an issue Oct 11, 2023

Slow updates tree #1291

Closed

LHerskind linked an issue Oct 11, 2023 that may be closed by this pull request

feat(slow updates tree): Minimal Noir implementation #2801

Closed

LHerskind force-pushed the lh/slow_updates_experimentation branch from 0b8aae4 to 8a9f09f Compare October 13, 2023 12:22

LHerskind marked this pull request as ready for review October 13, 2023 19:04

LHerskind requested review from benesjan, rahul-kothari and Maddiaa0 October 13, 2023 19:05

LHerskind mentioned this pull request Oct 16, 2023

feat: add oracle for slow updates #2878

Merged

4 tasks

benesjan reviewed Oct 17, 2023

View reviewed changes

rahul-kothari reviewed Oct 17, 2023

View reviewed changes

LHerskind marked this pull request as draft October 18, 2023 09:38

LHerskind force-pushed the lh/slow_updates_experimentation branch from 5537285 to 9acfac9 Compare October 31, 2023 08:38

LHerskind force-pushed the lh/slow_updates_experimentation branch from 09c13d6 to f07c219 Compare October 31, 2023 10:31

LHerskind mentioned this pull request Nov 2, 2023

Setup fixture ignores number of wallets if sandbox is connected #3214

Closed

LHerskind force-pushed the lh/slow_updates_experimentation branch from 1c206cd to bc2fd1f Compare November 3, 2023 15:08

LHerskind marked this pull request as ready for review November 3, 2023 18:47

benesjan requested changes Nov 6, 2023

View reviewed changes

rahul-kothari reviewed Nov 6, 2023

View reviewed changes

LHerskind force-pushed the lh/slow_updates_experimentation branch from 1e8a52c to 8173996 Compare November 13, 2023 21:00

benesjan approved these changes Nov 15, 2023

View reviewed changes

LHerskind force-pushed the lh/slow_updates_experimentation branch from 2025939 to e0aea78 Compare November 19, 2023 18:36

LHerskind added 22 commits November 20, 2023 21:06

feat: initial usdc-like token

7a8f0e7

chore: artifact inclusion

664ce41

test: add blacklist tests

4a5ab6a

chore: add to ci

d0cf908

feat: use slow updates for almost all access control in token

402acf1

chore: 🧹

76dc6ff

chore: fix import

2a6eb04

chore: add extra accounts if needed

c7d44be

chore: add slow-tree test to ci

252f170

chore: recompile noir

1011f97

chore: noir updates

8d52ec4

chore: fix imports

a85bb1a

chore: addressing minor comments

1bf0d99

chore: add constraints to e2e_slow_tree.test.ts

2d61536

refactor: use capsules and capsule dispenser instead.

8faad6d

chore: formatting

23bd7f4

chore: merge fixing

9a46997

fix: merge

b73201c

chore: linter

ce11537

chore: formatting

343b027

chore: address comments

bcbb362

chore: compiler version nargo toml

401ab5d

LHerskind force-pushed the lh/slow_updates_experimentation branch from 55854be to 401ab5d Compare November 20, 2023 21:07

LHerskind merged commit 193e6c8 into master Nov 20, 2023
80 checks passed

LHerskind deleted the lh/slow_updates_experimentation branch November 20, 2023 22:10

AztecBot mentioned this pull request Nov 20, 2023

chore(master): Release 0.15.1 #3338

Merged

LHerskind mentioned this pull request Nov 21, 2023

Token contract with blacklist to showcase SUT #2793

Closed

critesjosh mentioned this pull request Nov 21, 2023

Document slow updates tree #3374

Closed

	const tree = await newTree(SparseTree, db, hasher, 'test', depth);
	// a simulator to help keep track of the state of the expected tree and generate sibling paths
	const tree = await newTree(SparseTree, db, hasher, 'test', depth);


		afterAll(() => teardown());

		it('Messing around with noir slow tree', async () => {

	// This is made as a separate contract for one thing mainly. Making it a simpler to use.
	// This is made as a separate contract for one thing mainly. Making it simpler to use.



		// TODO's: @LHerskind
		// We are currently unable to do constructor -> private calls

	* Returns a flattened array containing real-note-count and note preimages.
	* Returns a flattened array containing filtered notes.

	* Get the next capsule from the capsule dispenser.
	* Get the next capsule from the capsule dispenser.
	* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

	* Adding a capsule to the capsule dispenser.
	* Adding a capsule to the capsule dispenser.
	* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

	* @param capsule - An array of field elements representing the capsule.
	* @param capsule - An array of field elements representing the capsule.
	* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

	* @returns A promise that resolves to an array of field elements representing the capsule.
	* @returns A promise that resolves to an array of field elements representing the capsule.
	* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

	* @returns The capsule values
	* @returns The capsule values
	* @remarks A capsule is a "blob" of data that is passed to the contract through an oracle.

	unconstrained pub fn pop_capsule<N>() -> [Field; N] {
	// A capsule is a "blob" of data that is passed to the contract through an oracle.
	unconstrained pub fn pop_capsule<N>() -> [Field; N] {

feat: Slow updates experimentation #2732

feat: Slow updates experimentation #2732

Conversation

LHerskind commented Oct 6, 2023 • edited

Checklist:

AztecBot commented Oct 13, 2023 • edited

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

benesjan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan Nov 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan left a comment

Choose a reason for hiding this comment

benesjan Nov 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan Nov 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan left a comment

Choose a reason for hiding this comment

benesjan Nov 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LHerskind commented Oct 6, 2023 •

edited

AztecBot commented Oct 13, 2023 •

edited

benesjan Nov 6, 2023 •

edited

benesjan Nov 6, 2023 •

edited

benesjan Nov 6, 2023 •

edited

benesjan Nov 15, 2023 •

edited