chore: Remove old contract deployment flow #4970

spalladino · 2024-03-05T22:54:10Z

Removes the old contract deployment flow from L1 contracts, noir-protocol-circuits, and yarn-packages. This removal includes but is not limited to:

Contract Tree
L1 ContractDeploymentEmitter
newContracts property from txs, tx effects, kernels, etc
isContractDeployment and contractDeploymentData properties in call context
NewContractData and ContractDeploymentData structs

Subsequent PRs should further update docs, update the kv store internal structure, update pxe and node APIs, and remove more unused structs. This PR is big enough as it is.

github-actions · 2024-03-05T23:22:18Z

Changes to circuit sizes

Generated at commit: f0a6aba3192a66660b801267011be263215b4ede, compared to commit: dc2fd9e584d987bdc5d2d7a117b76cb50a20b969

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
rollup_root	-6 ✅	-0.27%	0 ➖	0.00%
rollup_merge	-6 ✅	-1.15%	0 ➖	0.00%
private_kernel_tail	-26 ✅	-0.01%	-38 ✅	-0.00%
public_kernel_tail	-30 ✅	-0.05%	-43 ✅	-0.02%
public_kernel_setup	-34 ✅	-0.13%	-975 ✅	-0.55%
public_kernel_teardown	-70 ✅	-0.24%	-1,011 ✅	-0.56%
public_kernel_app_logic	-82 ✅	-0.15%	-1,873 ✅	-0.60%
rollup_base	-536 ✅	-0.33%	-13,192 ✅	-0.76%
public_kernel_app_logic_simulated	-12 ✅	-1.30%	-24 ✅	-1.30%
public_kernel_setup_simulated	-12 ✅	-1.30%	-24 ✅	-1.30%
public_kernel_teardown_simulated	-12 ✅	-1.30%	-24 ✅	-1.30%
public_kernel_tail_simulated	-12 ✅	-1.30%	-24 ✅	-1.30%
private_kernel_inner_simulated	-12 ✅	-1.34%	-24 ✅	-1.34%
private_kernel_init_simulated	-12 ✅	-1.34%	-24 ✅	-1.34%
private_kernel_inner	-888 ✅	-0.94%	-9,296 ✅	-1.76%
private_kernel_init	-833 ✅	-1.76%	-8,579 ✅	-2.40%
private_kernel_tail_simulated	-12 ✅	-2.57%	-24 ✅	-2.56%
rollup_base_simulated	0 ➖	0.00%	-4 ✅	-10.26%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
rollup_root	2,191 (-6)	-0.27%	104,111 (0)	0.00%
rollup_merge	518 (-6)	-1.15%	45,970 (0)	0.00%
private_kernel_tail	373,139 (-26)	-0.01%	839,245 (-38)	-0.00%
public_kernel_tail	59,529 (-30)	-0.05%	184,021 (-43)	-0.02%
public_kernel_setup	26,935 (-34)	-0.13%	177,371 (-975)	-0.55%
public_kernel_teardown	28,609 (-70)	-0.24%	179,046 (-1,011)	-0.56%
public_kernel_app_logic	54,313 (-82)	-0.15%	309,345 (-1,873)	-0.60%
rollup_base	161,090 (-536)	-0.33%	1,720,402 (-13,192)	-0.76%
public_kernel_app_logic_simulated	908 (-12)	-1.30%	1,819 (-24)	-1.30%
public_kernel_setup_simulated	908 (-12)	-1.30%	1,819 (-24)	-1.30%
public_kernel_teardown_simulated	908 (-12)	-1.30%	1,819 (-24)	-1.30%
public_kernel_tail_simulated	908 (-12)	-1.30%	1,819 (-24)	-1.30%
private_kernel_inner_simulated	882 (-12)	-1.34%	1,767 (-24)	-1.34%
private_kernel_init_simulated	882 (-12)	-1.34%	1,767 (-24)	-1.34%
private_kernel_inner	93,754 (-888)	-0.94%	519,482 (-9,296)	-1.76%
private_kernel_init	46,474 (-833)	-1.76%	348,531 (-8,579)	-2.40%
private_kernel_tail_simulated	455 (-12)	-2.57%	913 (-24)	-2.56%
rollup_base_simulated	1 (0)	0.00%	35 (-4)	-10.26%

AztecBot · 2024-03-08T23:50:03Z

Benchmark results

Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 129 (-46%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit dc2fd9e5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668 (-1%)	18,820	36,356
l1_rollup_calldata_gas	66,004 (-1%)	238,720	469,664
l1_rollup_execution_gas	666,484 (-1%)	953,429 (-3%)	1,336,820 (-4%)
l2_block_processing_time_in_ms	1,280 (-5%)	4,576 (-4%)	8,808 (-2%)
note_successful_decrypting_time_in_ms	⚠️ 129 (-46%)	541 (-13%)	894 (-5%)
note_trial_decrypting_time_in_ms	32.9 (-17%)	56.7 (+49%)	124 (+62%)
l2_block_building_time_in_ms	12,463 (-3%)	47,979 (-5%)	94,449 (-7%)
l2_block_rollup_simulation_time_in_ms	7,157 (-6%)	28,411 (-6%)	56,228 (-7%)
l2_block_public_tx_process_time_in_ms	5,275 (+2%)	19,506 (-5%)	38,117 (-7%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,926 (-1%)	27,516 (-1%)
note_history_successful_decrypting_time_in_ms	1,237 (-13%)	2,562 (-4%)
note_history_trial_decrypting_time_in_ms	56.1 (-61%)	127 (+11%)
node_database_size_in_bytes	18,649,168 (-1%)	35,295,312 (-1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	269 (-5%)	44,338 (-1%)	27,700 (-1%)
private-kernel-ordering	202 (-4%)	52,324 (-1%)	14,326 (-2%)
base-rollup	656 (-5%)	177,083	925 (-7%)
root-rollup	67.6 (-4%)	4,176 (-3%)	789 (-4%)
private-kernel-inner	355 (-3%)	73,197 (-1%)	27,700 (-1%)
public-kernel-app-logic	177 (-8%)	34,582 (-1%)	27,671 (-1%)
public-kernel-tail	90.9 (-4%)	34,206 (-1%)	27,671 (-1%)
merge-rollup	8.14 (-9%)	2,696 (-5%)	925 (-7%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	15.9 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8 (-1%)	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583 (+1%)	0.492 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8 (-2%)	73.7 (+3%)	223 (-3%)	446 (+1%)	845 (-2%)	1,666 (-3%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470 (-2%)	0.454 (+3%)	0.407 (-3%)	0.417 (+1%)	0.403 (-2%)	0.400 (-3%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.4 (-3%)	106	324 (-4%)	661 (-1%)	1,275 (-2%)	2,602	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.473 (-4%)	0.478	0.441 (-4%)	0.454 (-1%)	0.441 (-3%)	0.452 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.5 (-4%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.529 (-4%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	19,191 (-2%)

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,752 (-6%)	1,421 (-4%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	8.67 (-4%)	609 (-6%)

AztecBot · 2024-03-09T01:56:59Z

Docs Preview

Hey there! 👋 You can check your preview at https://65eef045c99fd94089566836--aztec-docs-dev.netlify.app

alexghr · 2024-03-11T09:40:33Z

noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr

+    // TODO(palla/purge-old-contract-deploy): Unhardcode this or add a unit test that checks when this changes so no one else loses hours debugging
+    global CANONICAL_GAS_TOKEN_ADDRESS = AztecAddress::from_field(0x256a0a818c8631dac7fbeb0534a0da522418b8ef3ef171533bf0b8e9b9ded5f3);


Sorry about that. THere is a unit test checking the address though (as a snapshot). I'll open a PR to pass it through as a parameter

alexghr · 2024-03-11T09:51:56Z

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/components.nr

 global TX_EFFECTS_HASH_LOG_FIELDS = 4;
-global TX_EFFECTS_HASH_INPUT_FIELDS = 201; // TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS
+global TX_EFFECTS_HASH_INPUT_FIELDS = 198; // TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS


I think Noir supports arithmetic on global constants now

Suggested change

global TX_EFFECTS_HASH_INPUT_FIELDS = 198; // TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS

global TX_EFFECTS_HASH_INPUT_FIELDS = TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS;

I tried using it and the compiler shouted at me, seems like that is not yet merged back into aztec-packages..?

Yeah, just came back to report it doens't actually work for me 🙃

alexghr · 2024-03-11T10:05:27Z

yarn-project/end-to-end/src/e2e_inclusion_proofs_contract.test.ts

@@ -297,8 +296,7 @@ describe('e2e_inclusion_proofs_contract', () => {
    it.skip('contract existence failure case', async () => {
      // This should fail because we choose a block number before the contract was deployed
      const blockNumber = deploymentBlockNumber - 1;
-      const contractData = new NewContractData(contract.address, portalContractAddress, contractClassId);
-      const leaf = contractData.hash();
+      const leaf = Fr.ZERO; // TODO: Calculate proper leaf value


Just adding a note here in case you wanted you update it in this PR

noir-projects/.vscode/settings.json

noir-projects/aztec-nr/aztec/src/context/private_context.nr

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.0</summary> ## [0.27.0](aztec-package-v0.26.6...aztec-package-v0.27.0) (2024-03-12) ### Features * Add api for inclusion proof of outgoing message in block [#4562](#4562) ([#4899](#4899)) ([26d2643](26d2643)) ### Miscellaneous * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) </details> <details><summary>barretenberg.js: 0.27.0</summary> ## [0.27.0](barretenberg.js-v0.26.6...barretenberg.js-v0.27.0) (2024-03-12) ### Miscellaneous * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) </details> <details><summary>aztec-cli: 0.27.0</summary> ## [0.27.0](aztec-cli-v0.26.6...aztec-cli-v0.27.0) (2024-03-12) ### Miscellaneous * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) </details> <details><summary>aztec-packages: 0.27.0</summary> ## [0.27.0](aztec-packages-v0.26.6...aztec-packages-v0.27.0) (2024-03-12) ### ⚠ BREAKING CHANGES * Remove open keyword from Noir ([#4967](#4967)) ### Features * Add api for inclusion proof of outgoing message in block [#4562](#4562) ([#4899](#4899)) ([26d2643](26d2643)) * **avm-simulator:** External calls + integration ([#5051](#5051)) ([dde33f4](dde33f4)) * **avm-simulator:** External static calls + integration ([#5089](#5089)) ([428d950](428d950)) * **avm:** Equivalence check between Main trace and Mem trace ([#5032](#5032)) ([7f216eb](7f216eb)), closes [#4955](#4955) * **avm:** Fix some Brillig problems ([#5091](#5091)) ([07dd821](07dd821)) * Initial integration avm prover ([#4878](#4878)) ([2e2554e](2e2554e)) * Noir pull action ([#5062](#5062)) ([b2d7d14](b2d7d14)) * Restore contract inclusion proofs ([#5141](#5141)) ([a39cd61](a39cd61)) * Update the core of SMT Circuit class ([#5096](#5096)) ([1519d3b](1519d3b)) * Updating archiver with new inbox ([#5025](#5025)) ([f6d17c9](f6d17c9)), closes [#4828](#4828) ### Bug Fixes * Duplicate factory code temporarily to unblock ([#5099](#5099)) ([8b10600](8b10600)) * Remove hard coded canonical gas address ([#5106](#5106)) ([dc2fd9e](dc2fd9e)) ### Miscellaneous * **avm-simulator:** Enable compressed strings unencrypted log test ([#5083](#5083)) ([8f7519b](8f7519b)) * **avm-simulator:** Formatting and fixes ([#5092](#5092)) ([b3fa084](b3fa084)) * **AVM:** Negative unit tests for inter table relations ([#5143](#5143)) ([a74dccb](a74dccb)), closes [#5033](#5033) * Aztec-macros refactor ([#5127](#5127)) ([2195441](2195441)) * **ci:** Fail on clippy warnings in noir ([#5101](#5101)) ([54af648](54af648)) * Extract bb binary in bs fast ([#5128](#5128)) ([9ca41ef](9ca41ef)) * Increase bytecode size limit ([#5098](#5098)) ([53b2381](53b2381)) * Increase permitted bytecode size ([#5136](#5136)) ([6865c34](6865c34)) * Join-split example Part 2 ([#5016](#5016)) ([0718320](0718320)) * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) * Nicer snapshots ([#5133](#5133)) ([9a737eb](9a737eb)) * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) * Remove open keyword from Noir ([#4967](#4967)) ([401557e](401557e)) * Run nargo fmt on each nargo project ([#5102](#5102)) ([b327254](b327254)) * Use context interface in mark-as-initialized ([#5142](#5142)) ([932c1d5](932c1d5)) </details> <details><summary>barretenberg: 0.27.0</summary> ## [0.27.0](barretenberg-v0.26.6...barretenberg-v0.27.0) (2024-03-12) ### Features * **avm:** Equivalence check between Main trace and Mem trace ([#5032](#5032)) ([7f216eb](7f216eb)), closes [#4955](#4955) * Initial integration avm prover ([#4878](#4878)) ([2e2554e](2e2554e)) * Update the core of SMT Circuit class ([#5096](#5096)) ([1519d3b](1519d3b)) ### Miscellaneous * **AVM:** Negative unit tests for inter table relations ([#5143](#5143)) ([a74dccb](a74dccb)), closes [#5033](#5033) * Extract bb binary in bs fast ([#5128](#5128)) ([9ca41ef](9ca41ef)) * Join-split example Part 2 ([#5016](#5016)) ([0718320](0718320)) * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-package-v0.26.6...aztec-package-v0.27.0) (2024-03-12) ### Features * Add api for inclusion proof of outgoing message in block [#4562](AztecProtocol/aztec-packages#4562) ([#4899](AztecProtocol/aztec-packages#4899)) ([26d2643](AztecProtocol/aztec-packages@26d2643)) ### Miscellaneous * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) </details> <details><summary>barretenberg.js: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@barretenberg.js-v0.26.6...barretenberg.js-v0.27.0) (2024-03-12) ### Miscellaneous * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) </details> <details><summary>aztec-cli: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-cli-v0.26.6...aztec-cli-v0.27.0) (2024-03-12) ### Miscellaneous * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) </details> <details><summary>aztec-packages: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-packages-v0.26.6...aztec-packages-v0.27.0) (2024-03-12) ### ⚠ BREAKING CHANGES * Remove open keyword from Noir ([#4967](AztecProtocol/aztec-packages#4967)) ### Features * Add api for inclusion proof of outgoing message in block [#4562](AztecProtocol/aztec-packages#4562) ([#4899](AztecProtocol/aztec-packages#4899)) ([26d2643](AztecProtocol/aztec-packages@26d2643)) * **avm-simulator:** External calls + integration ([#5051](AztecProtocol/aztec-packages#5051)) ([dde33f4](AztecProtocol/aztec-packages@dde33f4)) * **avm-simulator:** External static calls + integration ([#5089](AztecProtocol/aztec-packages#5089)) ([428d950](AztecProtocol/aztec-packages@428d950)) * **avm:** Equivalence check between Main trace and Mem trace ([#5032](AztecProtocol/aztec-packages#5032)) ([7f216eb](AztecProtocol/aztec-packages@7f216eb)), closes [#4955](AztecProtocol/aztec-packages#4955) * **avm:** Fix some Brillig problems ([#5091](AztecProtocol/aztec-packages#5091)) ([07dd821](AztecProtocol/aztec-packages@07dd821)) * Initial integration avm prover ([#4878](AztecProtocol/aztec-packages#4878)) ([2e2554e](AztecProtocol/aztec-packages@2e2554e)) * Noir pull action ([#5062](AztecProtocol/aztec-packages#5062)) ([b2d7d14](AztecProtocol/aztec-packages@b2d7d14)) * Restore contract inclusion proofs ([#5141](AztecProtocol/aztec-packages#5141)) ([a39cd61](AztecProtocol/aztec-packages@a39cd61)) * Update the core of SMT Circuit class ([#5096](AztecProtocol/aztec-packages#5096)) ([1519d3b](AztecProtocol/aztec-packages@1519d3b)) * Updating archiver with new inbox ([#5025](AztecProtocol/aztec-packages#5025)) ([f6d17c9](AztecProtocol/aztec-packages@f6d17c9)), closes [#4828](AztecProtocol/aztec-packages#4828) ### Bug Fixes * Duplicate factory code temporarily to unblock ([#5099](AztecProtocol/aztec-packages#5099)) ([8b10600](AztecProtocol/aztec-packages@8b10600)) * Remove hard coded canonical gas address ([#5106](AztecProtocol/aztec-packages#5106)) ([dc2fd9e](AztecProtocol/aztec-packages@dc2fd9e)) ### Miscellaneous * **avm-simulator:** Enable compressed strings unencrypted log test ([#5083](AztecProtocol/aztec-packages#5083)) ([8f7519b](AztecProtocol/aztec-packages@8f7519b)) * **avm-simulator:** Formatting and fixes ([#5092](AztecProtocol/aztec-packages#5092)) ([b3fa084](AztecProtocol/aztec-packages@b3fa084)) * **AVM:** Negative unit tests for inter table relations ([#5143](AztecProtocol/aztec-packages#5143)) ([a74dccb](AztecProtocol/aztec-packages@a74dccb)), closes [#5033](AztecProtocol/aztec-packages#5033) * Aztec-macros refactor ([#5127](AztecProtocol/aztec-packages#5127)) ([2195441](AztecProtocol/aztec-packages@2195441)) * **ci:** Fail on clippy warnings in noir ([#5101](AztecProtocol/aztec-packages#5101)) ([54af648](AztecProtocol/aztec-packages@54af648)) * Extract bb binary in bs fast ([#5128](AztecProtocol/aztec-packages#5128)) ([9ca41ef](AztecProtocol/aztec-packages@9ca41ef)) * Increase bytecode size limit ([#5098](AztecProtocol/aztec-packages#5098)) ([53b2381](AztecProtocol/aztec-packages@53b2381)) * Increase permitted bytecode size ([#5136](AztecProtocol/aztec-packages#5136)) ([6865c34](AztecProtocol/aztec-packages@6865c34)) * Join-split example Part 2 ([#5016](AztecProtocol/aztec-packages#5016)) ([0718320](AztecProtocol/aztec-packages@0718320)) * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) * Nicer snapshots ([#5133](AztecProtocol/aztec-packages#5133)) ([9a737eb](AztecProtocol/aztec-packages@9a737eb)) * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) * Remove open keyword from Noir ([#4967](AztecProtocol/aztec-packages#4967)) ([401557e](AztecProtocol/aztec-packages@401557e)) * Run nargo fmt on each nargo project ([#5102](AztecProtocol/aztec-packages#5102)) ([b327254](AztecProtocol/aztec-packages@b327254)) * Use context interface in mark-as-initialized ([#5142](AztecProtocol/aztec-packages#5142)) ([932c1d5](AztecProtocol/aztec-packages@932c1d5)) </details> <details><summary>barretenberg: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@barretenberg-v0.26.6...barretenberg-v0.27.0) (2024-03-12) ### Features * **avm:** Equivalence check between Main trace and Mem trace ([#5032](AztecProtocol/aztec-packages#5032)) ([7f216eb](AztecProtocol/aztec-packages@7f216eb)), closes [#4955](AztecProtocol/aztec-packages#4955) * Initial integration avm prover ([#4878](AztecProtocol/aztec-packages#4878)) ([2e2554e](AztecProtocol/aztec-packages@2e2554e)) * Update the core of SMT Circuit class ([#5096](AztecProtocol/aztec-packages#5096)) ([1519d3b](AztecProtocol/aztec-packages@1519d3b)) ### Miscellaneous * **AVM:** Negative unit tests for inter table relations ([#5143](AztecProtocol/aztec-packages#5143)) ([a74dccb](AztecProtocol/aztec-packages@a74dccb)), closes [#5033](AztecProtocol/aztec-packages#5033) * Extract bb binary in bs fast ([#5128](AztecProtocol/aztec-packages#5128)) ([9ca41ef](AztecProtocol/aztec-packages@9ca41ef)) * Join-split example Part 2 ([#5016](AztecProtocol/aztec-packages#5016)) ([0718320](AztecProtocol/aztec-packages@0718320)) * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

spalladino force-pushed the palla/purge-old-contract-deploy branch 6 times, most recently from 8a4802d to f217a7b Compare March 8, 2024 23:05

spalladino marked this pull request as ready for review March 10, 2024 23:28

alexghr approved these changes Mar 11, 2024

View reviewed changes

spalladino force-pushed the palla/purge-old-contract-deploy branch from 50e1636 to ca6b13f Compare March 11, 2024 11:22

spalladino enabled auto-merge (squash) March 11, 2024 11:22

PhilWindle requested changes Mar 11, 2024

View reviewed changes

noir-projects/.vscode/settings.json Outdated Show resolved Hide resolved

noir-projects/aztec-nr/aztec/src/context/private_context.nr Show resolved Hide resolved

spalladino disabled auto-merge March 11, 2024 11:30

spalladino added 12 commits March 11, 2024 08:38

chore: Remove old contract deployment flow

c981bb5

Update solidity l2 block parsing

763e827

Remove references to the contract deployment emitter

c5b0335

Fix noir-protocol-circuits-types tests

cc08ceb

Fix simulator tests

732c4d0

Fix sequencer tests

ba44810

Fix l1-contracts test data

932e291

Fix solidity tests

770bb85

Fix slither output by copypasting from CI

40b7bcc

Fix docs

b134992

Fixes post rebase

4714ff3

Remove vscode settings file

6f3e027

spalladino force-pushed the palla/purge-old-contract-deploy branch from 24f1c4b to 6f3e027 Compare March 11, 2024 11:39

spalladino requested a review from PhilWindle March 11, 2024 11:39

PhilWindle approved these changes Mar 11, 2024

View reviewed changes

spalladino merged commit 6d15947 into master Mar 11, 2024
97 checks passed

spalladino deleted the palla/purge-old-contract-deploy branch March 11, 2024 12:09

AztecBot mentioned this pull request Mar 11, 2024

chore(master): Release 0.27.0 #5100

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove old contract deployment flow #4970

chore: Remove old contract deployment flow #4970

spalladino commented Mar 5, 2024 •

edited

Loading

github-actions bot commented Mar 5, 2024 •

edited

Loading

AztecBot commented Mar 8, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

AztecBot commented Mar 9, 2024 •

edited

Loading

alexghr Mar 11, 2024

alexghr Mar 11, 2024

spalladino Mar 11, 2024

alexghr Mar 11, 2024

spalladino Mar 11, 2024

alexghr Mar 11, 2024

alexghr Mar 11, 2024

		// TODO(palla/purge-old-contract-deploy): Unhardcode this or add a unit test that checks when this changes so no one else loses hours debugging
		global CANONICAL_GAS_TOKEN_ADDRESS = AztecAddress::from_field(0x256a0a818c8631dac7fbeb0534a0da522418b8ef3ef171533bf0b8e9b9ded5f3);

	global TX_EFFECTS_HASH_INPUT_FIELDS = 198; // TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS
	global TX_EFFECTS_HASH_INPUT_FIELDS = TX_EFFECTS_HASH_FULL_FIELDS + TX_EFFECTS_HASH_LOG_FIELDS;

chore: Remove old contract deployment flow #4970

chore: Remove old contract deployment flow #4970

Conversation

spalladino commented Mar 5, 2024 • edited Loading

github-actions bot commented Mar 5, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Mar 8, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

AztecBot commented Mar 9, 2024 • edited Loading

Docs Preview

alexghr Mar 11, 2024

Choose a reason for hiding this comment

alexghr Mar 11, 2024

Choose a reason for hiding this comment

spalladino Mar 11, 2024

Choose a reason for hiding this comment

alexghr Mar 11, 2024

Choose a reason for hiding this comment

spalladino Mar 11, 2024

Choose a reason for hiding this comment

alexghr Mar 11, 2024

Choose a reason for hiding this comment

alexghr Mar 11, 2024

Choose a reason for hiding this comment

spalladino commented Mar 5, 2024 •

edited

Loading

github-actions bot commented Mar 5, 2024 •

edited

Loading

AztecBot commented Mar 8, 2024 •

edited

Loading

AztecBot commented Mar 9, 2024 •

edited

Loading