chore: Delete isInternal and isConstructor fields from FunctionData #5232

spalladino · 2024-03-14T23:06:17Z

Deletes the isInternal field from FunctionData, since it is now managed as an app macro instead of a kernel circuit check, and the isConstructor field, since constructors are also managed in app land.

spalladino · 2024-03-14T23:06:26Z

chore: Delete ContractData #5258
chore: Delete ContractDao #5256
chore: Delete ExtendedContractData struct #5248
chore: Delete isInternal and isConstructor fields from FunctionData #5232 👈
chore: Delete unused hash functions #5231
chore: Delete unused contract tree ts code #5229
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite

AztecBot · 2024-03-14T23:43:33Z

Benchmark results

Metrics with a significant change:

batch_insert_into_append_only_tree_32_depth_ms (512): 274 (+19%)
batch_insert_into_indexed_tree_20_depth_ms (512): 396 (+18%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 25ce33bf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,376	238,936	469,736
l1_rollup_execution_gas	659,699	941,520	1,318,143
l2_block_processing_time_in_ms	1,478 (+15%)	4,572 (-10%)	9,011 (-5%)
note_successful_decrypting_time_in_ms	150 (+11%)	489 (-15%)	999 (+2%)
note_trial_decrypting_time_in_ms	54.6 (+36%)	106 (+16%)	132 (+23%)
l2_block_building_time_in_ms	18,194	70,122 (+1%)	138,300
l2_block_rollup_simulation_time_in_ms	8,216	29,658 (+2%)	58,001 (+1%)
l2_block_public_tx_process_time_in_ms	9,955 (-1%)	40,411	80,194 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,679 (-2%)	27,568 (+3%)
note_history_successful_decrypting_time_in_ms	1,186 (-8%)	2,461 (-2%)
note_history_trial_decrypting_time_in_ms	66.3 (-37%)	152 (-21%)
node_database_size_in_bytes	19,075,152	35,668,048
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	284 (+1%)	44,366	28,244
private-kernel-ordering	222 (+2%)	52,868	14,326
base-parity	1,876	128	311
base-rollup	727	165,787	925
root-parity	1,463 (-4%)	1,244	311
root-rollup	70.1 (+2%)	4,487	789
private-kernel-inner	649	73,771	28,244
public-kernel-app-logic	448	35,260	28,215
public-kernel-tail	174 (+1%)	40,926	28,215
merge-rollup	8.96 (+8%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.6 (+4%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.590 (+1%)	0.516 (+4%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.7 (-1%)	77.2 (+8%)	⚠️ 274 (+19%)	437 (-2%)	884 (+3%)	1,746 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470 (-1%)	0.477 (+8%)	0.499 (+19%)	0.410 (-1%)	0.421 (+3%)	0.418 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.3 (-1%)	120 (+13%)	⚠️ 396 (+18%)	663 (-2%)	1,312	2,609 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.476 (-1%)	0.539 (+13%)	0.536 (+17%)	0.458 (-2%)	0.455 (+1%)	0.453 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.8 (-2%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,012

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,301 (-1%)	1,782

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	12.9 (-2%)	1,249

github-actions · 2024-03-14T23:47:29Z

Changes to circuit sizes

Generated at commit: ede52d714810c9b25499408c5452fc5b8ae30fc3, compared to commit: fed70a127cc91453a81ea6019bc32f6db7e4f9a4

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	+24 ❌	+2.72%	+48 ❌	+2.72%
private_kernel_inner_simulated	+24 ❌	+2.72%	+48 ❌	+2.72%
public_kernel_setup	+1,799 ❌	+6.52%	+4,002 ❌	+2.22%
public_kernel_teardown	+1,799 ❌	+6.49%	+4,002 ❌	+2.22%
public_kernel_app_logic	+667 ❌	+1.20%	+2,354 ❌	+0.75%
private_kernel_tail	+8 ❌	+0.00%	+14 ❌	+0.00%
rollup_base	-136 ✅	-0.08%	-238 ✅	-0.01%
private_kernel_inner	+27 ❌	+0.03%	-562 ✅	-0.11%
private_kernel_init	+20 ❌	+0.04%	-1,751 ✅	-0.50%
public_kernel_tail	-2,144 ✅	-1.69%	-6,203 ✅	-1.70%
public_kernel_setup_simulated	-24 ✅	-2.58%	-48 ✅	-2.57%
public_kernel_tail_simulated	-24 ✅	-2.58%	-48 ✅	-2.57%
public_kernel_app_logic_simulated	-24 ✅	-2.58%	-48 ✅	-2.57%
public_kernel_teardown_simulated	-24 ✅	-2.58%	-48 ✅	-2.57%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	906 (+24)	+2.72%	1,815 (+48)	+2.72%
private_kernel_inner_simulated	906 (+24)	+2.72%	1,815 (+48)	+2.72%
public_kernel_setup	29,408 (+1,799)	+6.52%	184,301 (+4,002)	+2.22%
public_kernel_teardown	29,516 (+1,799)	+6.49%	184,410 (+4,002)	+2.22%
public_kernel_app_logic	56,202 (+667)	+1.20%	316,870 (+2,354)	+0.75%
private_kernel_tail	373,475 (+8)	+0.00%	839,587 (+14)	+0.00%
rollup_base	171,450 (-136)	-0.08%	1,730,660 (-238)	-0.01%
private_kernel_inner	95,996 (+27)	+0.03%	521,446 (-562)	-0.11%
private_kernel_init	48,706 (+20)	+0.04%	348,993 (-1,751)	-0.50%
public_kernel_tail	124,967 (-2,144)	-1.69%	358,967 (-6,203)	-1.70%
public_kernel_setup_simulated	908 (-24)	-2.58%	1,819 (-48)	-2.57%
public_kernel_tail_simulated	908 (-24)	-2.58%	1,819 (-48)	-2.57%
public_kernel_app_logic_simulated	908 (-24)	-2.58%	1,819 (-48)	-2.57%
public_kernel_teardown_simulated	908 (-24)	-2.58%	1,819 (-48)	-2.57%

spalladino · 2024-03-15T13:29:19Z

Merge activity

Mar 15, 9:29 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Mar 15, 10:23 AM EDT: @spalladino merged this pull request with Graphite.

@benesjan

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.29.0</summary> ## [0.29.0](aztec-package-v0.28.1...aztec-package-v0.29.0) (2024-03-18) ### Features * Initial Earthly CI ([#5069](#5069)) ([8e75fe5](8e75fe5)) </details> <details><summary>barretenberg.js: 0.29.0</summary> ## [0.29.0](barretenberg.js-v0.28.1...barretenberg.js-v0.29.0) (2024-03-18) ### Features * Initial Earthly CI ([#5069](#5069)) ([8e75fe5](8e75fe5)) </details> <details><summary>aztec-cli: 0.29.0</summary> ## [0.29.0](aztec-cli-v0.28.1...aztec-cli-v0.29.0) (2024-03-18) ### Features * Use deployer in address computation ([#5201](#5201)) ([258ff4a](258ff4a)) ### Miscellaneous * Delete ContractData ([#5258](#5258)) ([e516f9b](e516f9b)) * Delete ExtendedContractData struct ([#5248](#5248)) ([8ae0c13](8ae0c13)) * Removing redundant receipts check ([#5271](#5271)) ([5ab07fb](5ab07fb)) </details> <details><summary>aztec-packages: 0.29.0</summary> ## [0.29.0](aztec-packages-v0.28.1...aztec-packages-v0.29.0) (2024-03-18) ### ⚠ BREAKING CHANGES * Acir call opcode ([#4773](#4773)) ### Features * Acir call opcode ([#4773](#4773)) ([0b15db2](0b15db2)) * Add as_slice builtin function, add execution test (noir-lang/noir#4523) ([86e1a86](86e1a86)) * Add more impls on Option (noir-lang/noir#4549) ([86e1a86](86e1a86)) * Add RelWithAssert build ([#4997](#4997)) ([4f337c7](4f337c7)) * Allow usage of noir `#[test]` syntax in stdlib (noir-lang/noir#4553) ([86e1a86](86e1a86)) * **AuthWit:** Simplify create authwit syntax ([#5132](#5132)) ([d0a5b19](d0a5b19)) * **avm:** Brillig CONST of size > u128 ([#5217](#5217)) ([2e63479](2e63479)) * **avm:** Mov opcode with direct memory ([#5204](#5204)) ([08f9038](08f9038)), closes [#5159](#5159) * Brillig IR refactor ([#5233](#5233)) ([9a73348](9a73348)) * Check initializer msg.sender matches deployer from address preimage ([#5222](#5222)) ([438d16f](438d16f)) * Extended IPA tests and fuzzing ([#5140](#5140)) ([0ae5ace](0ae5ace)) * Initial Earthly CI ([#5069](#5069)) ([8e75fe5](8e75fe5)) * New Outbox Contract [#4768](#4768) ([#5090](#5090)) ([6421a3d](6421a3d)) * Remove curly braces with fmt (noir-lang/noir#4529) ([86e1a86](86e1a86)) * Remove curly braces with fmt (noir-lang/noir#4529) ([d8b8456](d8b8456)) * Remove unnecessary `mulmod`s from verifier contract ([#5269](#5269)) ([20d9c0c](20d9c0c)) * Signed integer division and modulus in brillig gen ([#5279](#5279)) ([82f8cf5](82f8cf5)) * Use deployer in address computation ([#5201](#5201)) ([258ff4a](258ff4a)) ### Bug Fixes * **avm-transpiler:** RETURN is direct ([#5277](#5277)) ([f90b2cf](f90b2cf)) * **bb:** Mac build ([#5253](#5253)) ([ae021c0](ae021c0)) * CVC5 api update ([#5203](#5203)) ([9cc32cb](9cc32cb)) * Evaluate operators in globals in types (noir-lang/noir#4537) ([86e1a86](86e1a86)) * Evaluate operators in globals in types (noir-lang/noir#4537) ([d8b8456](d8b8456)) * Make `nargo` the default binary for cargo run (noir-lang/noir#4554) ([86e1a86](86e1a86)) * Make `nargo` the default binary for cargo run (noir-lang/noir#4554) ([d8b8456](d8b8456)) * Revert "fix: noir mirror merge strat" ([#5250](#5250)) ([7e8e8e5](7e8e8e5)) * Validation requests ([#5236](#5236)) ([25ce33b](25ce33b)) ### Miscellaneous * Add avm team to codeowners for public context ([#5288](#5288)) ([e146076](e146076)) * Add more `Hash` impls to stdlib (noir-lang/noir#4470) ([86e1a86](86e1a86)) * Add more `Hash` impls to stdlib (noir-lang/noir#4470) ([d8b8456](d8b8456)) * Add quick explanatory comment to outbox suggested by [@benesjan](https://github.com/benesjan) ([#5247](#5247)) ([56e8451](56e8451)) * **avm-simulator:** Update e2e test ([#5283](#5283)) ([e9beeca](e9beeca)) * **avm-transpiler:** Return u8 in comparison ops ([#5280](#5280)) ([1a5eb69](1a5eb69)) * **avm-transpiler:** Transpiler cleanup ([#5218](#5218)) ([199e918](199e918)) * Delete ContractDao ([#5256](#5256)) ([544e278](544e278)) * Delete ContractData ([#5258](#5258)) ([e516f9b](e516f9b)) * Delete ExtendedContractData struct ([#5248](#5248)) ([8ae0c13](8ae0c13)) * Delete isInternal and isConstructor fields from FunctionData ([#5232](#5232)) ([dea3f87](dea3f87)) * Delete unused contract tree ts code ([#5229](#5229)) ([b48dd23](b48dd23)) * Delete unused hash functions ([#5231](#5231)) ([fed70a1](fed70a1)) * Fix docker test workflows (noir-lang/noir#4566) ([86e1a86](86e1a86)) * Fixing some broken links (noir-lang/noir#4556) ([86e1a86](86e1a86)) * Making docs build before cutting versions (noir-lang/noir#4568) ([86e1a86](86e1a86)) * Old inbox purge ([#5206](#5206)) ([a26d968](a26d968)) * Removing redundant receipts check ([#5271](#5271)) ([5ab07fb](5ab07fb)) * Separate tests for execution failures from compilation failures (noir-lang/noir#4559) ([86e1a86](86e1a86)) * Separate tests for execution failures from compilation failures (noir-lang/noir#4559) ([d8b8456](d8b8456)) * Template Zeromorph by PCS ([#5215](#5215)) ([03feab2](03feab2)) * Use inotifywait to run generate in yarn-project ([#5168](#5168)) ([137c13e](137c13e)) ### Documentation * **yp:** Remove contract tree and deploy data from circuits and state ([#5260](#5260)) ([acffa7b](acffa7b)) </details> <details><summary>barretenberg: 0.29.0</summary> ## [0.29.0](barretenberg-v0.28.1...barretenberg-v0.29.0) (2024-03-18) ### ⚠ BREAKING CHANGES * Acir call opcode ([#4773](#4773)) ### Features * Acir call opcode ([#4773](#4773)) ([0b15db2](0b15db2)) * Add RelWithAssert build ([#4997](#4997)) ([4f337c7](4f337c7)) * **avm:** Mov opcode with direct memory ([#5204](#5204)) ([08f9038](08f9038)), closes [#5159](#5159) * Extended IPA tests and fuzzing ([#5140](#5140)) ([0ae5ace](0ae5ace)) * Initial Earthly CI ([#5069](#5069)) ([8e75fe5](8e75fe5)) * Remove unnecessary `mulmod`s from verifier contract ([#5269](#5269)) ([20d9c0c](20d9c0c)) * Signed integer division and modulus in brillig gen ([#5279](#5279)) ([82f8cf5](82f8cf5)) ### Bug Fixes * **bb:** Mac build ([#5253](#5253)) ([ae021c0](ae021c0)) * CVC5 api update ([#5203](#5203)) ([9cc32cb](9cc32cb)) ### Miscellaneous * Template Zeromorph by PCS ([#5215](#5215)) ([03feab2](03feab2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@benesjan

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.29.0</summary> ## [0.29.0](AztecProtocol/aztec-packages@aztec-package-v0.28.1...aztec-package-v0.29.0) (2024-03-18) ### Features * Initial Earthly CI ([#5069](AztecProtocol/aztec-packages#5069)) ([8e75fe5](AztecProtocol/aztec-packages@8e75fe5)) </details> <details><summary>barretenberg.js: 0.29.0</summary> ## [0.29.0](AztecProtocol/aztec-packages@barretenberg.js-v0.28.1...barretenberg.js-v0.29.0) (2024-03-18) ### Features * Initial Earthly CI ([#5069](AztecProtocol/aztec-packages#5069)) ([8e75fe5](AztecProtocol/aztec-packages@8e75fe5)) </details> <details><summary>aztec-cli: 0.29.0</summary> ## [0.29.0](AztecProtocol/aztec-packages@aztec-cli-v0.28.1...aztec-cli-v0.29.0) (2024-03-18) ### Features * Use deployer in address computation ([#5201](AztecProtocol/aztec-packages#5201)) ([258ff4a](AztecProtocol/aztec-packages@258ff4a)) ### Miscellaneous * Delete ContractData ([#5258](AztecProtocol/aztec-packages#5258)) ([e516f9b](AztecProtocol/aztec-packages@e516f9b)) * Delete ExtendedContractData struct ([#5248](AztecProtocol/aztec-packages#5248)) ([8ae0c13](AztecProtocol/aztec-packages@8ae0c13)) * Removing redundant receipts check ([#5271](AztecProtocol/aztec-packages#5271)) ([5ab07fb](AztecProtocol/aztec-packages@5ab07fb)) </details> <details><summary>aztec-packages: 0.29.0</summary> ## [0.29.0](AztecProtocol/aztec-packages@aztec-packages-v0.28.1...aztec-packages-v0.29.0) (2024-03-18) ### ⚠ BREAKING CHANGES * Acir call opcode ([#4773](AztecProtocol/aztec-packages#4773)) ### Features * Acir call opcode ([#4773](AztecProtocol/aztec-packages#4773)) ([0b15db2](AztecProtocol/aztec-packages@0b15db2)) * Add as_slice builtin function, add execution test (noir-lang/noir#4523) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Add more impls on Option (noir-lang/noir#4549) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Add RelWithAssert build ([#4997](AztecProtocol/aztec-packages#4997)) ([4f337c7](AztecProtocol/aztec-packages@4f337c7)) * Allow usage of noir `#[test]` syntax in stdlib (noir-lang/noir#4553) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * **AuthWit:** Simplify create authwit syntax ([#5132](AztecProtocol/aztec-packages#5132)) ([d0a5b19](AztecProtocol/aztec-packages@d0a5b19)) * **avm:** Brillig CONST of size > u128 ([#5217](AztecProtocol/aztec-packages#5217)) ([2e63479](AztecProtocol/aztec-packages@2e63479)) * **avm:** Mov opcode with direct memory ([#5204](AztecProtocol/aztec-packages#5204)) ([08f9038](AztecProtocol/aztec-packages@08f9038)), closes [#5159](AztecProtocol/aztec-packages#5159) * Brillig IR refactor ([#5233](AztecProtocol/aztec-packages#5233)) ([9a73348](AztecProtocol/aztec-packages@9a73348)) * Check initializer msg.sender matches deployer from address preimage ([#5222](AztecProtocol/aztec-packages#5222)) ([438d16f](AztecProtocol/aztec-packages@438d16f)) * Extended IPA tests and fuzzing ([#5140](AztecProtocol/aztec-packages#5140)) ([0ae5ace](AztecProtocol/aztec-packages@0ae5ace)) * Initial Earthly CI ([#5069](AztecProtocol/aztec-packages#5069)) ([8e75fe5](AztecProtocol/aztec-packages@8e75fe5)) * New Outbox Contract [#4768](AztecProtocol/aztec-packages#4768) ([#5090](AztecProtocol/aztec-packages#5090)) ([6421a3d](AztecProtocol/aztec-packages@6421a3d)) * Remove curly braces with fmt (noir-lang/noir#4529) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Remove curly braces with fmt (noir-lang/noir#4529) ([d8b8456](AztecProtocol/aztec-packages@d8b8456)) * Remove unnecessary `mulmod`s from verifier contract ([#5269](AztecProtocol/aztec-packages#5269)) ([20d9c0c](AztecProtocol/aztec-packages@20d9c0c)) * Signed integer division and modulus in brillig gen ([#5279](AztecProtocol/aztec-packages#5279)) ([82f8cf5](AztecProtocol/aztec-packages@82f8cf5)) * Use deployer in address computation ([#5201](AztecProtocol/aztec-packages#5201)) ([258ff4a](AztecProtocol/aztec-packages@258ff4a)) ### Bug Fixes * **avm-transpiler:** RETURN is direct ([#5277](AztecProtocol/aztec-packages#5277)) ([f90b2cf](AztecProtocol/aztec-packages@f90b2cf)) * **bb:** Mac build ([#5253](AztecProtocol/aztec-packages#5253)) ([ae021c0](AztecProtocol/aztec-packages@ae021c0)) * CVC5 api update ([#5203](AztecProtocol/aztec-packages#5203)) ([9cc32cb](AztecProtocol/aztec-packages@9cc32cb)) * Evaluate operators in globals in types (noir-lang/noir#4537) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Evaluate operators in globals in types (noir-lang/noir#4537) ([d8b8456](AztecProtocol/aztec-packages@d8b8456)) * Make `nargo` the default binary for cargo run (noir-lang/noir#4554) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Make `nargo` the default binary for cargo run (noir-lang/noir#4554) ([d8b8456](AztecProtocol/aztec-packages@d8b8456)) * Revert "fix: noir mirror merge strat" ([#5250](AztecProtocol/aztec-packages#5250)) ([7e8e8e5](AztecProtocol/aztec-packages@7e8e8e5)) * Validation requests ([#5236](AztecProtocol/aztec-packages#5236)) ([25ce33b](AztecProtocol/aztec-packages@25ce33b)) ### Miscellaneous * Add avm team to codeowners for public context ([#5288](AztecProtocol/aztec-packages#5288)) ([e146076](AztecProtocol/aztec-packages@e146076)) * Add more `Hash` impls to stdlib (noir-lang/noir#4470) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Add more `Hash` impls to stdlib (noir-lang/noir#4470) ([d8b8456](AztecProtocol/aztec-packages@d8b8456)) * Add quick explanatory comment to outbox suggested by [@benesjan](https://github.com/benesjan) ([#5247](AztecProtocol/aztec-packages#5247)) ([56e8451](AztecProtocol/aztec-packages@56e8451)) * **avm-simulator:** Update e2e test ([#5283](AztecProtocol/aztec-packages#5283)) ([e9beeca](AztecProtocol/aztec-packages@e9beeca)) * **avm-transpiler:** Return u8 in comparison ops ([#5280](AztecProtocol/aztec-packages#5280)) ([1a5eb69](AztecProtocol/aztec-packages@1a5eb69)) * **avm-transpiler:** Transpiler cleanup ([#5218](AztecProtocol/aztec-packages#5218)) ([199e918](AztecProtocol/aztec-packages@199e918)) * Delete ContractDao ([#5256](AztecProtocol/aztec-packages#5256)) ([544e278](AztecProtocol/aztec-packages@544e278)) * Delete ContractData ([#5258](AztecProtocol/aztec-packages#5258)) ([e516f9b](AztecProtocol/aztec-packages@e516f9b)) * Delete ExtendedContractData struct ([#5248](AztecProtocol/aztec-packages#5248)) ([8ae0c13](AztecProtocol/aztec-packages@8ae0c13)) * Delete isInternal and isConstructor fields from FunctionData ([#5232](AztecProtocol/aztec-packages#5232)) ([dea3f87](AztecProtocol/aztec-packages@dea3f87)) * Delete unused contract tree ts code ([#5229](AztecProtocol/aztec-packages#5229)) ([b48dd23](AztecProtocol/aztec-packages@b48dd23)) * Delete unused hash functions ([#5231](AztecProtocol/aztec-packages#5231)) ([fed70a1](AztecProtocol/aztec-packages@fed70a1)) * Fix docker test workflows (noir-lang/noir#4566) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Fixing some broken links (noir-lang/noir#4556) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Making docs build before cutting versions (noir-lang/noir#4568) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Old inbox purge ([#5206](AztecProtocol/aztec-packages#5206)) ([a26d968](AztecProtocol/aztec-packages@a26d968)) * Removing redundant receipts check ([#5271](AztecProtocol/aztec-packages#5271)) ([5ab07fb](AztecProtocol/aztec-packages@5ab07fb)) * Separate tests for execution failures from compilation failures (noir-lang/noir#4559) ([86e1a86](AztecProtocol/aztec-packages@86e1a86)) * Separate tests for execution failures from compilation failures (noir-lang/noir#4559) ([d8b8456](AztecProtocol/aztec-packages@d8b8456)) * Template Zeromorph by PCS ([#5215](AztecProtocol/aztec-packages#5215)) ([03feab2](AztecProtocol/aztec-packages@03feab2)) * Use inotifywait to run generate in yarn-project ([#5168](AztecProtocol/aztec-packages#5168)) ([137c13e](AztecProtocol/aztec-packages@137c13e)) ### Documentation * **yp:** Remove contract tree and deploy data from circuits and state ([#5260](AztecProtocol/aztec-packages#5260)) ([acffa7b](AztecProtocol/aztec-packages@acffa7b)) </details> <details><summary>barretenberg: 0.29.0</summary> ## [0.29.0](AztecProtocol/aztec-packages@barretenberg-v0.28.1...barretenberg-v0.29.0) (2024-03-18) ### ⚠ BREAKING CHANGES * Acir call opcode ([#4773](AztecProtocol/aztec-packages#4773)) ### Features * Acir call opcode ([#4773](AztecProtocol/aztec-packages#4773)) ([0b15db2](AztecProtocol/aztec-packages@0b15db2)) * Add RelWithAssert build ([#4997](AztecProtocol/aztec-packages#4997)) ([4f337c7](AztecProtocol/aztec-packages@4f337c7)) * **avm:** Mov opcode with direct memory ([#5204](AztecProtocol/aztec-packages#5204)) ([08f9038](AztecProtocol/aztec-packages@08f9038)), closes [#5159](AztecProtocol/aztec-packages#5159) * Extended IPA tests and fuzzing ([#5140](AztecProtocol/aztec-packages#5140)) ([0ae5ace](AztecProtocol/aztec-packages@0ae5ace)) * Initial Earthly CI ([#5069](AztecProtocol/aztec-packages#5069)) ([8e75fe5](AztecProtocol/aztec-packages@8e75fe5)) * Remove unnecessary `mulmod`s from verifier contract ([#5269](AztecProtocol/aztec-packages#5269)) ([20d9c0c](AztecProtocol/aztec-packages@20d9c0c)) * Signed integer division and modulus in brillig gen ([#5279](AztecProtocol/aztec-packages#5279)) ([82f8cf5](AztecProtocol/aztec-packages@82f8cf5)) ### Bug Fixes * **bb:** Mac build ([#5253](AztecProtocol/aztec-packages#5253)) ([ae021c0](AztecProtocol/aztec-packages@ae021c0)) * CVC5 api update ([#5203](AztecProtocol/aztec-packages#5203)) ([9cc32cb](AztecProtocol/aztec-packages@9cc32cb)) ### Miscellaneous * Template Zeromorph by PCS ([#5215](AztecProtocol/aztec-packages#5215)) ([03feab2](AztecProtocol/aztec-packages@03feab2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This was referenced Mar 14, 2024

chore: Delete unused contract tree ts code #5229

Merged

chore: Delete unused hash functions #5231

Merged

spalladino force-pushed the palla/delete-unused-hash-fns branch from 850734c to b34f890 Compare March 14, 2024 23:14

spalladino force-pushed the palla/clean-up-function-data branch from b2f2c5b to 161eed6 Compare March 14, 2024 23:14

spalladino force-pushed the palla/delete-unused-hash-fns branch from b34f890 to af1bde4 Compare March 14, 2024 23:18

spalladino force-pushed the palla/clean-up-function-data branch from 161eed6 to 687576a Compare March 14, 2024 23:18

PhilWindle approved these changes Mar 15, 2024

View reviewed changes

spalladino force-pushed the palla/delete-unused-hash-fns branch from af1bde4 to d2f74f6 Compare March 15, 2024 12:16

spalladino force-pushed the palla/clean-up-function-data branch from 687576a to 3e9585d Compare March 15, 2024 12:16

spalladino force-pushed the palla/delete-unused-hash-fns branch from d2f74f6 to af97cbc Compare March 15, 2024 13:01

spalladino force-pushed the palla/clean-up-function-data branch from 3e9585d to 8610bca Compare March 15, 2024 13:01

Base automatically changed from palla/delete-unused-hash-fns to master March 15, 2024 13:28

spalladino force-pushed the palla/clean-up-function-data branch from 8610bca to 1b75e93 Compare March 15, 2024 13:28

chore: Delete isInternal and isConstructor fields from FunctionData

333a282

spalladino force-pushed the palla/clean-up-function-data branch from 1b75e93 to 333a282 Compare March 15, 2024 13:55

spalladino mentioned this pull request Mar 15, 2024

chore: Delete ExtendedContractData struct #5248

Merged

spalladino merged commit dea3f87 into master Mar 15, 2024
98 of 99 checks passed

spalladino deleted the palla/clean-up-function-data branch March 15, 2024 14:23

AztecBot mentioned this pull request Mar 15, 2024

chore(master): Release 0.29.0 #5235

Merged

This was referenced Mar 15, 2024

chore: Delete ContractDao #5256

Merged

chore: Delete ContractData #5258

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Delete isInternal and isConstructor fields from FunctionData #5232

chore: Delete isInternal and isConstructor fields from FunctionData #5232

spalladino commented Mar 14, 2024

spalladino commented Mar 14, 2024 •

edited

Loading

AztecBot commented Mar 14, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

github-actions bot commented Mar 14, 2024 •

edited

Loading

spalladino commented Mar 15, 2024 •

edited

Loading

chore: Delete isInternal and isConstructor fields from FunctionData #5232

chore: Delete isInternal and isConstructor fields from FunctionData #5232

Conversation

spalladino commented Mar 14, 2024

spalladino commented Mar 14, 2024 • edited Loading

AztecBot commented Mar 14, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

github-actions bot commented Mar 14, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

spalladino commented Mar 15, 2024 • edited Loading

Merge activity

spalladino commented Mar 14, 2024 •

edited

Loading

AztecBot commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

spalladino commented Mar 15, 2024 •

edited

Loading