Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimulateTx): public constrained view messy #5433

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

LHerskind
Copy link
Contributor

Please read contributing guidelines and remove this line.

Copy link
Contributor Author

LHerskind commented Mar 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite Graphite

@AztecBot
Copy link
Collaborator

AztecBot commented Mar 25, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 22922142 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,394 6,424 6,412
l1_rollup_execution_gas 585,727 585,757 585,745
l2_block_processing_time_in_ms 1,301 (-1%) 4,707 (-1%) 9,193 (-2%)
note_successful_decrypting_time_in_ms 184 522 (-1%) 983 (+3%)
note_trial_decrypting_time_in_ms 41.1 (-53%) 38.7 (-11%) 113 (+40%)
l2_block_building_time_in_ms 13,827 51,390 (+1%) 101,392 (+1%)
l2_block_rollup_simulation_time_in_ms 7,926 (-1%) 28,056 (-1%) 55,056 (+1%)
l2_block_public_tx_process_time_in_ms 5,879 (+3%) 23,282 (+2%) 46,239 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,068 27,239
note_history_successful_decrypting_time_in_ms 1,281 (+4%) 2,450 (-2%)
note_history_trial_decrypting_time_in_ms 107 (+6%) 118 (-28%)
node_database_size_in_bytes 18,649,168 35,029,072
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 233 (+2%) 44,378 28,214
private-kernel-ordering 206 (+2%) 52,880 14,296
base-parity 3,976 (+13%) 128 311
root-parity 1,445 (+12%) 1,244 311
base-rollup 17,117 (+5%) 165,760 861
root-rollup 50.0 (+1%) 4,359 725
private-kernel-inner 302 (+2%) 73,794 28,214
public-kernel-app-logic 124 (+3%) 35,251 28,217
public-kernel-tail 169 (+2%) 40,928 28,217
merge-rollup 9.13 (+11%) 2,568 861
public-kernel-teardown 120 (+3%) 35,252 28,217
public-kernel-setup 119 (+3%) 35,252 28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 16.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.584 0.494 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.8 72.5 (+1%) 232 445 (+1%) 872 (-1%) 1,730 (-6%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.480 0.447 (+1%) 0.422 0.417 (+1%) 0.415 (-1%) 0.413 (-6%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.3 107 (+1%) 341 (+1%) 661 (+2%) 1,316 2,616 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 (-1%) 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.480 0.482 (+1%) 0.463 (+1%) 0.455 (+2%) 0.455 0.455 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.5 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.537 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 14,967 495,185

Transaction size based on fee payment method

Metric none fee payment method native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 773 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 2,151 (+3%) 1,392 (+2%) 4,718
Metric 0 public data writes 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 11.5 (+10%) 721 (+3%) 528 1,447 (+1%) 585 (+1%) 2,543 (+2%) 673 (+1%)

@LHerskind LHerskind changed the title feat: public constrained view messy feat(SimulateTx): public constrained view messy Mar 26, 2024
@AztecBot
Copy link
Collaborator

Docs Preview

Hey there! 👋 You can check your preview at https://6604237a987f6d0d91c7b37b--aztec-docs-dev.netlify.app

@LHerskind LHerskind marked this pull request as ready for review March 27, 2024 13:54
@LHerskind LHerskind merged commit e082945 into lh/2665 Mar 27, 2024
131 checks passed
@LHerskind LHerskind deleted the lh/2665-public-messy branch March 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants