Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimulateTx): simulate constrained transaction execution with return values #5432

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Mar 25, 2024

This PR replaces the old view function with a simulate that can be executed on private, public and unconstrained functions.

It have a limitation in the format of the return values. Currently it is returning a size 4 array of Fields, as that is the return value that the artifact knows about.

It is to be fixed as part of #5450 that will get the proper values into the artifacts such that we can decode it nicely.


Why the name vue? I asked chatgpt for a short name that was not a real word, then realised later that there is a js library called vue 💀. Makes it easy to find and replace the naming.

Copy link
Contributor Author

LHerskind commented Mar 25, 2024

@AztecBot
Copy link
Collaborator

AztecBot commented Mar 25, 2024

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (private-kernel-init): 210 (+16%)
  • circuit_simulation_time_in_ms (private-kernel-inner): 269 (+20%)
  • l2_block_public_tx_process_time_in_ms (32): 21,859 (+18%)
  • note_successful_decrypting_time_in_ms (8): 204 (-31%)
  • note_trial_decrypting_time_in_ms (32): 73.2 (+123%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a5946836 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,406 6,418 6,418
l1_rollup_execution_gas 585,739 585,751 585,751
l2_block_processing_time_in_ms 1,303 4,721 9,051 (-3%)
note_successful_decrypting_time_in_ms ⚠️ 204 (-31%) 602 (-2%) 1,005 (-2%)
note_trial_decrypting_time_in_ms 61.0 (-39%) ⚠️ 73.2 (+123%) 78.0 (+40%)
l2_block_building_time_in_ms 12,991 (+7%) 48,926 (+11%) 94,489 (+8%)
l2_block_rollup_simulation_time_in_ms 7,675 (+4%) 27,016 (+5%) 52,637 (+4%)
l2_block_public_tx_process_time_in_ms 5,290 (+13%) ⚠️ 21,859 (+18%) 41,756 (+13%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,377 (+2%) 26,841 (-4%)
note_history_successful_decrypting_time_in_ms 1,261 (-9%) 2,404 (-1%)
note_history_trial_decrypting_time_in_ms 90.2 (-23%) 127 (-16%)
node_database_size_in_bytes 18,616,400 35,049,552
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init ⚠️ 210 (+16%) 44,378 28,214
private-kernel-ordering 190 (+12%) 52,880 14,296
base-parity 3,897 (+13%) 128 311
root-parity 1,411 (+9%) 1,244 311
base-rollup 16,367 (+9%) 165,760 861
root-rollup 50.7 (+2%) 4,359 725
private-kernel-inner ⚠️ 269 (+20%) 73,794 28,214
public-kernel-app-logic 111 (+17%) 35,251 28,217
public-kernel-tail 154 (+12%) 40,928 28,217
merge-rollup 8.13 (-7%) 2,568 861
public-kernel-teardown 90.0 (-3%) 35,252 28,217
public-kernel-setup 88.4 (-3%) 35,252 28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 16.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.584 0.496 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.2 (-1%) 71.6 231 (-1%) 446 (-1%) 863 (-1%) 1,690 (-2%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.474 (-1%) 0.441 0.419 (-2%) 0.417 (-1%) 0.410 (-1%) 0.404 (-2%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 55.0 (+1%) 106 334 662 (-1%) 1,296 2,580 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 (-1%) 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.487 (+1%) 0.477 (-1%) 0.453 (-1%) 0.455 (-1%) 0.448 (-1%) 0.449 (-2%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 60.9 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.532 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 14,967 495,185

Transaction size based on fee payment method

Metric none fee payment method native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 773 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,991 (+9%) 1,312 (+9%) 5,584 (-2%)
Metric 0 public data writes 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 12.2 (+11%) 659 (+14%) 436 (-2%) 1,154 (-1%) 580 (-3%) 1,968 (-3%) 565

@LHerskind LHerskind changed the title feat: 👀 private constrained messy feat(SimulateTx): private constrained messy Mar 26, 2024
@LHerskind LHerskind force-pushed the lh/2665 branch 3 times, most recently from 019358b to fde8549 Compare March 27, 2024 09:53
@AztecBot
Copy link
Collaborator

AztecBot commented Mar 27, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://660c8050b3751f39bb8a083d--aztec-docs-dev.netlify.app

@LHerskind LHerskind requested a review from benesjan March 27, 2024 14:02
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks good to me. Would thoroughly document the difference between prove and simulate but I assume you have that planned.

@LHerskind LHerskind changed the title feat(SimulateTx): private constrained messy feat(SimulateTx): simulate constrained transaction execution with return values Mar 27, 2024
@LHerskind LHerskind force-pushed the lh/2665 branch 2 times, most recently from ec533ef to 5ba8a79 Compare April 2, 2024 10:31
@LHerskind LHerskind marked this pull request as ready for review April 2, 2024 11:15
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely change. Feel free to merge once you address my nits.

@@ -15,6 +17,70 @@ import { EncryptedTxL2Logs, UnencryptedTxL2Logs } from '../logs/tx_l2_logs.js';
import { type TxStats } from '../stats/stats.js';
import { TxHash } from './tx_hash.js';

export class SimulatedTx {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to simulated_tx.ts? I find the codebase easier to navigate when types are in separate files which are consistently named.

}

#[aztec(public)]
fn get_shared_immutable_constrained() -> pub Leader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would call thisget_shared_immutable_constrained_public for the same reason as above.

}

#[aztec(public)]
fn get_shared_immutable_constrained_indirect() -> pub Leader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nicer if you called this function get_shared_immutable_constrained_public_indirect. It would make it clearer in the test that it's the public counterpart of the private version.

@@ -108,6 +108,34 @@ contract DocsExample {
assert(read.points == expected.points, "Invalid points");
}

#[aztec(private)]
fn get_shared_immutable_constrained_private_indirect() -> pub Leader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add here a comment describing what we are trying to achieve with this indirect function?

// TODO: It should instead return the correctly decoded value
// TODO: The return type here needs to be fixed! @LHerskind

if (this.functionDao.functionType == FunctionType.SECRET) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having FunctionType.SECRET for private functions is confusing and it made it harder to decode what's going on here. Do you know if there is some justification for why that is the case or if it's just a tech debt?

Copy link
Contributor Author

@LHerskind LHerskind Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just straight up horrible and old tech debt. Added #5538

await contract.methods.match_shared_immutable(c.account, c.points).send().wait();
});

it('public read of SharedImmutable', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add some comments here.

@@ -145,11 +145,12 @@ export interface PXE {
* @throws If the code for the functions executed in this transaction has not been made available via `addContracts`.
* Also throws if simulatePublic is true and public simulation reverts.
*/
simulateTx(txRequest: TxExecutionRequest, simulatePublic: boolean): Promise<Tx>;
proveTx(txRequest: TxExecutionRequest, simulatePublic: boolean): Promise<Tx>;
simulateTx(txRequest: TxExecutionRequest, simulatePublic: boolean, msgSender?: AztecAddress): Promise<SimulatedTx>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the documentation here as well. Having it in this interface seems like the most important place to have it.

} satisfies TxPXEProcessingStats);
const simulatedTx = await this.#simulateAndProve(txRequest, msgSender);
if (!msgSender) {
this.log(`Processed private part of ${simulatedTx.tx.getTxHash()}`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add here a comment about why we log this only when msg sender is undefined.

* The function takes in a transaction request and an ECDSA signature. It simulates the transaction,
* then generates a kernel proof using the simulation result. Finally, it creates a private
* The function takes in a transaction request, simulates it, and then generates a kernel proof
* using the simulation result. Finally, it creates a private
* transaction object with the generated proof and public inputs. If a new contract address is provided,
* the function will also include the new contract's public functions in the transaction object.
*
* @param txExecutionRequest - The transaction request to be simulated and proved.
* @param signature - The ECDSA signature for the transaction request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing msgSender here.


They are run with the assistance of a DB oracle that provides any private data requested by the function.

At the moment, unconstrained functions cannot call any other function. It would be possible to allow them to call other unconstrained functions.
At the moment, unconstrained functions cannot call any other function.
It would be possible to allow them to call other unconstrained functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create an issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might already be one, or that @Thunkar had looked at it already (might be hallucinating from meeting earlier).

But otherwise not sure if we really want to do it. Ideally we can mostly purge them from existence and then that effort seems wasted?

Copy link
Contributor

@sklppy88 sklppy88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, have a few nits as well. Very much agree with the points @benesjan has made above

@@ -17,6 +17,32 @@ This change was made to communicate that we do not constrain the value in circui
+ let random_value = unsafe_rand();
```

### [AztecJS] Simulate and get return values for ANY call
Historically it have been possible to "view" `unconstrained` functions to simulate them and get the return values, but not for `public` nor `private` functions.
This have lead to a lot of bad code where we have the same function implemented thrice, once in `private`, once in `public` and once in `unconstrained`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This have lead to a lot of bad code where we have the same function implemented thrice, once in `private`, once in `public` and once in `unconstrained`.
This has lead to a lot of bad code where we have the same function implemented thrice, once in `private`, once in `public` and once in `unconstrained`.

Historically it have been possible to "view" `unconstrained` functions to simulate them and get the return values, but not for `public` nor `private` functions.
This have lead to a lot of bad code where we have the same function implemented thrice, once in `private`, once in `public` and once in `unconstrained`.
It is not possible to call `simulate` on any call to get the return values!
However, beware that it currently always return a Field array of size 4 for private and public.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, beware that it currently always return a Field array of size 4 for private and public.
However, beware that it currently always returns a Field array of size 4 for private and public.

This have lead to a lot of bad code where we have the same function implemented thrice, once in `private`, once in `public` and once in `unconstrained`.
It is not possible to call `simulate` on any call to get the return values!
However, beware that it currently always return a Field array of size 4 for private and public.
This will change to become similar to the return values of the `unconstrained` with proper return times.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will change to become similar to the return values of the `unconstrained` with proper return times.
This will change to become similar to the return values of the `unconstrained` functions with proper return types.

authWitnesses: [],
});
const simulatedTx = await this.pxe.simulateTx(txRequest, false, options.from ?? this.wallet.getAddress());
return simulatedTx.privateReturnValues && simulatedTx.privateReturnValues[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we don't have it like this ?

Suggested change
return simulatedTx.privateReturnValues && simulatedTx.privateReturnValues[0];
return simulatedTx?.privateReturnValues?.[0];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not think about it 🤷

const txRequest = await this.create();
const simulatedTx = await this.pxe.simulateTx(txRequest, true);
this.txRequest = undefined;
return simulatedTx.publicReturnValues && simulatedTx.publicReturnValues[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@LHerskind LHerskind merged commit 0249737 into master Apr 3, 2024
150 of 156 checks passed
@LHerskind LHerskind deleted the lh/2665 branch April 3, 2024 09:17
rahul-kothari pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.33.0</summary>

##
[0.33.0](aztec-package-v0.32.1...aztec-package-v0.33.0)
(2024-04-09)


### Features

* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](#5432))
([0249737](0249737))
</details>

<details><summary>barretenberg.js: 0.33.0</summary>

##
[0.33.0](barretenberg.js-v0.32.1...barretenberg.js-v0.33.0)
(2024-04-09)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.33.0</summary>

##
[0.33.0](aztec-cli-v0.32.1...aztec-cli-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* contract_abi-exports
([#5386](#5386))

### Features

* **avm:** Integrate AVM with initializers
([#5469](#5469))
([59799f2](59799f2))
* Contract_abi-exports
([#5386](#5386))
([745d522](745d522))
* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))


### Bug Fixes

* Update CLI & terraforms with new contract addresses
([#5553](#5553))
([eb73d20](eb73d20))
</details>

<details><summary>aztec-packages: 0.33.0</summary>

##
[0.33.0](aztec-packages-v0.32.1...aztec-packages-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](#5616))
* contract_abi-exports
([#5386](#5386))
* **avm:** rollback FunctionAbi isTranspiled changes
([#5561](#5561))

### Features

* /foundry is canoncial build of foundry. e2e tests can start own anvil.
([#5522](#5522))
([510daa0](510daa0))
* `add` and `sub` methods of `EasyPrivateUint` throw when called in
public
([#5581](#5581))
([29f337d](29f337d))
* **acir:** Add predicate to call opcode
([#5616](#5616))
([e8cec0a](e8cec0a))
* **acvm_js:** Execute program
(noir-lang/noir#4694)
([8b30b95](8b30b95))
* Add return values to aztec fns
([#5389](#5389))
([7b88bac](7b88bac))
* Allow slices to brillig entry points
(noir-lang/noir#4713)
([8b30b95](8b30b95))
* Avm logup
([#5577](#5577))
([7e4e9b9](7e4e9b9))
* **avm:** Add index to pedersen opcode
([#5486](#5486))
([e1d7d11](e1d7d11))
* **avm:** Contract instance opcode
([#5487](#5487))
([ceacba6](ceacba6))
* **avm:** Gas usage for nested calls
([#5495](#5495))
([11699c8](11699c8))
* **avm:** Indirect memory for set opcode
([#5546](#5546))
([e0e7200](e0e7200)),
closes
[#5542](#5542)
* **avm:** Integrate AVM with initializers
([#5469](#5469))
([59799f2](59799f2))
* **avm:** Set gas allowance in public calls
([#5567](#5567))
([ee23415](ee23415))
* **avm:** Track gas from memory accesses explicitly
([#5563](#5563))
([18c9128](18c9128)),
closes
[#5514](#5514)
* Contract_abi-exports
([#5386](#5386))
([745d522](745d522))
* DataBus notion with calldata/return data
([#5504](#5504))
([95a1d8a](95a1d8a))
* DebugLog(...) in noir-protocol-circuits
([#5568](#5568))
([a07bb92](a07bb92))
* **docs:** Documenting noir codegen
(noir-lang/noir#4454)
([8b30b95](8b30b95))
* Improve nargo check cli with --override flag and feedback for existing
files (noir-lang/noir#4575)
([8b30b95](8b30b95))
* Improve optimisations on range constraints
(noir-lang/noir#4690)
([8b30b95](8b30b95))
* Improve SSA type-awareness in EQ and MUL instructions
(noir-lang/noir#4691)
([8b30b95](8b30b95))
* Improve the proving orchestration lifecycle
([#5535](#5535))
([4e4f843](4e4f843))
* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))
* Logging deployed contract address to help debug e2e account test
([#5571](#5571))
([1907473](1907473))
* Only export values from accumulated data
([#5604](#5604))
([a974ec8](a974ec8))
* Optimise relations
([#5552](#5552))
([a581e80](a581e80))
* Optimize auxiliary relations slightly
([#5517](#5517))
([30be431](30be431))
* Public inputs refactor
([#5500](#5500))
([6b9a538](6b9a538))
* Restore hashing args via slice for performance
([#5539](#5539))
([eb3acdf](eb3acdf))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](#5432))
([0249737](0249737))


### Bug Fixes

* **acvm:** Mark outputs of Opcode::Call solvable
(noir-lang/noir#4708)
([8b30b95](8b30b95))
* **avm:** Nullifier handling
([#5488](#5488))
([bc8211d](bc8211d))
* **ci:** Cache submodules in GA
([#5531](#5531))
([75f2cc6](75f2cc6))
* **ci:** Install fixed foundry version in CI
([#5582](#5582))
([46fdb37](46fdb37))
* Dependabot update
([#5547](#5547))
([f7e6cc8](f7e6cc8))
* E2e earthly status
([#5564](#5564))
([a5076ca](a5076ca))
* Field comparisons (noir-lang/noir#4704)
([8b30b95](8b30b95))
* Invalid fork terraform
([#5585](#5585))
([826353b](826353b))
* Last use analysis & make it an SSA pass
(noir-lang/noir#4686)
([8b30b95](8b30b95))
* Mainnet fork redeploys
([#5573](#5573))
([88e8b6d](88e8b6d))
* Remove EFS lifecycle rule
([#5587](#5587))
([eb66fc6](eb66fc6))
* **ssa:** Do not use get_value_max_num_bits when we want pure type
information (noir-lang/noir#4700)
([8b30b95](8b30b95))
* Taint fork file storage
([#5560](#5560))
([f144f3b](f144f3b))
* Unknown slice lengths coming from as_slice
(noir-lang/noir#4725)
([8b30b95](8b30b95))
* Update CLI & terraforms with new contract addresses
([#5553](#5553))
([eb73d20](eb73d20))


### Miscellaneous

* **avm:** Rollback FunctionAbi isTranspiled changes
([#5561](#5561))
([150932a](150932a))
* Check for references to private functions during path resolution
(noir-lang/noir#4622)
([8b30b95](8b30b95))
* **docs:** Add file to prove ownership for google search console
([#5554](#5554))
([dfa3998](dfa3998))
* **docs:** Fix indexed-merkle-tree docs images
([#4674](#4674))
([8fc29d5](8fc29d5))
* **docs:** Random updates
([#5281](#5281))
([b8c9273](b8c9273))
* ECCVM flavor depends on builder
([#5323](#5323))
([a594683](a594683))
* Fix clippy errors (noir-lang/noir#4684)
([8b30b95](8b30b95))
* Get rid of ECCVM composer
([#5562](#5562))
([43ed901](43ed901))
* Move e2e-avm-initializer test to e2e-avm-simulator
([#5570](#5570))
([d827705](d827705))
* Nuking accounts from e2e setup
([#5574](#5574))
([be6f843](be6f843)),
closes
[#5307](#5307)
* Nuking L2BlockContext
([#5569](#5569))
([1299190](1299190))
* Pad when needed and not sooner
([#5482](#5482))
([e928c33](e928c33)),
closes
[#5357](#5357)
* Remove conditional compilation around `acvm_js` package
(noir-lang/noir#4702)
([8b30b95](8b30b95))
* Remove debug log from watch.sh
([a9a349d](a9a349d))
* Remove last traces of nix
(noir-lang/noir#4679)
([8b30b95](8b30b95))
* Remove unused boolean return values from stores
([#5470](#5470))
([07794ee](07794ee))
* Remove unused env vars from `Cross.toml`
(noir-lang/noir#4717)
([8b30b95](8b30b95))
* Replace relative paths to noir-protocol-circuits
([51a1983](51a1983))
* Replace relative paths to noir-protocol-circuits
([a716270](a716270))
* Replace relative paths to noir-protocol-circuits
([6827014](6827014))
* Replace relative paths to noir-protocol-circuits
([356caf7](356caf7))
* Simplify how `acvm_backend.wasm` is embedded
(noir-lang/noir#4703)
([8b30b95](8b30b95))
* Simplify how blns is loaded into tests
(noir-lang/noir#4705)
([8b30b95](8b30b95))
* Update snapshot
([#5626](#5626))
([fb66426](fb66426))
* Use is_entry_point helper on RuntimeType
(noir-lang/noir#4678)
([8b30b95](8b30b95))


### Documentation

* Minor fixes in keys
([#5550](#5550))
([ea48ad3](ea48ad3))
* **spec:** Hashing and keys
([#5478](#5478))
([820ac8c](820ac8c))
* Update quickstart.md to use Docker daemon
([#5576](#5576))
([42b9827](42b9827))
</details>

<details><summary>barretenberg: 0.33.0</summary>

##
[0.33.0](barretenberg-v0.32.1...barretenberg-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](#5616))

### Features

* **acir:** Add predicate to call opcode
([#5616](#5616))
([e8cec0a](e8cec0a))
* Avm logup
([#5577](#5577))
([7e4e9b9](7e4e9b9))
* **avm:** Contract instance opcode
([#5487](#5487))
([ceacba6](ceacba6))
* **avm:** Indirect memory for set opcode
([#5546](#5546))
([e0e7200](e0e7200)),
closes
[#5542](#5542)
* DataBus notion with calldata/return data
([#5504](#5504))
([95a1d8a](95a1d8a))
* Optimise relations
([#5552](#5552))
([a581e80](a581e80))
* Optimize auxiliary relations slightly
([#5517](#5517))
([30be431](30be431))


### Miscellaneous

* ECCVM flavor depends on builder
([#5323](#5323))
([a594683](a594683))
* Get rid of ECCVM composer
([#5562](#5562))
([43ed901](43ed901))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Apr 10, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-package-v0.32.1...aztec-package-v0.33.0)
(2024-04-09)


### Features

* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](AztecProtocol/aztec-packages#5432))
([0249737](AztecProtocol/aztec-packages@0249737))
</details>

<details><summary>barretenberg.js: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@barretenberg.js-v0.32.1...barretenberg.js-v0.33.0)
(2024-04-09)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-cli-v0.32.1...aztec-cli-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))

### Features

* **avm:** Integrate AVM with initializers
([#5469](AztecProtocol/aztec-packages#5469))
([59799f2](AztecProtocol/aztec-packages@59799f2))
* Contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
([745d522](AztecProtocol/aztec-packages@745d522))
* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))


### Bug Fixes

* Update CLI & terraforms with new contract addresses
([#5553](AztecProtocol/aztec-packages#5553))
([eb73d20](AztecProtocol/aztec-packages@eb73d20))
</details>

<details><summary>aztec-packages: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-packages-v0.32.1...aztec-packages-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
* contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
* **avm:** rollback FunctionAbi isTranspiled changes
([#5561](AztecProtocol/aztec-packages#5561))

### Features

* /foundry is canoncial build of foundry. e2e tests can start own anvil.
([#5522](AztecProtocol/aztec-packages#5522))
([510daa0](AztecProtocol/aztec-packages@510daa0))
* `add` and `sub` methods of `EasyPrivateUint` throw when called in
public
([#5581](AztecProtocol/aztec-packages#5581))
([29f337d](AztecProtocol/aztec-packages@29f337d))
* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
([e8cec0a](AztecProtocol/aztec-packages@e8cec0a))
* **acvm_js:** Execute program
(noir-lang/noir#4694)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Add return values to aztec fns
([#5389](AztecProtocol/aztec-packages#5389))
([7b88bac](AztecProtocol/aztec-packages@7b88bac))
* Allow slices to brillig entry points
(noir-lang/noir#4713)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Avm logup
([#5577](AztecProtocol/aztec-packages#5577))
([7e4e9b9](AztecProtocol/aztec-packages@7e4e9b9))
* **avm:** Add index to pedersen opcode
([#5486](AztecProtocol/aztec-packages#5486))
([e1d7d11](AztecProtocol/aztec-packages@e1d7d11))
* **avm:** Contract instance opcode
([#5487](AztecProtocol/aztec-packages#5487))
([ceacba6](AztecProtocol/aztec-packages@ceacba6))
* **avm:** Gas usage for nested calls
([#5495](AztecProtocol/aztec-packages#5495))
([11699c8](AztecProtocol/aztec-packages@11699c8))
* **avm:** Indirect memory for set opcode
([#5546](AztecProtocol/aztec-packages#5546))
([e0e7200](AztecProtocol/aztec-packages@e0e7200)),
closes
[#5542](AztecProtocol/aztec-packages#5542)
* **avm:** Integrate AVM with initializers
([#5469](AztecProtocol/aztec-packages#5469))
([59799f2](AztecProtocol/aztec-packages@59799f2))
* **avm:** Set gas allowance in public calls
([#5567](AztecProtocol/aztec-packages#5567))
([ee23415](AztecProtocol/aztec-packages@ee23415))
* **avm:** Track gas from memory accesses explicitly
([#5563](AztecProtocol/aztec-packages#5563))
([18c9128](AztecProtocol/aztec-packages@18c9128)),
closes
[#5514](AztecProtocol/aztec-packages#5514)
* Contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
([745d522](AztecProtocol/aztec-packages@745d522))
* DataBus notion with calldata/return data
([#5504](AztecProtocol/aztec-packages#5504))
([95a1d8a](AztecProtocol/aztec-packages@95a1d8a))
* DebugLog(...) in noir-protocol-circuits
([#5568](AztecProtocol/aztec-packages#5568))
([a07bb92](AztecProtocol/aztec-packages@a07bb92))
* **docs:** Documenting noir codegen
(noir-lang/noir#4454)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve nargo check cli with --override flag and feedback for existing
files (noir-lang/noir#4575)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve optimisations on range constraints
(noir-lang/noir#4690)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve SSA type-awareness in EQ and MUL instructions
(noir-lang/noir#4691)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve the proving orchestration lifecycle
([#5535](AztecProtocol/aztec-packages#5535))
([4e4f843](AztecProtocol/aztec-packages@4e4f843))
* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))
* Logging deployed contract address to help debug e2e account test
([#5571](AztecProtocol/aztec-packages#5571))
([1907473](AztecProtocol/aztec-packages@1907473))
* Only export values from accumulated data
([#5604](AztecProtocol/aztec-packages#5604))
([a974ec8](AztecProtocol/aztec-packages@a974ec8))
* Optimise relations
([#5552](AztecProtocol/aztec-packages#5552))
([a581e80](AztecProtocol/aztec-packages@a581e80))
* Optimize auxiliary relations slightly
([#5517](AztecProtocol/aztec-packages#5517))
([30be431](AztecProtocol/aztec-packages@30be431))
* Public inputs refactor
([#5500](AztecProtocol/aztec-packages#5500))
([6b9a538](AztecProtocol/aztec-packages@6b9a538))
* Restore hashing args via slice for performance
([#5539](AztecProtocol/aztec-packages#5539))
([eb3acdf](AztecProtocol/aztec-packages@eb3acdf))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](AztecProtocol/aztec-packages#5432))
([0249737](AztecProtocol/aztec-packages@0249737))


### Bug Fixes

* **acvm:** Mark outputs of Opcode::Call solvable
(noir-lang/noir#4708)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* **avm:** Nullifier handling
([#5488](AztecProtocol/aztec-packages#5488))
([bc8211d](AztecProtocol/aztec-packages@bc8211d))
* **ci:** Cache submodules in GA
([#5531](AztecProtocol/aztec-packages#5531))
([75f2cc6](AztecProtocol/aztec-packages@75f2cc6))
* **ci:** Install fixed foundry version in CI
([#5582](AztecProtocol/aztec-packages#5582))
([46fdb37](AztecProtocol/aztec-packages@46fdb37))
* Dependabot update
([#5547](AztecProtocol/aztec-packages#5547))
([f7e6cc8](AztecProtocol/aztec-packages@f7e6cc8))
* E2e earthly status
([#5564](AztecProtocol/aztec-packages#5564))
([a5076ca](AztecProtocol/aztec-packages@a5076ca))
* Field comparisons (noir-lang/noir#4704)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Invalid fork terraform
([#5585](AztecProtocol/aztec-packages#5585))
([826353b](AztecProtocol/aztec-packages@826353b))
* Last use analysis & make it an SSA pass
(noir-lang/noir#4686)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Mainnet fork redeploys
([#5573](AztecProtocol/aztec-packages#5573))
([88e8b6d](AztecProtocol/aztec-packages@88e8b6d))
* Remove EFS lifecycle rule
([#5587](AztecProtocol/aztec-packages#5587))
([eb66fc6](AztecProtocol/aztec-packages@eb66fc6))
* **ssa:** Do not use get_value_max_num_bits when we want pure type
information (noir-lang/noir#4700)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Taint fork file storage
([#5560](AztecProtocol/aztec-packages#5560))
([f144f3b](AztecProtocol/aztec-packages@f144f3b))
* Unknown slice lengths coming from as_slice
(noir-lang/noir#4725)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Update CLI & terraforms with new contract addresses
([#5553](AztecProtocol/aztec-packages#5553))
([eb73d20](AztecProtocol/aztec-packages@eb73d20))


### Miscellaneous

* **avm:** Rollback FunctionAbi isTranspiled changes
([#5561](AztecProtocol/aztec-packages#5561))
([150932a](AztecProtocol/aztec-packages@150932a))
* Check for references to private functions during path resolution
(noir-lang/noir#4622)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* **docs:** Add file to prove ownership for google search console
([#5554](AztecProtocol/aztec-packages#5554))
([dfa3998](AztecProtocol/aztec-packages@dfa3998))
* **docs:** Fix indexed-merkle-tree docs images
([#4674](AztecProtocol/aztec-packages#4674))
([8fc29d5](AztecProtocol/aztec-packages@8fc29d5))
* **docs:** Random updates
([#5281](AztecProtocol/aztec-packages#5281))
([b8c9273](AztecProtocol/aztec-packages@b8c9273))
* ECCVM flavor depends on builder
([#5323](AztecProtocol/aztec-packages#5323))
([a594683](AztecProtocol/aztec-packages@a594683))
* Fix clippy errors (noir-lang/noir#4684)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Get rid of ECCVM composer
([#5562](AztecProtocol/aztec-packages#5562))
([43ed901](AztecProtocol/aztec-packages@43ed901))
* Move e2e-avm-initializer test to e2e-avm-simulator
([#5570](AztecProtocol/aztec-packages#5570))
([d827705](AztecProtocol/aztec-packages@d827705))
* Nuking accounts from e2e setup
([#5574](AztecProtocol/aztec-packages#5574))
([be6f843](AztecProtocol/aztec-packages@be6f843)),
closes
[#5307](AztecProtocol/aztec-packages#5307)
* Nuking L2BlockContext
([#5569](AztecProtocol/aztec-packages#5569))
([1299190](AztecProtocol/aztec-packages@1299190))
* Pad when needed and not sooner
([#5482](AztecProtocol/aztec-packages#5482))
([e928c33](AztecProtocol/aztec-packages@e928c33)),
closes
[#5357](AztecProtocol/aztec-packages#5357)
* Remove conditional compilation around `acvm_js` package
(noir-lang/noir#4702)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Remove debug log from watch.sh
([a9a349d](AztecProtocol/aztec-packages@a9a349d))
* Remove last traces of nix
(noir-lang/noir#4679)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Remove unused boolean return values from stores
([#5470](AztecProtocol/aztec-packages#5470))
([07794ee](AztecProtocol/aztec-packages@07794ee))
* Remove unused env vars from `Cross.toml`
(noir-lang/noir#4717)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Replace relative paths to noir-protocol-circuits
([51a1983](AztecProtocol/aztec-packages@51a1983))
* Replace relative paths to noir-protocol-circuits
([a716270](AztecProtocol/aztec-packages@a716270))
* Replace relative paths to noir-protocol-circuits
([6827014](AztecProtocol/aztec-packages@6827014))
* Replace relative paths to noir-protocol-circuits
([356caf7](AztecProtocol/aztec-packages@356caf7))
* Simplify how `acvm_backend.wasm` is embedded
(noir-lang/noir#4703)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Simplify how blns is loaded into tests
(noir-lang/noir#4705)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Update snapshot
([#5626](AztecProtocol/aztec-packages#5626))
([fb66426](AztecProtocol/aztec-packages@fb66426))
* Use is_entry_point helper on RuntimeType
(noir-lang/noir#4678)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))


### Documentation

* Minor fixes in keys
([#5550](AztecProtocol/aztec-packages#5550))
([ea48ad3](AztecProtocol/aztec-packages@ea48ad3))
* **spec:** Hashing and keys
([#5478](AztecProtocol/aztec-packages#5478))
([820ac8c](AztecProtocol/aztec-packages@820ac8c))
* Update quickstart.md to use Docker daemon
([#5576](AztecProtocol/aztec-packages#5576))
([42b9827](AztecProtocol/aztec-packages@42b9827))
</details>

<details><summary>barretenberg: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@barretenberg-v0.32.1...barretenberg-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))

### Features

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
([e8cec0a](AztecProtocol/aztec-packages@e8cec0a))
* Avm logup
([#5577](AztecProtocol/aztec-packages#5577))
([7e4e9b9](AztecProtocol/aztec-packages@7e4e9b9))
* **avm:** Contract instance opcode
([#5487](AztecProtocol/aztec-packages#5487))
([ceacba6](AztecProtocol/aztec-packages@ceacba6))
* **avm:** Indirect memory for set opcode
([#5546](AztecProtocol/aztec-packages#5546))
([e0e7200](AztecProtocol/aztec-packages@e0e7200)),
closes
[#5542](AztecProtocol/aztec-packages#5542)
* DataBus notion with calldata/return data
([#5504](AztecProtocol/aztec-packages#5504))
([95a1d8a](AztecProtocol/aztec-packages@95a1d8a))
* Optimise relations
([#5552](AztecProtocol/aztec-packages#5552))
([a581e80](AztecProtocol/aztec-packages@a581e80))
* Optimize auxiliary relations slightly
([#5517](AztecProtocol/aztec-packages#5517))
([30be431](AztecProtocol/aztec-packages@30be431))


### Miscellaneous

* ECCVM flavor depends on builder
([#5323](AztecProtocol/aztec-packages#5323))
([a594683](AztecProtocol/aztec-packages@a594683))
* Get rid of ECCVM composer
([#5562](AztecProtocol/aztec-packages#5562))
([43ed901](AztecProtocol/aztec-packages@43ed901))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
ludamad pushed a commit that referenced this pull request Apr 11, 2024
This should fix the failures introduced by #5490. These were a bit of an
unforntunate coincidence,
#5500 changed the
underlying kernel data structures, and
#5432 changed what
`simulate` does: both would've caused issues, but because `simulate`'s
return type is `any` this went unnoticed until execution.

I also added the new job to the earthly setup, still looking into why
the old PR was merged despite failing.

---------

Co-authored-by: Charlie Lye <karl.lye@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants