feat(avm): Track gas from memory accesses explicitly

[spalladino]

Tracks gas usage for all AVM instructions based on memory consumption. Adds an optional wrapper for TaggedMemory (enabled on test only) that tracks all memory reads and writes to validate that the number of memory operations charged match the actual ones.

Replaces existing #5514 and #5518 in favor of a more explicit approach, at the expense of more duplicated code in each instruction, but flattening the instruction hierarchy.

Closes #5518
Closes #5514

[spalladino]

• feat(avm): Set gas allowance in public calls #5567
• feat(avm): Track gas from memory accesses explicitly #5563 👈
• feat(avm): Gas usage for nested calls #5495 : 1 other dependent PR (#5514 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 39.3 (+318%)
• note_trial_decrypting_time_in_ms (32): 70.8 (+276%)
• note_trial_decrypting_time_in_ms (64): 116 (+90%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d827705f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,424	6,424
l1_rollup_execution_gas	585,745	585,757	585,757
l2_block_processing_time_in_ms	1,306	4,774 (-1%)	9,442
note_successful_decrypting_time_in_ms	238 (+14%)	560 (-9%)	997 (+6%)
note_trial_decrypting_time_in_ms	⚠️ 39.3 (+318%)	⚠️ 70.8 (+276%)	⚠️ 116 (+90%)
l2_block_building_time_in_ms	11,967	43,633 (+1%)	85,349 (+1%)
l2_block_rollup_simulation_time_in_ms	7,149	24,724 (+2%)	47,614 (+1%)
l2_block_public_tx_process_time_in_ms	4,778	18,785 (+1%)	37,487

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,479 (-5%)	27,672 (+1%)
note_history_successful_decrypting_time_in_ms	1,299 (+5%)	2,317 (-1%)
note_history_trial_decrypting_time_in_ms	70.8 (-4%)	86.2 (+3%)
node_database_size_in_bytes	18,645,072	35,016,784
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	182 (+1%)	44,377	26,164
private-kernel-ordering	164 (+1%)	50,830	39,325
base-parity	4,194 (-1%)	128	311
root-parity	1,207 (+6%)	1,244	311
base-rollup	14,522 (+1%)	116,608	861
root-rollup	50.0 (-2%)	4,359	725
private-kernel-inner	221 (+1%)	71,744	26,164
public-kernel-app-logic	122 (+2%)	47,695	40,661
public-kernel-tail	166 (+1%)	53,372	13,269
merge-rollup	10.3 (-1%)	2,568	861
public-kernel-teardown	116 (-1%)	47,695	40,661
public-kernel-setup	116	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	16.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583	0.494	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.0	72.6 (+1%)	232	447 (+2%)	879	1,733 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471	0.447 (+1%)	0.423	0.417 (+2%)	0.416	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.4 (+1%)	107	341	659 (+1%)	1,319 (+1%)	2,633 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480 (+1%)	0.483	0.461 (-1%)	0.454 (+1%)	0.456 (+1%)	0.456 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.5 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,548	501,142

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,708 (-2%)	1,096 (+1%)	5,310 (-2%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	586 (+1%)	427 (-2%)	1,068	528	1,743	585