Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abort ongoing proving jobs #6049

Merged
merged 1 commit into from
May 2, 2024

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Apr 26, 2024

Pass an AbortSignal to circuit provers to notify of job cancellation

Copy link
Contributor Author

alexghr commented Apr 26, 2024

@AztecBot
Copy link
Collaborator

AztecBot commented Apr 26, 2024

Benchmark results

Metrics with a significant change:

  • tx_pxe_processing_time_ms (0): 1,483 (-16%)
  • batch_insert_into_append_only_tree_32_depth_ms (512): 256 (-26%)
  • batch_insert_into_indexed_tree_20_depth_ms (512): 366 (-16%)
  • tx_sequencer_processing_time_ms (8): 1,209 (-21%)
  • node_history_sync_time_in_ms (10): 31,973 (+18%)
  • l2_block_public_tx_process_time_in_ms (8): 9,240 (-16%)
  • l2_block_processing_time_in_ms (8): 1,338 (-20%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 740 740 740
l1_rollup_calldata_gas 6,668 6,680 6,668
l1_rollup_execution_gas 586,800 586,812 586,800
l2_block_processing_time_in_ms ⚠️ 1,338 (-20%) 4,949 (-5%) 9,916 (+1%)
l2_block_building_time_in_ms 22,009 (-15%) 85,242 (-5%) 169,492
l2_block_rollup_simulation_time_in_ms 21,802 (-15%) 84,503 (-5%) 168,012
l2_block_public_tx_process_time_in_ms ⚠️ 9,240 (-16%) 35,005 (-8%) 70,539

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,947 (+1%) ⚠️ 31,973 (+18%)
node_database_size_in_bytes 20,762,704 37,617,744 (+1%)
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 179 (-6%) 46,819 28,822
private-kernel-inner 212 (-7%) 76,734 28,822
private-kernel-ordering 234 (-6%) 53,040 42,751
base-parity 72.0 (-11%) 128 64.0
base-rollup 14,982 (+3%) 111,062 925
root-parity 1,654 (-2%) 27,064 64.0
root-rollup 68.8 (-10%) 11,454 789
public-kernel-app-logic 2,058 (+2%) 54,321 22,677
public-kernel-tail 5,032 (+2%) 159,770 3,898
merge-rollup 5,490 (+3%) 2,696 925
public-kernel-teardown 164 (-5%) 54,321 30,042
public-kernel-setup 231 (+1%) 54,321 30,042

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.8 (+3%) 18.9 (-4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.685 (+2%) 0.579 (-4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 53.8 (-1%) 82.0 ⚠️ 256 (-26%) 553 (+14%) 961 (-3%) 1,917 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.548 (-1%) 0.506 0.464 (-27%) 0.514 (+13%) 0.456 (-3%) 0.458 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 63.0 (-1%) 123 (-3%) ⚠️ 366 (-16%) 800 (+12%) 1,432 (-7%) 2,910 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.553 (-1%) 0.549 (-3%) 0.499 (-16%) 0.547 (+11%) 0.496 (-7%) 0.506 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 70.2 (+4%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.615 (+3%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 44,613 535,433

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms ⚠️ 1,483 (-16%) 1,036 (-6%) 4,138 (-1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 938 (+3%) 915 (-10%) 1,519 (-4%) 1,095 (-11%) 2,480 (-6%) ⚠️ 1,209 (-21%)

@alexghr alexghr force-pushed the 04-24-feat_configure_prover_as_separate_process branch from a97ea4e to 4c0ced9 Compare April 26, 2024 14:02
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch from e5fe19d to 28e2291 Compare April 26, 2024 14:02
@alexghr alexghr force-pushed the 04-24-feat_configure_prover_as_separate_process branch from 4c0ced9 to ba3f1ab Compare April 26, 2024 16:15
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch from 28e2291 to 1f5f02b Compare April 26, 2024 16:15
// We use a 'safeJob'. We don't want promise rejections in the proving pool, we want to capture the error here
// and reject the proving job whilst keeping the event loop free of rejections
const safeJob = async () => {
try {
// there's a delay between enqueueing this job and it actually running
if (controller.signal.aborted) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some debug logs when we drop jobs due to an abort signal.

private enqueue<T extends ProvingRequest>(
request: T,
signal?: AbortSignal,
): Promise<ProvingRequestResult<T['type']>> {
const { promise, resolve, reject } = promiseWithResolvers<ProvingRequestResult<T['type']>>();
const item: ProvingJobWithResolvers<T> = {
id: String(this.jobId++),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise it's not part of this PR, but I wonder if this should be a random string rather than an up-count.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in #6084

@alexghr alexghr force-pushed the 04-24-feat_configure_prover_as_separate_process branch from c018812 to 7bd3d27 Compare April 29, 2024 13:27
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch from 1f5f02b to 271fd17 Compare April 29, 2024 13:27
Base automatically changed from 04-24-feat_configure_prover_as_separate_process to master April 29, 2024 15:01
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch 2 times, most recently from 6e7fc1d to 616e250 Compare April 29, 2024 15:21
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch from 616e250 to 885cda7 Compare May 1, 2024 05:15
@PhilWindle PhilWindle enabled auto-merge (squash) May 1, 2024 09:16
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch 2 times, most recently from 0365a59 to 5e3efb8 Compare May 2, 2024 06:10
@alexghr alexghr force-pushed the 04-25-feat_abort_ongoing_proving_jobs branch from 5e3efb8 to 66335f1 Compare May 2, 2024 06:48
@PhilWindle PhilWindle merged commit 0aa352d into master May 2, 2024
66 of 67 checks passed
@PhilWindle PhilWindle deleted the 04-25-feat_abort_ongoing_proving_jobs branch May 2, 2024 08:08
rahul-kothari pushed a commit that referenced this pull request May 2, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.37.0</summary>

##
[0.37.0](aztec-package-v0.36.0...aztec-package-v0.37.0)
(2024-05-02)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.37.0</summary>

##
[0.37.0](barretenberg.js-v0.36.0...barretenberg.js-v0.37.0)
(2024-05-02)


### Features

* Devbox
([#5772](#5772))
([72321f9](72321f9))
</details>

<details><summary>aztec-packages: 0.37.0</summary>

##
[0.37.0](aztec-packages-v0.36.0...aztec-packages-v0.37.0)
(2024-05-02)


### ⚠ BREAKING CHANGES

* use `distinct` return value witnesses by default
(noir-lang/noir#4951)
* Bit shift is restricted to u8 right operand
(noir-lang/noir#4907)

### Features

* Abort ongoing proving jobs
([#6049](#6049))
([0aa352d](0aa352d))
* Add aztecprotocol/aztec-builder
([#6116](#6116))
([30899d0](30899d0))
* Add de-sugaring for `impl Trait` in function parameters
(noir-lang/noir#4919)
([f060fa6](f060fa6))
* Aztec nr lib constraining nullifier key is fresh
([#5939](#5939))
([f95de6b](f95de6b))
* Bit shift is restricted to u8 right operand
(noir-lang/noir#4907)
([f060fa6](f060fa6))
* Count Bb lines weighted by complexity
([#6090](#6090))
([705177f](705177f))
* Devbox
([#5772](#5772))
([72321f9](72321f9))
* Enforce gas limits from private kernels
([#6105](#6105))
([4395855](4395855))
* **experimental:** `comptime` globals
(noir-lang/noir#4918)
([f060fa6](f060fa6))
* Handle `no_predicates` attribute
(noir-lang/noir#4942)
([4dc5efb](4dc5efb))
* Migrate boxes to GA and Earthly
([#6076](#6076))
([4a49f9d](4a49f9d))
* Pippenger benchmarks compatible with wasmtime
([#6095](#6095))
([5297b5b](5297b5b))
* Private da gas metering
([#6103](#6103))
([1a8f372](1a8f372))
* Prover metrics
([#6050](#6050))
([5b133f2](5b133f2))
* Use `distinct` return value witnesses by default
(noir-lang/noir#4951)
([4dc5efb](4dc5efb))


### Bug Fixes

* Ban self-referential structs
(noir-lang/noir#4883)
([f060fa6](f060fa6))
* **ci:** Build-key hotfix
([#6123](#6123))
([5791004](5791004))
* **ci:** Ssh'ing into instances
([#6136](#6136))
([af3192d](af3192d))
* Discard ref counts during unrolling
(noir-lang/noir#4923)
([f060fa6](f060fa6))
* **docs:** Add codegen to `aztec-builder` command
([#6098](#6098))
([4839ed9](4839ed9))
* Ensure where clauses propagated to trait default definitions
(noir-lang/noir#4894)
([4dc5efb](4dc5efb))
* Require for all foldable functions to use distinct return
(noir-lang/noir#4949)
([4dc5efb](4dc5efb))


### Miscellaneous

* Add regression test for
[#3051](#3051)
(noir-lang/noir#4815)
([f060fa6](f060fa6))
* Add test for recursing a foldable function
(noir-lang/noir#4948)
([4dc5efb](4dc5efb))
* Adding devcontainer with create aztec app
([#5960](#5960))
([ae5cb21](ae5cb21))
* Build docs in earthly
([#6038](#6038))
([784d542](784d542))
* Bump bench-tx-size timeout
([#6109](#6109))
([aa3eefa](aa3eefa))
* **ci:** Fix spot runner build key
([#6119](#6119))
([f332bc9](f332bc9))
* **ci:** Hotfix
([#6124](#6124))
([f60dfcd](f60dfcd))
* **ci:** Run benchmarks on Earthly
([#6089](#6089))
([c985c73](c985c73))
* **ci:** Turn off ARM build for now
([#6135](#6135))
([853913f](853913f))
* Disable bench-summary for now
([67485f1](67485f1))
* Disable doc builds
([#6107](#6107))
([7933f0f](7933f0f))
* **docs:** Adding matomo tracking
(noir-lang/noir#4898)
([4dc5efb](4dc5efb))
* Ebs attach robustness
([#6108](#6108))
([c702688](c702688))
* Fix typo in `ResolverError::AbiAttributeOutsideContract`
(noir-lang/noir#4933)
([4dc5efb](4dc5efb))
* Migrate the prover client test to earthly
([#6118](#6118))
([a59a6c0](a59a6c0))
* Redo typo PR by stayweek
([#6080](#6080))
([0869452](0869452))
* Redo typo PR by vitalmotif
([#6081](#6081))
([1a89d1a](1a89d1a))
* Refactor nested contract test for speed
([#6117](#6117))
([b346a2f](b346a2f))
* Remove unnecessary `pub(super)` in interpreter
(noir-lang/noir#4939)
([4dc5efb](4dc5efb))
* Replace relative paths to noir-protocol-circuits
([47592a2](47592a2))
* Replace relative paths to noir-protocol-circuits
([f0d95f5](f0d95f5))
* Update error conversion traits to act on references
(noir-lang/noir#4936)
([f060fa6](f060fa6))


### Documentation

* Tweaks for release
([#6129](#6129))
([77b45b9](77b45b9))
* Update @aztec/builder readme
([#6115](#6115))
([248761e](248761e))
* Yellow paper updates for the parity circuits
([#6048](#6048))
([cfe1b05](cfe1b05))
</details>

<details><summary>barretenberg: 0.37.0</summary>

##
[0.37.0](barretenberg-v0.36.0...barretenberg-v0.37.0)
(2024-05-02)


### ⚠ BREAKING CHANGES

* use `distinct` return value witnesses by default
(noir-lang/noir#4951)

### Features

* Count Bb lines weighted by complexity
([#6090](#6090))
([705177f](705177f))
* Devbox
([#5772](#5772))
([72321f9](72321f9))
* Handle `no_predicates` attribute
(noir-lang/noir#4942)
([4dc5efb](4dc5efb))
* Pippenger benchmarks compatible with wasmtime
([#6095](#6095))
([5297b5b](5297b5b))
* Use `distinct` return value witnesses by default
(noir-lang/noir#4951)
([4dc5efb](4dc5efb))


### Bug Fixes

* Ensure where clauses propagated to trait default definitions
(noir-lang/noir#4894)
([4dc5efb](4dc5efb))
* Require for all foldable functions to use distinct return
(noir-lang/noir#4949)
([4dc5efb](4dc5efb))


### Miscellaneous

* Add test for recursing a foldable function
(noir-lang/noir#4948)
([4dc5efb](4dc5efb))
* **docs:** Adding matomo tracking
(noir-lang/noir#4898)
([4dc5efb](4dc5efb))
* Fix typo in `ResolverError::AbiAttributeOutsideContract`
(noir-lang/noir#4933)
([4dc5efb](4dc5efb))
* Redo typo PR by stayweek
([#6080](#6080))
([0869452](0869452))
* Remove unnecessary `pub(super)` in interpreter
(noir-lang/noir#4939)
([4dc5efb](4dc5efb))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request May 3, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.37.0</summary>

##
[0.37.0](AztecProtocol/aztec-packages@aztec-package-v0.36.0...aztec-package-v0.37.0)
(2024-05-02)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.37.0</summary>

##
[0.37.0](AztecProtocol/aztec-packages@barretenberg.js-v0.36.0...barretenberg.js-v0.37.0)
(2024-05-02)


### Features

* Devbox
([#5772](AztecProtocol/aztec-packages#5772))
([72321f9](AztecProtocol/aztec-packages@72321f9))
</details>

<details><summary>aztec-packages: 0.37.0</summary>

##
[0.37.0](AztecProtocol/aztec-packages@aztec-packages-v0.36.0...aztec-packages-v0.37.0)
(2024-05-02)


### ⚠ BREAKING CHANGES

* use `distinct` return value witnesses by default
(noir-lang/noir#4951)
* Bit shift is restricted to u8 right operand
(noir-lang/noir#4907)

### Features

* Abort ongoing proving jobs
([#6049](AztecProtocol/aztec-packages#6049))
([0aa352d](AztecProtocol/aztec-packages@0aa352d))
* Add aztecprotocol/aztec-builder
([#6116](AztecProtocol/aztec-packages#6116))
([30899d0](AztecProtocol/aztec-packages@30899d0))
* Add de-sugaring for `impl Trait` in function parameters
(noir-lang/noir#4919)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* Aztec nr lib constraining nullifier key is fresh
([#5939](AztecProtocol/aztec-packages#5939))
([f95de6b](AztecProtocol/aztec-packages@f95de6b))
* Bit shift is restricted to u8 right operand
(noir-lang/noir#4907)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* Count Bb lines weighted by complexity
([#6090](AztecProtocol/aztec-packages#6090))
([705177f](AztecProtocol/aztec-packages@705177f))
* Devbox
([#5772](AztecProtocol/aztec-packages#5772))
([72321f9](AztecProtocol/aztec-packages@72321f9))
* Enforce gas limits from private kernels
([#6105](AztecProtocol/aztec-packages#6105))
([4395855](AztecProtocol/aztec-packages@4395855))
* **experimental:** `comptime` globals
(noir-lang/noir#4918)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* Handle `no_predicates` attribute
(noir-lang/noir#4942)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Migrate boxes to GA and Earthly
([#6076](AztecProtocol/aztec-packages#6076))
([4a49f9d](AztecProtocol/aztec-packages@4a49f9d))
* Pippenger benchmarks compatible with wasmtime
([#6095](AztecProtocol/aztec-packages#6095))
([5297b5b](AztecProtocol/aztec-packages@5297b5b))
* Private da gas metering
([#6103](AztecProtocol/aztec-packages#6103))
([1a8f372](AztecProtocol/aztec-packages@1a8f372))
* Prover metrics
([#6050](AztecProtocol/aztec-packages#6050))
([5b133f2](AztecProtocol/aztec-packages@5b133f2))
* Use `distinct` return value witnesses by default
(noir-lang/noir#4951)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))


### Bug Fixes

* Ban self-referential structs
(noir-lang/noir#4883)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* **ci:** Build-key hotfix
([#6123](AztecProtocol/aztec-packages#6123))
([5791004](AztecProtocol/aztec-packages@5791004))
* **ci:** Ssh'ing into instances
([#6136](AztecProtocol/aztec-packages#6136))
([af3192d](AztecProtocol/aztec-packages@af3192d))
* Discard ref counts during unrolling
(noir-lang/noir#4923)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* **docs:** Add codegen to `aztec-builder` command
([#6098](AztecProtocol/aztec-packages#6098))
([4839ed9](AztecProtocol/aztec-packages@4839ed9))
* Ensure where clauses propagated to trait default definitions
(noir-lang/noir#4894)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Require for all foldable functions to use distinct return
(noir-lang/noir#4949)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))


### Miscellaneous

* Add regression test for
[#3051](AztecProtocol/aztec-packages#3051)
(noir-lang/noir#4815)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))
* Add test for recursing a foldable function
(noir-lang/noir#4948)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Adding devcontainer with create aztec app
([#5960](AztecProtocol/aztec-packages#5960))
([ae5cb21](AztecProtocol/aztec-packages@ae5cb21))
* Build docs in earthly
([#6038](AztecProtocol/aztec-packages#6038))
([784d542](AztecProtocol/aztec-packages@784d542))
* Bump bench-tx-size timeout
([#6109](AztecProtocol/aztec-packages#6109))
([aa3eefa](AztecProtocol/aztec-packages@aa3eefa))
* **ci:** Fix spot runner build key
([#6119](AztecProtocol/aztec-packages#6119))
([f332bc9](AztecProtocol/aztec-packages@f332bc9))
* **ci:** Hotfix
([#6124](AztecProtocol/aztec-packages#6124))
([f60dfcd](AztecProtocol/aztec-packages@f60dfcd))
* **ci:** Run benchmarks on Earthly
([#6089](AztecProtocol/aztec-packages#6089))
([c985c73](AztecProtocol/aztec-packages@c985c73))
* **ci:** Turn off ARM build for now
([#6135](AztecProtocol/aztec-packages#6135))
([853913f](AztecProtocol/aztec-packages@853913f))
* Disable bench-summary for now
([67485f1](AztecProtocol/aztec-packages@67485f1))
* Disable doc builds
([#6107](AztecProtocol/aztec-packages#6107))
([7933f0f](AztecProtocol/aztec-packages@7933f0f))
* **docs:** Adding matomo tracking
(noir-lang/noir#4898)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Ebs attach robustness
([#6108](AztecProtocol/aztec-packages#6108))
([c702688](AztecProtocol/aztec-packages@c702688))
* Fix typo in `ResolverError::AbiAttributeOutsideContract`
(noir-lang/noir#4933)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Migrate the prover client test to earthly
([#6118](AztecProtocol/aztec-packages#6118))
([a59a6c0](AztecProtocol/aztec-packages@a59a6c0))
* Redo typo PR by stayweek
([#6080](AztecProtocol/aztec-packages#6080))
([0869452](AztecProtocol/aztec-packages@0869452))
* Redo typo PR by vitalmotif
([#6081](AztecProtocol/aztec-packages#6081))
([1a89d1a](AztecProtocol/aztec-packages@1a89d1a))
* Refactor nested contract test for speed
([#6117](AztecProtocol/aztec-packages#6117))
([b346a2f](AztecProtocol/aztec-packages@b346a2f))
* Remove unnecessary `pub(super)` in interpreter
(noir-lang/noir#4939)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Replace relative paths to noir-protocol-circuits
([47592a2](AztecProtocol/aztec-packages@47592a2))
* Replace relative paths to noir-protocol-circuits
([f0d95f5](AztecProtocol/aztec-packages@f0d95f5))
* Update error conversion traits to act on references
(noir-lang/noir#4936)
([f060fa6](AztecProtocol/aztec-packages@f060fa6))


### Documentation

* Tweaks for release
([#6129](AztecProtocol/aztec-packages#6129))
([77b45b9](AztecProtocol/aztec-packages@77b45b9))
* Update @aztec/builder readme
([#6115](AztecProtocol/aztec-packages#6115))
([248761e](AztecProtocol/aztec-packages@248761e))
* Yellow paper updates for the parity circuits
([#6048](AztecProtocol/aztec-packages#6048))
([cfe1b05](AztecProtocol/aztec-packages@cfe1b05))
</details>

<details><summary>barretenberg: 0.37.0</summary>

##
[0.37.0](AztecProtocol/aztec-packages@barretenberg-v0.36.0...barretenberg-v0.37.0)
(2024-05-02)


### ⚠ BREAKING CHANGES

* use `distinct` return value witnesses by default
(noir-lang/noir#4951)

### Features

* Count Bb lines weighted by complexity
([#6090](AztecProtocol/aztec-packages#6090))
([705177f](AztecProtocol/aztec-packages@705177f))
* Devbox
([#5772](AztecProtocol/aztec-packages#5772))
([72321f9](AztecProtocol/aztec-packages@72321f9))
* Handle `no_predicates` attribute
(noir-lang/noir#4942)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Pippenger benchmarks compatible with wasmtime
([#6095](AztecProtocol/aztec-packages#6095))
([5297b5b](AztecProtocol/aztec-packages@5297b5b))
* Use `distinct` return value witnesses by default
(noir-lang/noir#4951)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))


### Bug Fixes

* Ensure where clauses propagated to trait default definitions
(noir-lang/noir#4894)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Require for all foldable functions to use distinct return
(noir-lang/noir#4949)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))


### Miscellaneous

* Add test for recursing a foldable function
(noir-lang/noir#4948)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* **docs:** Adding matomo tracking
(noir-lang/noir#4898)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Fix typo in `ResolverError::AbiAttributeOutsideContract`
(noir-lang/noir#4933)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
* Redo typo PR by stayweek
([#6080](AztecProtocol/aztec-packages#6080))
([0869452](AztecProtocol/aztec-packages@0869452))
* Remove unnecessary `pub(super)` in interpreter
(noir-lang/noir#4939)
([4dc5efb](AztecProtocol/aztec-packages@4dc5efb))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants