Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6086

Merged
merged 14 commits into from
May 1, 2024
Merged

feat: Sync from noir #6086

merged 14 commits into from
May 1, 2024

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: add de-sugaring for impl Trait in function parameters (noir-lang/noir#4919)
feat(experimental): comptime globals (noir-lang/noir#4918)
chore: update error conversion traits to act on references (noir-lang/noir#4936)
fix: ban self-referential structs (noir-lang/noir#4883)
chore: add regression test for #3051 (noir-lang/noir#4815)
fix: discard ref counts during unrolling (noir-lang/noir#4923)
feat!: Bit shift is restricted to u8 right operand (noir-lang/noir#4907)
END_COMMIT_OVERRIDE

AztecBot and others added 3 commits April 29, 2024 16:15
…ters (noir-lang/noir#4919)

feat(experimental): `comptime` globals (noir-lang/noir#4918)
chore: update error conversion traits to act on references (noir-lang/noir#4936)
fix: ban self-referential structs (noir-lang/noir#4883)
chore: add regression test for #3051 (noir-lang/noir#4815)
fix: discard ref counts during unrolling (noir-lang/noir#4923)
feat!: Bit shift is restricted to u8 right operand (noir-lang/noir#4907)
TomAFrench and others added 6 commits April 30, 2024 15:26
* master:
  chore: disable doc builds (#6107)
  feat: private da gas metering (#6103)
  chore: build docs in earthly (#6038)
  chore: redo typo PR by vitalmotif (#6081)
  chore: redo typo PR by stayweek (#6080)
  chore(master): Release 0.36.0 (#5791)
  fix(docs): Tutorial fixes (#5600)
  chore: prepare ScheduledValueChange for mutable delays. (#6085)
  feat: circuit simulator for Ultra and GoblinUltra verifiers (#1195)
  docs: shared state (#5963)
  feat: Avoiding redundant computation in PG (#5844)
  feat: computing sym key for incoming ciphertext (#6020)
  feat: `variable_base_scalar_mul` blackbox func (#6039)
* master:
  feat: devbox (#5772)
  docs: Yellow paper updates for the parity circuits (#6048)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: Pippenger benchmarks compatible with wasmtime (#6095)
  chore: bump bench-tx-size timeout (#6109)
  chore: ebs attach robustness (#6108)
  chore(ci): Run benchmarks on Earthly (#6089)
@TomAFrench TomAFrench closed this May 1, 2024
@TomAFrench TomAFrench reopened this May 1, 2024
@AztecBot
Copy link
Collaborator Author

AztecBot commented May 1, 2024

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (merge-rollup): 6,542 (+22%)
  • tx_pxe_processing_time_ms (0): 1,391 (-21%)
  • batch_insert_into_append_only_tree_32_depth_ms (512): 263 (-24%)
  • tx_sequencer_processing_time_ms (2): 787 (-23%)
  • tx_sequencer_processing_time_ms (4): 934 (-24%)
  • tx_sequencer_processing_time_ms (5): 2,172 (-18%)
  • tx_sequencer_processing_time_ms (8): 1,107 (-28%)
  • node_history_sync_time_in_ms (10): 31,919 (+18%)
  • l2_block_public_tx_process_time_in_ms (8): 8,994 (-18%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 740 740 740
l1_rollup_calldata_gas 6,680 6,692 6,680
l1_rollup_execution_gas 586,812 586,824 586,812
l2_block_processing_time_in_ms 1,659 (-1%) 5,379 (+3%) 10,622 (+8%)
l2_block_building_time_in_ms 22,691 (-13%) 89,527 (-1%) 177,940 (+5%)
l2_block_rollup_simulation_time_in_ms 22,480 (-12%) 88,774 (-1%) 176,461 (+5%)
l2_block_public_tx_process_time_in_ms ⚠️ 8,994 (-18%) 34,790 (-8%) 69,850 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,960 (+15%) ⚠️ 31,919 (+18%)
node_database_size_in_bytes 20,725,840 37,412,944
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 175 (-8%) 46,819 28,822
private-kernel-inner 208 (-8%) 76,734 28,822
private-kernel-ordering 229 (-8%) 53,040 42,751
base-parity 69.1 (-15%) 128 64.0
base-rollup 16,455 (+13%) 111,062 925
root-parity 1,624 (-3%) 27,064 64.0
root-rollup 64.4 (-16%) 11,454 789
public-kernel-app-logic 1,995 (-1%) 54,321 22,677
public-kernel-tail 4,870 (-2%) 159,770 3,898
merge-rollup ⚠️ 6,542 (+22%) 2,696 925
public-kernel-teardown 160 (-7%) 54,321 30,042
public-kernel-setup 220 (-4%) 54,321 30,042

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 (-4%) 17.8 (-9%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.643 (-4%) 0.547 (-9%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.8 (-5%) 80.5 (-2%) ⚠️ 263 (-24%) 504 (+3%) 990 1,968 (+2%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.530 (-5%) 0.496 (-2%) 0.478 (-24%) 0.470 (+3%) 0.468 0.469 (+2%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 61.2 (-4%) 121 (-5%) 378 (-14%) 742 (+4%) 1,480 (-4%) 2,953 (+2%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.537 (-3%) 0.542 (-4%) 0.513 (-14%) 0.509 (+3%) 0.510 (-4%) 0.512 (+1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.3
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.590 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 44,613 535,433

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms ⚠️ 1,391 (-21%) 1,015 (-8%) 3,623 (-13%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 890 (-3%) ⚠️ 787 (-23%) 1,418 (-11%) ⚠️ 934 (-24%) ⚠️ 2,172 (-18%) ⚠️ 1,107 (-28%)

@TomAFrench TomAFrench enabled auto-merge (squash) May 1, 2024 19:21
@TomAFrench TomAFrench merged commit f060fa6 into master May 1, 2024
65 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch May 1, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants