-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sign-out and tasks for all tenants #60
Conversation
@TiagoBrenck and @jmprieur I know you have plans for this sample. putting this PR on your radar. thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @mmacy thanks!
do you have the rights to merge?
@jmprier Excellent! And, no, I have no merge capability in this repo. |
Thanks @mmacy . Merged! |
@mmacy if you navigate to Azure Portal > Azure AD B2C > User flows (policies) > Your sign up/in policy > Application claims, you will see the Object ID checkbox. By checking it would fix your logout issue. I will evaluate if we need to revert the changes since we are using OID for the token cache as a standard in many samples. |
Thanks, @TiagoBrenck. I think the issue stems from MSAL remapping (?) the claim name from |
@mmacy you have a valid point. I think we use I will open a thread with MSAL team about your point. |
This enables both sign-out and task list functionality when using a tenant in one's own B2C directory or the demo
fabrikamb2c
tenant.The sample currently functions out of the box using the demo tenant,
fabrikamb2c
, but if one follows these B2C tutorials to configure it for their own B2C tenant, neither sign-out nor the task list work correctly:There is also a follow-up update I'll be making to the API doc as it's missing a needed modification to the TaskService/Web.config (addresses the busted To-Do portion of MicrosoftDocs/azure-docs#38447).
Cc: @jennyf19 @yoelhor